Maor Lipchuk has uploaded a new change for review.
Change subject: core: rename method parameters to be more clear.
......................................................................
core: rename method parameters to be more clear.
Renaming the filterImageDisks method parameters to be more clear
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
Change-Id: Ic9805e5fadcc29ab5537eeecffe6bddafe428038
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/48/25348/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
index 3602335..5cdaab2 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
@@ -508,24 +508,24 @@
*
* @param listOfDisks
* - The list of disks to be filtered.
- * @param allowOnlyNotShareableDisks
+ * @param filterOutShareable
* - Indication whether to allow only disks that are not
shareable
- * @param allowOnlySnapableDisks
+ * @param filterOutNotSnapable
* - Indication whether to allow only disks which are allowed
to be snapshoted.
- * @param allowOnlyActiveDisks
+ * @param filterOutNotActiveDisks
* - Indication whether to allow only disks that are not disk
snapshots.
* @return - List filtered of disk images according to the given filters.
*/
public static List<DiskImage> filterImageDisks(Collection<? extends Disk>
listOfDisks,
- boolean
allowOnlyNotShareableDisks,
- boolean
allowOnlySnapableDisks,
- boolean
allowOnlyActiveDisks) {
+ boolean filterOutShareable,
+ boolean
filterOutNotSnapable,
+ boolean
filterOutNotActiveDisks) {
List<DiskImage> diskImages = new ArrayList<DiskImage>();
for (Disk disk : listOfDisks) {
if (disk.getDiskStorageType() == DiskStorageType.IMAGE &&
- (!allowOnlyNotShareableDisks || !disk.isShareable()) &&
- (!allowOnlySnapableDisks || disk.isAllowSnapshot()) &&
- (!allowOnlyActiveDisks ||
Boolean.TRUE.equals(((DiskImage)disk).getActive()))) {
+ (!filterOutShareable || !disk.isShareable()) &&
+ (!filterOutNotSnapable || disk.isAllowSnapshot()) &&
+ (!filterOutNotActiveDisks ||
Boolean.TRUE.equals(((DiskImage)disk).getActive()))) {
diskImages.add((DiskImage) disk);
}
}
--
To view, visit http://gerrit.ovirt.org/25348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9805e5fadcc29ab5537eeecffe6bddafe428038
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
