[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-18 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Remove VMDAO.getById .. core: Remove VMDAO.getById Removed VMDAO.getById - It basically did VMDAO.get, and then added the network interfaces, which

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-18 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Remove VMDAO.getById .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3604 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-18 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove VMDAO.getById .. Patch Set 4: Verified rebased, no changes since last review. -- To view, visit http://gerrit.ovirt.org/3604 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-18 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove VMDAO.getById .. Patch Set 3: Verified answered ofrenkel's comments mkublin - I'm not going to change flows of commands in this patch - too many c

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Remove VMDAO.getById .. Patch Set 2: (1 inline comment) File backend/manager/modules/bll/src/main/ja

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Remove VMDAO.getById .. Patch Set 2: (2 inline comments) File backend/manager/modules/bll/src/main/j

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-17 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Remove VMDAO.getById .. Patch Set 1: (4 inline comments) File backend/manager/modules/bll/src/main/jav

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-17 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Remove VMDAO.getById .. -- To view, visit http://gerrit.ovirt.org/3604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove VMDAO.getById .. Patch Set 2: Verified Basically just a rebase. Cleaned up SetDedicatedVMCommand a bit, since in retrospect it does not require n

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove VMDAO.getById .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

[Engine-patches] Change in ovirt-engine[master]: core: Remove VMDAO.getById

2012-04-17 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Remove VMDAO.getById .. core: Remove VMDAO.getById Removed VMDAO.getById - It basically did VMDAO.get, and then added the network interfaces, which is an