Omer Frenkel has posted comments on this change. Change subject: core: Remove VMDAO.getById ......................................................................
Patch Set 1: (4 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java Line 103: VmHandler.updateNetworkInterfacesFromDb(vm); consult with mike if needed .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetDedicatedVmCommand.java Line 31: VmHandler.updateNetworkInterfacesFromDb(vm); can be removed .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java Line 33: // It should probably be removed, but some research is required. line 54 loops over curVm.getInterfaces() so i guess it is needed and you can remove this TODO .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java Line 49: // It should probably be removed, but some research is required. can be removed -- To view, visit http://gerrit.ovirt.org/3604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2590f6d85a2bb74129167af1d817d668f4d0fcfb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
