oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/10890/
: SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/920/ :
SUCCESS
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix double checking
..
core: Fix double checking
These getInstance() methods implement a double-checking scheme to
initialize the instance static
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, v
Roy Golan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/set
Allon Mureinik has restored this change.
Change subject: core: Fix double checking
..
Restored
Restoring after discussion with Roy
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/
Itamar Heim has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
Roy - so do we say we ignore this findbugs issue, or do we think its correct
and should be fixed?
one way or the other,
Allon Mureinik has abandoned this change.
Change subject: core: Fix double checking
..
Abandoned
Stale.
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageTyp
Roy Golan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
there's isn't much here really
just fix those
1. make default constructor private (did you look at it? its protected althou
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
@Roy - I didn't understand your bottom line here (gave +1 and then canceled) it.
Are you OK with this change or not? C
Roy Golan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3: -Code-Review
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Roy Golan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Alissa Bonas has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
Joining Allon's opinion.
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org
Alissa Bonas has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
@Roy? your two cents? is this explanation satisfactory?
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscri
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3: Code-Review+1
I agree with Allon's comment on the class loading.
--
To view, visit http://gerrit.ovirt.org/18655
To
Tal Nisan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
Agreed, you just shed this info now so it makes sense not to use it
--
To view, visit http://gerrit.ovirt.org/18655
To un
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
That means the initialization of the class in done during CLASSLOADING.
Both these class' initializations access the D
Tal Nisan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
Can't we just change it to have a class static member like Roy offered? Makes
more sense to me
--
To view, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
Actually, if you initialize the instance during class loading, you don't even
need to specify it as volatile...
--
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
@Roy - I agree, but that means changing the semantics of these classes, which
I'm not too eager to do right now.
I t
Roy Golan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
in fact the double check idiom for singletons is obsolete. a static volatile
member is enough becuase the class loader is
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3: Verified+1
Made fixes to previous patch in series, no changes in this one.
Disregard the jenkins job - it's a false p
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7365/
:
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 2:
(1 comment)
File
backend/manager/modules/bll/src/main/java/org/
Tal Nisan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 2:
(1 comment)
File
backend/manager/modules/bll/src/main/java/org/ovirt
Alissa Bonas has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 2: Code-Review+1
(1 comment)
File
backend/manager/modules/bll/src/ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7340/
: SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7332/
: SUCCES
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix double checking
..
core: Fix double checking
These getInstance() methods implement a double-checking scheme to
initialize the instance static member.
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix double checking
..
core: Fix double checking
VdsLoadBalancer.getInstance() implements a double-checking scheme to
initialize the instance sta
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no changes.
Hopefully to be deleted soon :-)
--
To view, visit http:/
Laszlo Hornyak has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 1: Looks good to me, approved
Hi Allon,
Looks correct, however this class may soon be deleted (hopefuly)
http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/1623/
: SUCCES
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix double checking
..
core: Fix double checking
VdsLoadBalancer.getInstance() implements a double-checking scheme to
initialize the instance static memb
Allon Mureinik has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/16810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Shahar Havivi has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16810
To unsubscribe, visit
39 matches
Mail list logo
