Allon Mureinik has uploaded a new change for review. Change subject: core: Fix double checking ......................................................................
core: Fix double checking VdsLoadBalancer.getInstance() implements a double-checking scheme to initialize the instance static member. In order for this mechanism to operate correctly, the instance member should be defined as volatile (see, e.g., http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html). Change-Id: I980c2f5117f05bd2b7928b251f730636fc4d26fe Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/16810/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java index 438cfdd..8cbad68 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java @@ -19,7 +19,7 @@ */ public final class VdsLoadBalancer { private static Log log = LogFactory.getLog(VdsLoadBalancer.class); - private static VdsLoadBalancer instance = null; + private static volatile VdsLoadBalancer instance = null; private MigrationHandler migrationHandler = null; public static VdsLoadBalancer getInstance() { -- To view, visit http://gerrit.ovirt.org/16810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I980c2f5117f05bd2b7928b251f730636fc4d26fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
