Doron Fediuck has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 2:
Just reminding you that this class may be used from commandline utilities,
which means it will be called many t
Juan Hernandez has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 2:
Yaniv, I agree that loading the keystore every time it is used is not optimal.
Would you mind to open a bug to
Yaniv Kaul has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 2:
I understand where the leak is, but I don't understand why we bother opening
the file again and again (and now wit
Juan Hernandez has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 1: Verified
I verified that with this change, even if the keystore file contains junk and
can't be used, the file
Oved Ourfali has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5423
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 1: Looks good to me, but someone else must approve
For some reason I thought commons-io was already a dependency (
Juan Hernandez has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/engineenc
Allon Mureinik has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/engineenc
Juan Hernandez has uploaded a new change for review.
Change subject: core: Close store file after use
..
core: Close store file after use
We need to close the keystore file after using it, otherwise we
will have a file descripto
