Juan Hernandez has posted comments on this change.
Change subject: core: Close store file after use
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java
Line 223: if (storeIn != null) {
I agree, that would be smarter, but it would require to add commons-io as a new
dependency to the project, modify the root POM, etc. I don't dislike the idea.
Should we do it?
--
To view, visit http://gerrit.ovirt.org/5423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0546374668113de4b50871e0fdd985740e04cf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Robert Middleswarth <rob...@middleswarth.net>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
