Saggi Mizrahi has abandoned this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 5: Abandoned
There is no reason helping those who refuse to be helped
--
To view, visit http://gerrit.ovirt.org/2271
To unsub
Maor Lipchuk has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4:
-1 was since Test illegalCpuChange associated with UpdateVdsGroupCommandTest
fails
--
To view, visit http://gerri
Maor Lipchuk has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/src/main/
Omer Frenkel has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4:
i am sorry but i still dont like methods that return true in the body and false
in the end, it is the other way ar
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4: (1 inline comment)
Could you please change the -1 to a +1 then?
.
Maor Lipchuk has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/src/main/
Ayal Baron has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/src/main/ja
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/src/main
Maor Lipchuk has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Test illegalCpuChange associated with UpdateVdsGroup
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4:
Returning true or false is inconsequential to the general philosophy of early
return.
You return early, with any
Omer Frenkel has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 4:
you didnt understand my comment at all. im in favour of returning false once
check is failed, i do think this make
Ayal Baron has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 3: (2 inline comments)
Omer,
"i really don't like the way some methods return true in the middle of it, as
it is hard
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 3:
And the functions are now very short so being very careful isn't a big deal.
You should always be mind where you
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 3:
I know that this is the philosophy but I claim that the other is confusing.
The idea is bail up first and bail ou
Omer Frenkel has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 3: (6 inline comments)
i really don't like the way some methods return true in the middle of it, as it
is hard to und
Ayal Baron has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2271
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 2: I would prefer that you didn't submit this
(22 inline comments)
As in the other patch, only substantial thing is the
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main
Maor Lipchuk has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/bll/src/main
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateVdsGroupCommand
..
Patch Set 1:
I'm not that good at testing the engine so wait until you get a verified from
someone else before pushing this in
Saggi Mizrahi has uploaded a new change for review.
Change subject: Refactor UpdateVdsGroupCommand
..
Refactor UpdateVdsGroupCommand
I'm a measly python programmer. I can't follow your long invocation
chains and complex conditio
21 matches
Mail list logo
