Omer Frenkel has posted comments on this change. Change subject: Refactor UpdateVdsGroupCommand ......................................................................
Patch Set 4: i am sorry but i still dont like methods that return true in the body and false in the end, it is the other way around to how we have all this kind of methods, it is confusing and hard to maintain. also im strongly against methods that mix return values like validateMemberVmsState -- To view, visit http://gerrit.ovirt.org/2271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47300fec2f6f5fabdbc75e8c78332c5aef2508a2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Haim Ateya <hat...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
