[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-16 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 5: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23124 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-16 Thread ydary
Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: rewrite .. packaging: setup: rewrite missing is checking the MinimalETLVersion during setup, it is not really required as setup is merged

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 5: there is no reason. please test it more until you feel comfortable, there is no sense in leaving both. we can always d

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-15 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 5: I want to merge this, but I want to keep legacy in the repo for now, since this is not well tested. Please undelete it an

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-15 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23124 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-15 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23124 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-15 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 4: Very well. Just change the 'ware house' thing... -- To view, visit http://gerrit.ovirt.org/23124 To unsubscribe,

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 4: different hosts are not supported, as they were not supported so far. this is future work, I hope you guys can complete

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-14 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 4: (1 comment) Are the following setups intended to be supported? By the current change, or a future one? Manual or

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-14 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 4: Verified+1 Code-Review+1 I have test clean local install and it seems to work ok. -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/23124/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-14 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 2: (3 comments) Very nice. Few small comments. Didn't verify - did you? http://gerrit.ovirt.org/#/c/23124/2/packagi

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-14 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23124 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: rewrite

2014-01-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: rewrite .. Patch Set 1: this requires engine patchset[1]. please test so we can perfect it. [1] http://gerrit.ovirt.org/#/q/status:open+proje