Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: rewrite ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/23124/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py: Line 53: ] = dialog.queryBoolean( Line 54: dialog=self.dialog, Line 55: name='OVESETUP_DWH_ENABLE', Line 56: note=_( Line 57: 'Install dataware house on this host ' > data warehouse Done Line 58: '(@VALUES@) [@DEFAULT@]: ' Line 59: ), Line 60: prompt=True, Line 61: default=True, http://gerrit.ovirt.org/#/c/23124/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/service.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/service.py: Line 37: Line 38: @plugin.event( Line 39: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 40: ) Line 41: def _customization(self): > isn't that a duplication of misc? right! good catch! Line 42: if self.environment[ Line 43: odwhcons.CoreEnv.ENABLE Line 44: ] is None: Line 45: self.environment[ http://gerrit.ovirt.org/#/c/23124/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py: Line 160: odwhcons.FileLocations.LEGACY_CONFIG Line 161: ), Line 162: ) Line 163: def _closeup(self): Line 164: os.unlink(odwhcons.FileLocations.LEGACY_CONFIG) > I prefer to have a backup - either rename here or using first a filetransac if all success I do not see any reason to do so, as no rollback anyway, I can leave it as is without any backup. Line 165: Line 166: -- To view, visit http://gerrit.ovirt.org/23124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3cceaac390d5d373d2d1f5e46171305ae590b51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
