[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-11 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: fixed the collect method signature .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/31223 To unsubsc

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-11 Thread alitke
Adam Litke has submitted this change and it was merged. Change subject: fixed the collect method signature .. fixed the collect method signature Change-Id: I03d592bffe282350fede03132bebb83ff03665aa Signed-off-by: Jiri Moskovcak

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-07 Thread jmoskovc
Jiří Moskovčák has posted comments on this change. Change subject: fixed the collect method signature .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/31223 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-07 Thread jmoskovc
Jiří Moskovčák has posted comments on this change. Change subject: fixed the collect method signature .. Patch Set 2: actually you're not overriding it, if you derive from Collector you're not forced to override the method, yo

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-07 Thread alitke
Adam Litke has posted comments on this change. Change subject: fixed the collect method signature .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31223 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-07 Thread jmoskovc
Jiří Moskovčák has posted comments on this change. Change subject: fixed the collect method signature .. Patch Set 2: just fixing it for correctness, pep8 complains about it -- To view, visit http://gerrit.ovirt.org/31223 To

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-07 Thread jmoskovc
Jiří Moskovčák has uploaded a new change for review. Change subject: fixed the collect method signature .. fixed the collect method signature Change-Id: I03d592bffe282350fede03132bebb83ff03665aa Signed-off-by: Jiri Moskovcak --

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-07 Thread alitke
Adam Litke has posted comments on this change. Change subject: fixed the collect method signature .. Patch Set 1: I'd like to get a bit of background on this one. We've been running MOM just fine with the code as-is ever sinc

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: fixed the collect method signature .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/31223 To unsubsc

[Engine-patches] Change in mom[master]: fixed the collect method signature

2014-08-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: fixed the collect method signature .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/31223 To unsubsc