Jiří Moskovčák has posted comments on this change. Change subject: fixed the collect method signature ......................................................................
Patch Set 2: actually you're not overriding it, if you derive from Collector you're not forced to override the method, you just can't call it's because it doesn't take self as a parameter and it you try to call it it dies with "collect() takes no arguments (1 given)" and if you define collect(self) it's shadowing the name, not overriding it, as it has different signature, so in subclass you're implementing different API then the Collector class defines. -- To view, visit http://gerrit.ovirt.org/31223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03d592bffe282350fede03132bebb83ff03665aa Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
