Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 8: Code-Review-1
(2 comments)
Just a couple of minor things. Please address my recurring comment about
swap_us
Martin Sivák has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 8: Code-Review+1
I think I am ok with this.
--
To view, visit http://gerrit.ovirt.org/34528
To unsubscribe, v
automat...@ovirt.org has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/34528
To unsu
Martin Sivák has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 7:
Please name the files the other way around (GuestMemory and
GuestMemoryOptional). If mom is updated and vds
automat...@ovirt.org has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/34528
To unsu
automat...@ovirt.org has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/34528
To unsu
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 5: Code-Review-1
(1 comment)
Martin, yes. We decided to create a new Collector for this in order to
maintain B
Martin Sivák has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 5:
Didn't we decide to make a new collector that will inherit from GuestMemory and
only change the mandatory/o
automat...@ovirt.org has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 5:
* Update tracker::#1143992::OK
--
To view, visit http://gerrit.ovirt.org/34528
To unsubscribe, vis
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
ping?
--
To view, visit http://gerrit.ovirt.org/34528
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/34528/4/mom/Collectors/GuestMemory.py
File mom/Collectors/GuestMemor
Roy Golan has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/34528/4/mom/Collectors/GuestMemory.py
File mom/Collectors/GuestMemory
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/34528/4/mom/Entity.py
File mom/Entity.py:
Line 90: Get the
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/34528/4/mom/Collectors/GuestMemory.py
File mom/Collect
Roy Golan has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/34528/4/mom/Entity.py
File mom/Entity.py:
Line 106:
Martin Sivák has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
(2 comments)
I think the example policy will have to be modified as well. And also the
policy shipped with
automat...@ovirt.org has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
* Update tracker::#1143992::OK
--
To view, visit http://gerrit.ovirt.org/34528
To unsubscribe, vis
17 matches
Mail list logo
