Gal Hammer has uploaded a new change for review.
Change subject: agent: handle failures on Windows' write requests.
..
agent: handle failures on Windows' write requests.
Windows' virtio-serial driver behavior was changed so a wr
Gal Hammer has posted comments on this change.
Change subject: Adjusting the ovirt-guest-agent to the new way of SSO
..
Patch Set 5: (1 inline comment)
I don't understand what you tried to do here. Did you just want to get rid
Gal Hammer has posted comments on this change.
Change subject: agent: Send 'uninstalled' notification non blocking
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10476
Gal Hammer has uploaded a new change for review.
Change subject: agent: a new non-blocking "uninstalled" notification.
..
agent: a new non-blocking "uninstalled" notification.
The "echo" command blocks if the host is not connect
Gal Hammer has posted comments on this change.
Change subject: agent: fixed "modified" files after clone.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10420
To unsubscribe, visit http://gerrit.ovirt.org/se
Gal Hammer has uploaded a new change for review.
Change subject: agent: fixed "modified" files after clone.
..
agent: fixed "modified" files after clone.
Due to CR/LF issue some files were reported as "modified" even after
new c
Gal Hammer has posted comments on this change.
Change subject: agent: rewrote nic's addresses functions in python 2.4 syntax.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10378
To unsubscribe, visit http:/
Gal Hammer has uploaded a new change for review.
Change subject: agent: rewrote nic's addresses functions in python 2.4 syntax.
..
agent: rewrote nic's addresses functions in python 2.4 syntax.
Change-Id: I17c6fb0dc2ac8186771554
Gal Hammer has posted comments on this change.
Change subject: updated change-log for version 1.0.7
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10369
To un
Gal Hammer has uploaded a new change for review.
Change subject: updated change-log for version 1.0.7
..
updated change-log for version 1.0.7
Change-Id: I8439b85ca0b479455dc7b03ff25ceccd04594f60
Signed-off-by: Gal Hammer
---
M
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5: No score
--
To view, visit http://gerrit.ovirt.org/9463
To unsubscribe, visit http://gerrit.ovirt.o
Gal Hammer has abandoned this change.
Change subject: agent: apply virtual-guest tuning profile on installation.
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/9361
To unsubscribe, visit http://gerrit.ovirt
Gal Hammer has posted comments on this change.
Change subject: Let udev reset user rights on virtio-channel during package
removal
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Gal Hammer has posted comments on this change.
Change subject: agent: added win8 and win2012 to reported os version.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9010
To unsubscribe, visit http://gerrit.ov
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5:
Yes. That's what I said at first.
--
To view, visit http://gerrit.ovirt.org/9463
To unsubscribe, v
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/9463
To unsubs
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 4:
Alon, I know that VC can handle LF. The problem is that "someone" will alway
forget a file (the in
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 4: I would prefer that you didn't submit this
See my previous comment.
--
To view, visit http://gerri
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 1: I would prefer that you didn't submit this
Please don't do that to Windows-only projects' files.
-
Gal Hammer has posted comments on this change.
Change subject: agent: apply virtual-guest tuning profile on installation.
..
Patch Set 1: I would prefer that you didn't submit this
The tuned profile should not be be set by the
Gal Hammer has uploaded a new change for review.
Change subject: agent: apply virtual-guest tuning profile on installation.
..
agent: apply virtual-guest tuning profile on installation.
Change-Id: I9d3d6ee2bd090f5cc37697343e937f
Gal Hammer has posted comments on this change.
Change subject: agent: added win8 and win2012 to reported os version.
..
Patch Set 1:
I agree that a general solution is possible but I'll consider it when Windows 9
will be out ;
Gal Hammer has uploaded a new change for review.
Change subject: agent: added win8 and win2012 to reported os version.
..
agent: added win8 and win2012 to reported os version.
Change-Id: I80d2fdce98479f0d2ecf693c08bb84aff44c4465
Gal Hammer has posted comments on this change.
Change subject: replaced agent license to apache software license (asl) 2.0.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8469
To unsubscribe, visit http://ge
Gal Hammer has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 1: (5 inline comments)
File ovirt-gu
Gal Hammer has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
..
Patch Set 1: I would prefer that you didn't submit this
(11 inline comments)
.
Gal Hammer has posted comments on this change.
Change subject: agent: Added APT package list support
..
Patch Set 7: (1 inline comment)
Commit Message
Line 3: AuthorDate: 201
Gal Hammer has posted comments on this change.
Change subject: agent: Added APT package list support (BZ#838632)
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8642
To
Gal Hammer has posted comments on this change.
Change subject: agent: Added APT package list support (BZ#838632)
..
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
..
Gal Hammer has posted comments on this change.
Change subject: agent: Added APT package list support (BZ#838632)
..
Patch Set 3: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/8642
To unsub
Gal Hammer has posted comments on this change.
Change subject: agent: Added APT package list support (BZ#838632)
..
Patch Set 2: (3 inline comments)
File ovirt-guest-agent/Gu
Gal Hammer has posted comments on this change.
Change subject: replaced agent license to apache software license (asl) 2.0.
..
Patch Set 1: (1 inline comment)
File ovirt-gues
Gal Hammer has posted comments on this change.
Change subject: replaced agent license to apache software license (asl) 2.0.
..
Patch Set 1: Verified
rpm build was successful.
--
To view, visit http://gerrit.ovirt.org/8469
To u
Gal Hammer has posted comments on this change.
Change subject: agent: new implementation for installed application function.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6180
To unsubscribe, visit http://g
Gal Hammer has posted comments on this change.
Change subject: agent: new implementation for nics' information function.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6183
To unsubscribe, visit http://gerri
Gal Hammer has posted comments on this change.
Change subject: agent: new implementation for nics' information function.
..
Patch Set 1: (4 inline comments)
File ovirt-guest-
Gal Hammer has posted comments on this change.
Change subject: agent: new implementation for nics' information function.
..
Patch Set 1: (1 inline comment)
File ovirt-guest-a
Gal Hammer has posted comments on this change.
Change subject: agent: new implementation for nics' information function.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6183
To unsubscribe, visit http://gerri
Gal Hammer has posted comments on this change.
Change subject: agent: new implementation for installed application function.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6180
To unsubscribe, visit http://g
Gal Hammer has uploaded a new change for review.
Change subject: agent: new implementation for nics' information function.
..
agent: new implementation for nics' information function.
The new implementation allows the agent to r
Gal Hammer has uploaded a new change for review.
Change subject: agent: new implementation for installed application function.
..
agent: new implementation for installed application function.
The new implementation allows the ag
Gal Hammer has posted comments on this change.
Change subject: core: WIP - Add support for Qemu GA (#830954)
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules
Gal Hammer has posted comments on this change.
Change subject: agent: fixed removal of agent's dir on uninstall (bz#679451).
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4605
To unsubscribe, visit http://g
Gal Hammer has posted comments on this change.
Change subject: agent: fixed various rpmlint errors and warnings.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4604
To unsubscribe, visit http://gerrit.ovirt.
Gal Hammer has posted comments on this change.
Change subject: agent: fixed 'udevadm trigger' command line (bz#819945).
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/4560
To unsubscribe, visit http://gerrit
Gal Hammer has uploaded a new change for review.
Change subject: agent: fixed various rpmlint errors and warnings.
..
agent: fixed various rpmlint errors and warnings.
Change-Id: I7a13d4a345ab3300713e20c291ef8549d0e6f765
Signed-
Gal Hammer has uploaded a new change for review.
Change subject: agent: fixed removal of agent's dir on uninstall (bz#679451).
..
agent: fixed removal of agent's dir on uninstall (bz#679451).
Change-Id: I23e6c63421e28ea38277b156
Gal Hammer has posted comments on this change.
Change subject: agent: fixed 'udevadm trigger' command line (bz#819945).
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4560
To unsubscribe, visit http://gerrit
Gal Hammer has posted comments on this change.
Change subject: agent: fixed 'udevadm trigger' command line (bz#819945).
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4560
To unsubscribe, visit http://gerrit
Gal Hammer has uploaded a new change for review.
Change subject: agent: fixed 'udevadm trigger' command line (bz#819945).
..
agent: fixed 'udevadm trigger' command line (bz#819945).
The previous command line cause the trigger to
Gal Hammer has posted comments on this change.
Change subject: agent: updated spec file to version 1.0.4-1
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4430
To unsubscribe, visit http://gerrit.ovirt.org/se
Gal Hammer has posted comments on this change.
Change subject: Use %{_unitdir} to point systemd file.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4362
To unsubscribe, visit http://gerrit.ovirt.org/setting
Gal Hammer has posted comments on this change.
Change subject: agent: added files to support RHEL-5 distribution.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3718
To unsubscribe, visit http://gerrit.ovirt
Gal Hammer has uploaded a new change for review.
Change subject: agent: updated spec file to version 1.0.4-1
..
agent: updated spec file to version 1.0.4-1
Change-Id: I4a94a5d1fd842a810f974c6071867e2ab75eb4f8
Signed-off-by: Gal
Gal Hammer has uploaded a new change for review.
Change subject: Use %{_unitdir} to point systemd file.
..
Use %{_unitdir} to point systemd file.
Change-Id: I2504b56e6f05e3ecd420342097402fe433ca597f
Signed-off-by: Gal Hammer
--
Gal Hammer has uploaded a new change for review.
Change subject: agent: added files to support RHEL-5 distribution.
..
agent: added files to support RHEL-5 distribution.
Change-Id: I6ff4b89b3c47d3a0f7d7b04b0c1d9fb3c056e12c
---
M
Gal Hammer has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Patch Set 9: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerr
Gal Hammer has posted comments on this change.
Change subject: agent: acquire network interfaces' information using wmi.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3656
To unsubscribe, visit http://gerri
Gal Hammer has posted comments on this change.
Change subject: Serveral changes after comments from Steven Dake.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3655
To unsubscribe, visit http://gerrit.ovirt.
Gal Hammer has uploaded a new change for review.
Change subject: Serveral changes after comments from Steven Dake.
..
Serveral changes after comments from Steven Dake.
- removed the RHEL distribution support for the review proce
Gal Hammer has uploaded a new change for review.
Change subject: agent: acquire network interfaces' information using wmi.
..
agent: acquire network interfaces' information using wmi.
Change-Id: I7d031dc7284d51331f988bed6b6c0002
Gal Hammer has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Gal Hammer has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Patch Set 8:
Thanks for the pythoncom.CoInitialize() tip!
I've tested the your patch and on a VM wi
Gal Hammer has posted comments on this change.
Change subject: agent: renamed to rhevm-guest-agent in RHEL distribution.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3419
To unsubscribe, visit http://gerri
Gal Hammer has posted comments on this change.
Change subject: updated change-log for version 1.0.2-1.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3149
To unsubscribe, visit http://gerrit.ovirt.org/settin
Gal Hammer has uploaded a new change for review.
Change subject: agent: renamed to rhevm-guest-agent in RHEL distribution.
..
agent: renamed to rhevm-guest-agent in RHEL distribution.
Change-Id: I7825920f81a37cf4139aa4f37f111510
Gal Hammer has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Patch Set 7: Looks good to me, but someone else must approve
(2 inline comments)
..
Gal Hammer has uploaded a new change for review.
Change subject: updated change-log for version 1.0.2-1.
..
updated change-log for version 1.0.2-1.
Change-Id: I3f498eacb6911c114569d5b34caa580d6b68a1af
---
M ovirt-guest-agent.spe
Gal Hammer has posted comments on this change.
Change subject: agent: included a gpl-v2 copying file to match the license
stated in spec file.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3012
To unsubscr
Gal Hammer has posted comments on this change.
Change subject: agent: updated required selinux-policy version (rhbz#791113).
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/2220
To unsubscribe, visit http://g
Gal Hammer has posted comments on this change.
Change subject: agent: updated required selinux-policy version (rhbz#791113).
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/2220
To unsubscribe, visit http://g
Gal Hammer has posted comments on this change.
Change subject: agent: build the gdm-plugin using the gdm-devel package.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3011
To unsubscribe, visit http://gerrit
Gal Hammer has posted comments on this change.
Change subject: agent: build the gdm-plugin using the gdm-devel package.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3011
To unsubscribe, visit http://gerrit
Gal Hammer has posted comments on this change.
Change subject: Build gdm and kdm plugin for RHEL distribution.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/2925
To unsubscribe, visit http://gerrit.ovirt.or
Gal Hammer has abandoned this change.
Change subject: agent: updated required selinux-policy version (rhbz#791113).
..
Patch Set 1: Abandoned
Wrong selinux policy version.
--
To view, visit http://gerrit.ovirt.org/3013
To unsu
Gal Hammer has posted comments on this change.
Change subject: Build gdm and kdm plugin for RHEL distribution.
..
--
To view, visit http://gerrit.ovirt.org/2925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Gal Hammer has posted comments on this change.
Change subject: Build gdm and kdm plugin for RHEL distribution.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/2925
To unsubscribe, visit http://gerrit.ovirt.or
Gal Hammer has posted comments on this change.
Change subject: Use SystemV-style init script for RHEL distribution.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2923
To unsubscribe, visit http://gerrit.ovi
Gal Hammer has posted comments on this change.
Change subject: Added new command line arguments to the agent executable.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2922
To unsubscribe, visit http://gerri
Gal Hammer has posted comments on this change.
Change subject: Renamed agent's user to ovirtagent.
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2921
To unsu
Gal Hammer has posted comments on this change.
Change subject: Renamed agent's user to ovirtagent.
..
--
To view, visit http://gerrit.ovirt.org/2921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: c
Gal Hammer has posted comments on this change.
Change subject: Renamed agent's user to ovirtagent.
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2921
To unsu
Gal Hammer has posted comments on this change.
Change subject: agent: updated required selinux-policy version (rhbz#791113).
..
Patch Set 1: (1 inline comment)
File ovirt-gue
Gal Hammer has uploaded a new change for review.
Change subject: agent: updated required selinux-policy version (rhbz#791113).
..
agent: updated required selinux-policy version (rhbz#791113).
Change-Id: Ic18dcf7ce1cc08b88f92653e
Gal Hammer has uploaded a new change for review.
Change subject: agent: included a gpl-v2 copying file to match the license
stated in spec file.
..
agent: included a gpl-v2 copying file to match the license stated in spec file.
Gal Hammer has uploaded a new change for review.
Change subject: agent: build the gdm-plugin using the gdm-devel package.
..
agent: build the gdm-plugin using the gdm-devel package.
Change-Id: Ib405afb2d8f467e33fe29f9c3feafe0452
Gal Hammer has uploaded a new change for review.
Change subject: Build gdm and kdm plugin for RHEL distribution.
..
Build gdm and kdm plugin for RHEL distribution.
Change-Id: Iec3983c08cc499532a7c4b9a705e927bd1ae1db4
---
M Makef
Gal Hammer has uploaded a new change for review.
Change subject: Added new command line arguments to the agent executable.
..
Added new command line arguments to the agent executable.
The new command line arguments will have run
Gal Hammer has uploaded a new change for review.
Change subject: Renamed agent's user to ovirtagent.
..
Renamed agent's user to ovirtagent.
Change-Id: Ia26e710acfc7826cb020ecf49d00c9985d5fc633
---
M ovirt-guest-agent.spec
M ovir
Gal Hammer has uploaded a new change for review.
Change subject: Use SystemV-style init script for RHEL distribution.
..
Use SystemV-style init script for RHEL distribution.
Change-Id: Ic91b5f81a04e38741a9ba0e32f73a12ee621ce47
-
Gal Hammer has posted comments on this change.
Change subject: Added a Gina dll solution to support SSO on win XP For further
information about Gina interface take a look at:
http://msdn.microsoft.com/en-us/library/aa375457%28v=vs.85%29.aspx
..
Gal Hammer has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
..
Patch Set 1: (3 inline comments)
Thanks for the patch. Seems okay to me.
I just wonder if the new i
Gal Hammer has uploaded a new change for review.
Change subject: agent: updated required selinux-policy version (rhbz#791113).
..
agent: updated required selinux-policy version (rhbz#791113).
Change-Id: Ia60bf46a7e52279ed9419de7
Gal Hammer has uploaded a new change for review.
Change subject: agent: replaced init.d style script to systemd.
..
agent: replaced init.d style script to systemd.
Change-Id: I196cfd5cfe1d53edd4bb45be1b3d1247663cb50a
---
M confi
Gal Hammer has uploaded a new change for review.
Change subject: agent: removed some requires from the spec file as a response
to Pavel Zhukov's comments.
..
agent: removed some requires from the spec file as a response to Pavel
Gal Hammer has uploaded a new change for review.
Change subject: agent: more spec file fixes after Stephen Gordon's review.
..
agent: more spec file fixes after Stephen Gordon's review.
Change-Id: Ic2a1fc10e51b70391dcde8abb9a6a3
Gal Hammer has posted comments on this change.
Change subject: Add the prefix 'with' to the configure option '--gdm-src-dir'
in the output of `configure --help`
..
Patch Set 1: Verified; Looks good to me, but someone else must
Gal Hammer has posted comments on this change.
Change subject: Don't remove ovirt-guest-agent/ovirt-guest-agent on 'make clean'
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Thanks. I tried to rememb
Gal Hammer has posted comments on this change.
Change subject: agent: added a support for a guest hibernate command.
..
Patch Set 1: (2 inline comments)
File ovirt-guest-agen
Gal Hammer has uploaded a new change for review.
Change subject: agent: added a support for a guest hibernate command.
..
agent: added a support for a guest hibernate command.
Change-Id: Ic360fa47576121dd7c9e3bddcf758843cb1847b3
100 matches
Mail list logo
