Moti Asayag has posted comments on this change.
Change subject: engine: Use java naming convention for method argument
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37611
To unsubscribe, visit http://ger
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fix permission addition
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37612
To unsubscribe, visit http://gerrit.ovirt.org/sett
automat...@ovirt.org has posted comments on this change.
Change subject: userportal,webadmin: removed useless class.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Mucha has uploaded a new change for review.
Change subject: userportal,webadmin: removed useless class.
..
userportal,webadmin: removed useless class.
Change-Id: I7fb82f9390633bd33cb067d7df7f7bf95caff70e
Signed-off-by: Ma
Martin Mucha has uploaded a new change for review.
Change subject: userportal,webadmin: refactored badly overgrown method to more
understandable parts
..
userportal,webadmin: refactored badly overgrown method to more understanda
Martin Mucha has uploaded a new change for review.
Change subject: userportal,webadmin: repetitive instanceof checks in one big
method traded off for two rather similar methods.
..
userportal,webadmin: repetitive instanceof chec
automat...@ovirt.org has posted comments on this change.
Change subject: userportal,webadmin: repetitive instanceof checks in one big
method traded off for two rather similar methods.
..
Patch Set 1:
* Update tracker::IGNORE,
automat...@ovirt.org has posted comments on this change.
Change subject: userportal,webadmin: refactored badly overgrown method to more
understandable parts
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bu
anmolbabu has posted comments on this change.
Change subject: engine : bll command to set geo-rep config
..
Patch Set 7:
(4 comments)
http://gerrit.ovirt.org/#/c/35999/7/backend/manager/modules/bll/src/main/java/org/ovirt/engi
anmolbabu has posted comments on this change.
Change subject: engine : Geo-rep config Vds Commands
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/35972/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/
Martin Mucha has posted comments on this change.
Change subject: core: Introduce postConstruct for commands
..
Patch Set 5: Verified+1
(1 comment)
http://gerrit.ovirt.org/#/c/37599/5//COMMIT_MSG
Commit Message:
Line 21: we wo
Martin Mucha has posted comments on this change.
Change subject: core: Use postConstruct in AddVmCommand
..
Patch Set 3: Verified+1
(1 comment)
http://gerrit.ovirt.org/#/c/37601/3/backend/manager/modules/bll/src/test/java/org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal, webadmin: refactor use of PatternFly grid classes
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_creat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Modify webadmin and userportal to use enginesso for
authentication
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa : Add engine sso
..
Patch Set 31: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix DAO tests error
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_created/7741/ :
SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: add support for basic athentication
..
Patch Set 9: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_cre
oVirt Jenkins CI Server has posted comments on this change.
Change subject: backend: Add HostDev passthrough support #2
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26745/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Add VM HostDevice subtab
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26746/ :
FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Add VM HostDevice subtab
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26748/ :
SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: backend: Add HostDev passthrough support #2
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26747/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Add Host Device Passthrough support
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/267
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add GetManagementNetwork query
..
Patch Set 26:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26743/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add GetDefaultManagementNetwork query
..
Patch Set 26:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Fix typo
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26741/ :
SUCCESS
http://jenkin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Fix typo
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26740/ :
SUCCESS
http://jenkin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Add managemenet network field to new/edit cluster
dialog
..
Patch Set 30:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_maste
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: update Linq.NetworkComparator
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26737/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: add support for basic athentication
..
Patch Set 8: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_cre
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: update "Edit network" flow with new mangement network
logic
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Improve performance of mapping tests
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/267
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Add managemenet network field to new/edit cluster
dialog
..
Patch Set 29:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_maste
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: remove ConfigurationValues.DefaultManagementNetwork
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: update how mgmt network being selected for a new Vnic
profile
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add GetManagementNetwork query
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26731/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Remove add vm storage domain and disks options
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Update HostSetupNetworks flow to use isManagement
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Remove network button is enabled in DC netwoks
sub-tab.
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add GetDefaultManagementNetwork query
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: update Linq.NetworkComparator
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26723/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: unused management ENGINE_NETWORK_NAME was removed
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: management notion is removed from Network-general
sub-tab
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_mast
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: update "Edit network" flow with new mangement network
logic
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine:Numa nodes statistic clear dynamic data info
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Fix permission addition
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26716/ :
SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Fix permission addition
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26717/ :
SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine:Numa nodes statistic clear dynamic data info
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: add IsManagementNetworkQuery
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26712/ :
S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Use java naming convention for method argument
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Do not allow NFS when creating POSIX SD
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26713
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Added init method to command base.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26715/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: remove management network indication from the network
main tab
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Remove add vm storage domain and disks options
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Don't format XML or JSON output
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26710/ :
S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: minor Java 7 related changes
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26709/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] events: VM.getStats implementation
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/6064/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: add management role indication to the network-cluster
sub-tab
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: remove management member from ClusterNetworkModel
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: add management column retrieval to
NetworkDao.getAllForCluster
..
Patch Set 20:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_maste
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Add management role in cluster networks sub-tab
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tes
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add error message for wrong host provider type
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Validate host provider on host update command
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Move getDefaultManagementNetworkName to
ManagementNetworkUtils
..
Patch Set 39:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_m
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: ConfigValues.DefaultManagementNetwork cleanup
..
Patch Set 37:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: ClusterNetworkManageModel - add management column
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: replace NetworkUtils.getDefaultManagementNetwork calls
..
Patch Set 54:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_uni
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: remove NetworkUtils.isManagementNetwork methods
..
Patch Set 52:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: make SetupNetworksVDSCommand use ManagementNetworkUtil
..
Patch Set 51:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_uni
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: change HostNetworkTopologyPersister to use
ManagementNetworkUtil
..
Patch Set 51:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: move Injector to vdsbroker
..
Patch Set 49:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26695/ :
SUC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Move ManagementNetworkUtil to vdsbroker module
..
Patch Set 54:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: update NetworkValidator logic
..
Patch Set 53:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26693/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Update UpdateStoragePoolCommand logic
..
Patch Set 52:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Associate host with its provider
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26691/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Update AddBondCommand logic
..
Patch Set 51:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26690/ :
SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: update RemoveNetworkParametersBuilder logic
..
Patch Set 51:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Update SetupNetworks backend logic
..
Patch Set 51:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26688
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add isManagementNetwork(String, Guid) to
ManagementNetworkUtil
..
Patch Set 52:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_m
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Add management value to NetworkUsage enum
..
Patch Set 52:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: enable sharing a trx over multiple NetworkCluster
commands
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_maste
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: update UpdateVdsGroupCommand
..
Patch Set 52:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26686/ :
S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine:Add GetNetworkByNameAndDataCenter query
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: update REST API to pass managementNetworkId on cluster
creation
..
Patch Set 34:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add error message for wrong host provider type
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine, webadmin: refactor manage networks flow
..
Patch Set 49:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/2668
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Validate host provider on host update command
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Verify host provider exists when it is set
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Associate host with its provider
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26677/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Fix broken test
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26675/ :
SUCCESS
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: update commands that might change management network
..
Patch Set 35:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-test
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Verify host provider exists when it is set
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Associate host with its provider
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add error message for wrong host provider type
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Validate host provider on host update command
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Verify host provider exists when it is set
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/26
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Validate host provider on host update command
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add error message for wrong host provider type
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Associate host with its provider
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add AddClusterOperationParameters class
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/2666
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add getManagementNetworks to NetworkDao
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerr
1 - 100 of 1083 matches
Mail list logo