Martin Mucha has posted comments on this change. Change subject: core: Use postConstruct in AddVmCommand ......................................................................
Patch Set 3: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/37601/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java: Line 208: ArrayList<String> reasons = new ArrayList<String>(); Line 209: final int domainSizeGB = 20; Line 210: final int sizeRequired = 5; Line 211: AddVmCommand<AddVmParameters> cmd = setupCanAddVmTests(domainSizeGB, sizeRequired); Line 212: cmd.postConstruct(); > +1 I'm not against it, but using CDI in tests makes them significantly slower, due to container initialization. It's ok to use it, if appropriate, but if we use it generally our tests will run (quite) longer. Line 213: doReturn(true).when(cmd).validateCustomProperties(any(VmStatic.class), any(ArrayList.class)); Line 214: doReturn(true).when(cmd).validateSpaceRequirements(); Line 215: assertTrue("vm could not be added", cmd.canAddVm(reasons, Arrays.asList(createStorageDomain(domainSizeGB)))); Line 216: } -- To view, visit http://gerrit.ovirt.org/37601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2ba2b140d4b40fa84beeb0d9c2894f8cc2098ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
