Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Add host rename script
..
Patch Set 22: Verified+1
--
To view, visit http://gerrit.ovirt.org/17408
To unsubscribe, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Remove FormatException
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4729/
: SUC
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: Add host rename script
..
Patch Set 21:
Nothing to add to Alon's comments about the code. Didi, ensure that the post
install file created b
Ofer Schreiber has posted comments on this change.
Change subject: core: Fixes device type for spicevmc and smartcard devices
..
Patch Set 2:
please add it there, and to the 3.3 release tracker.
--
To view, visit http://gerri
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Add host rename script
..
Patch Set 21:
(9 comments)
File packaging/setup/plugins/ov
Allon Mureinik has posted comments on this change.
Change subject: restapi: allow storage conn deletion with no host
..
Patch Set 1: Code-Review+1
@Alissa - let's discuss Michael's comments before merging?
--
To view, visit h
Allon Mureinik has posted comments on this change.
Change subject: restapi: add connections subresource for domain
..
Patch Set 7:
(1 comment)
Minor comment on the javadoc.
@Alissa - please note the two comments by Michael.
.
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove FormatException
..
core: Remove FormatException
FormatException was introduced in the very first git commit of oVirt,
and has not been use
Allon Mureinik has posted comments on this change.
Change subject: core: Remove FormatException
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/16812
To unsubscribe, visit http://gerrit.ovirt
Ofer Schreiber has posted comments on this change.
Change subject: core: Set artifact version to 3.4.0-SNAPSHOT
..
Patch Set 1:
Allon - I'll approve that patch personally, please do.
--
To view, visit http://gerrit.ovirt.org/
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: apache: remove ovirt-engine-style.css reference
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17638
To unsubscribe, visi
Noam Slomianko has abandoned this change.
Change subject: engine: Integrate External Scheduler in to normal workflow
..
Abandoned
Sqaushed up
--
To view, visit http://gerrit.ovirt.org/17654
To unsubscribe, visit http://gerrit
Sandro Bonazzola has posted comments on this change.
Change subject: ovirt-live: migrate ovirt live plugin to otopi
..
Patch Set 9: Code-Review-1
(3 comments)
File
fedora/o
Noam Slomianko has abandoned this change.
Change subject: engine: ExternalScheduler change discover and balance
..
Abandoned
Squashed up
--
To view, visit http://gerrit.ovirt.org/17623
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: call connectStorageServer when add a domain
..
Patch Set 1: Code-Review+1
(1 comment)
File
backend/
Arik Hadas has posted comments on this change.
Change subject: core: minor refactorings in StopVmCommandBase
..
Patch Set 5:
omer, the problem you mention already exists today. in general, the flow where
you stop a VM that is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Remove FormatException
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4728/
: SUC
Allon Mureinik has posted comments on this change.
Change subject: engine: Fix updating of "shareable" property for direct LUNs
..
Patch Set 1: Code-Review+1
what about a unit test?
--
To view, visit http://gerrit.ovirt.org/1
Allon Mureinik has posted comments on this change.
Change subject: core: Remove FormatException
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/16812
To unsubscribe, visit http://gerrit.ovirt
Liran Zelkha has posted comments on this change.
Change subject: tools: Add script to dump heap
..
Patch Set 8: Verified-1 Code-Review+1
Hi
This script can not be submitted for now. Seems like jmap does not work with
current
Sahina Bose has posted comments on this change.
Change subject: packaging: setup: Do not enable Gluster in Default cluster
..
Patch Set 5:
Alon, the config 'ApplicationMode' in database is getting updated to virtonly
for appli
Allon Mureinik has posted comments on this change.
Change subject: core: Set artifact version to 3.4.0-SNAPSHOT
..
Patch Set 1: Code-Review+1
+1.
Isn't it time we extracted the version to a variable in the root pom.xml?
--
T
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Change in Network QoS UI
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4727/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: handle 'image does not exists' error on remove
hibernation vols
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_san
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Change in Network QoS UI
..
webadmin: Change in Network QoS UI
Change in the network QoS UI. Setting default values to all fields
Change-Id:
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Change in Network QoS UI
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17555
To unsubscribe, visit http://gerrit.ovirt.org/s
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: introduce command that removes hibernation volumes
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Do not enable Gluster in Default cluster
..
Patch Set 5:
> Alon, we do need ApplicationMode both to be supported.
Hi,
Doesn't this what that p
ofri masad has posted comments on this change.
Change subject: webadmin: Change in Network QoS UI
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/17555
To unsubscribe, visit http://gerrit.ovirt.org/setting
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: disable yum packager during remove
..
Patch Set 1:
(1 comment)
File packaging/setup/bi
Sahina Bose has posted comments on this change.
Change subject: packaging: setup: Do not enable Gluster in Default cluster
..
Patch Set 5:
Alon, we do need ApplicationMode both to be supported. What we need to change
is the De
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: minor refactorings in StopVmCommandBase
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fix wrong audit log on stop vm with hibernation vols
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_
Aravinda VK has posted comments on this change.
Change subject: packaging: setup: Do not enable Gluster in Default cluster
..
Patch Set 5:
(1 comment)
File packaging/setup/p
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Change in Network QoS UI
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4722/
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: Do not enable Gluster in Default cluster
..
Patch Set 5:
(1 comment)
File packaging/se
Roy Golan has posted comments on this change.
Change subject: core: Introduce CDI for Commands dependencies
..
Patch Set 8:
(3 comments)
File backend/manager/modules/bll/pom
Arik Hadas has uploaded a new change for review.
Change subject: core: introduce command that removes hibernation volumes
..
core: introduce command that removes hibernation volumes
Add RemoveVmHibernationVolumesCommand which re
Arik Hadas has uploaded a new change for review.
Change subject: core: fix wrong audit log on stop vm with hibernation vols
..
core: fix wrong audit log on stop vm with hibernation vols
While stopping VM which is not suspended b
ofri masad has posted comments on this change.
Change subject: webadmin: UI for cpu shares
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/17668
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Do not enable Gluster in Default cluster
..
Patch Set 4:
> Sandro: Done. Maybe do the same for other usages of engine constants?
it would be more
Alon Bar-Lev has posted comments on this change.
Change subject: engine_page: rewrite register
..
Patch Set 2:
(3 comments)
File src/misc.py
Line 40: prefix = ''
Lin
Alon Bar-Lev has posted comments on this change.
Change subject: engine_page: rewrite register
..
Patch Set 1:
(1 comment)
File src/network.py
it is not required.
Line 1: #!
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Fix updating of "shareable" property for direct LUNs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compil
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Do not enable Gluster in Default cluster
..
Patch Set 4:
Aravinda: Can you please verify, I only modified code.
Sandro: Done. Maybe do the same for ot
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: UI for cpu shares
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4720/
: SUCC
Sergey Gotliv has posted comments on this change.
Change subject: engine: Fix updating of "shareable" property for direct LUNs
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/17691
To unsubscribe, visit ht
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Fix updating of "shareable" property for direct LUNs
..
engine: Fix updating of "shareable" property for direct LUNs
Currently the update of "shareable"
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Do not enable Gluster in Default cluster
..
Patch Set 3:
I'm not sure to have understood correctly what application mode both is
supposed to be bu
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Do not enable Gluster in Default cluster
..
Patch Set 3:
(1 comment)
File packaging/setup/plugins
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Do not enable Gluster in Default cluster
..
Patch Set 3:
(1 comment)
File packaging/setup/plu
Aravinda VK has posted comments on this change.
Change subject: packaging: Do not enable Gluster in Default cluster
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17552
To unsubscribe, visit http://ger
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine_page: rewrite register
..
Patch Set 2:
guys still have work to do in the draft, comments are welcome.
--
To view, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine_page: rewrite register
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-node-plugin-vdsm/53/ : SUCCESS
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Modify Vm Interface commands to work with VmNic
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Create a vnic profile implicitly when adding network
..
Patch Set 31:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compi
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine_page: rewrite register
..
Patch Set 1:
(14 comments)
File src/engine_page.py
Line 340:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Add support for vnic profiles
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/47
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Require VnicProfile permission for vnic template
..
Patch Set 19:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Expose new parameters for template vnic actions
..
Patch Set 19:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Prevent modifying port mirroring if used by vms
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Change uniqueInterfaceName to work with VmNic
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Change pciAndIdeWithinLimit to accept VmNics
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_check
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Replace use of VmNetworkInterfaceDao with VmNicDao
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: revert 925aeee7 Add vnic custom properties
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Modify custom properties type to map
..
Patch Set 30:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Replace use of VmNetworkInterface with VmNic
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_check
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Introduce GetVnicProfileByIdQuery
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: minor cleanup for ImportVmTemplateCommand
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Remove custom properties from vnic level
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyl
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add method for checking existence of network in cluster
..
Patch Set 18:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_co
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add more validations for vnic profiles
..
Patch Set 19:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine,webadmin: Remove network name from NetworkInterface
..
Patch Set 25:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: sort vnic profiles tabs
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4686/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Introduce GetNetworkByIdQuery
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/470
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add audit log messages for vnic profile commands
..
Patch Set 30:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Introduce VnicProfileValidator
..
Patch Set 28:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Import VM configure the vnic profile
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Update the vnic profile resolution of ImportVmTempalte
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Extract vnic profile resolution to VmInterfaceManager
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_comp
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add vnic profile name to VmNetworkInterface
..
Patch Set 18:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Remove unused method isValidVmNetwork
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g
Michael Pasternak has posted comments on this change.
Change subject: codegen: allow xml types as container key
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17689
To unsubscribe, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: fixing permission issue for vnic profiles
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: allow xml types as container key
..
codegen: allow xml types as container key
Change-Id: Id20db54da97ae101b19f0181c23f8450a341a175
Signed-o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Refactor resolution of vnic profile for a vnic
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: compile generated sources
..
codegen: compile generated sources
compile generated sources so the changes will be visible
to the consuming c
Michael Pasternak has posted comments on this change.
Change subject: codegen: compile generated sources
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17688
To unsubscribe, visit http://ger
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: compile generated sources
..
codegen: compile generated sources
compile generated sources so the changes will be visible
to the consuming code that
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine Use VmNic within ChangeVMClusterCommand
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: allow xml types as container key
..
codegen: allow xml types as container key
Change-Id: Id20db54da97ae101b19f0181c23f8450a341a175
Signed-off-by: M
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Modify VM commands to work with VmNic
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: fix the TODOs
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4694/
: SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: adding description to vnic profile dialogs and tables
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: adding network, dc and compatability version columns
to profiles
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Read vnic profile name from the OVF
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add vnic profiles to DB and entities
..
Patch Set 51:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add rename logging capability to UpdateVnic
..
Patch Set 30:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add AddVnicProfileCommand
..
Patch Set 36:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4668/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add GetVmsByVnicProfileIdQuery
..
Patch Set 30:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/4
1 - 100 of 451 matches
Mail list logo