Sandro Bonazzola has posted comments on this change.

Change subject: packaging: Do not enable Gluster in Default cluster
......................................................................


Patch Set 4:

> Sandro: Done. Maybe do the same for other usages of engine constants?

it would be more consistent.But I think we can align the code when we'll touch 
it again in the future. The important thing from my point of view is having a 
reference to the engine code for finding the original definition when we need 
to check / update those values.

-- 
To view, visit http://gerrit.ovirt.org/17552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b4d15689c730428aad09dd0c981faf5732731d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to