[Engine-patches] Change in otopi[master]: packagers: yum: do not use yum state strings

2013-07-25 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packagers: yum: do not use yum state strings .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17326 To unsubscribe,

[Engine-patches] Change in otopi[master]: packagers: yum: do not use yum state strings

2013-07-25 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: do not use yum state strings .. packagers: yum: do not use yum state strings the yum.i18n produces non standard string encoding, encoded

[Engine-patches] Change in otopi[master]: packagers: yum: do not use yum state strings

2013-07-25 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packagers: yum: do not use yum state strings .. packagers: yum: do not use yum state strings the yum.i18n produces non standard string encoding, encoded using an

[Engine-patches] Change in ovirt-engine[master]: fix tiny typo

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix tiny typo .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2972/ : SUCCESS -- To vi

[Engine-patches] Change in ovirt-engine[master]: fix tiny typo

2013-07-25 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: fix tiny typo .. fix tiny typo Change-Id: Ib1a6698279a6fe799be3ffee1f0c59fc1add9646 Bug-Url: https://bugzilla.redhat.com/988017 Signed-off-by: Dan Kenigsberg

[Engine-patches] Change in ovirt-hosted-engine-ha[master]: ovirt-hosted-engine-ha: initial commit

2013-07-25 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: ovirt-hosted-engine-ha: initial commit .. Patch Set 8: (3 inline comments) Left out a few replies earlier...

[Engine-patches] Change in ovirt-hosted-engine-ha[master]: ovirt-hosted-engine-ha: initial commit

2013-07-25 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: ovirt-hosted-engine-ha: initial commit .. Patch Set 8: (26 inline comments) I'm submitting 2 follow-up patch sets which I hope makes reviewing the changes easier

[Engine-patches] Change in ovirt-engine[master]: restapi : error translation is broken (#987848)

2013-07-25 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : error translation is broken (#987848) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17323 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: restapi : error translation is broken (#987848)

2013-07-25 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: restapi : error translation is broken (#987848) .. restapi : error translation is broken (#987848) backend error translation is broken Actual results: [var actio

[Engine-patches] Change in ovirt-engine[master]: restapi: add connections subresource for domain

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: add connections subresource for domain .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in mom[master]: Fix a typo in a variable name unuused -> unused

2013-07-25 Thread agl
Adam Litke has submitted this change and it was merged. Change subject: Fix a typo in a variable name unuused -> unused .. Fix a typo in a variable name unuused -> unused Change-Id: I09cd74173642bcaeb94fb3528485f912e6f56434 Sig

[Engine-patches] Change in mom[master]: Fix a typo in a variable name unuused -> unused

2013-07-25 Thread agl
Adam Litke has posted comments on this change. Change subject: Fix a typo in a variable name unuused -> unused .. Patch Set 4: Verified; Looks good to me, approved Since the documentation uses the correct spelling and our examp

[Engine-patches] Change in mom[master]: Fix a typo in a variable name unuused -> unused

2013-07-25 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: Fix a typo in a variable name unuused -> unused .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17217

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent modifying port mirroring if used by vms

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Prevent modifying port mirroring if used by vms .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: engine: use internal query for watchdog

2013-07-25 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: engine: use internal query for watchdog .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17089 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: Change uniqueInterfaceName to work with VmNic

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Change uniqueInterfaceName to work with VmNic .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_check

[Engine-patches] Change in ovirt-engine[master]: engine: Add AddVnicProfileCommand

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add AddVnicProfileCommand .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2961/

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: Remove network name from NetworkInterface

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine,webadmin: Remove network name from NetworkInterface .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVnicProfilesByDataCenterIdQuery

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVnicProfilesByDataCenterIdQuery .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: engine: Add audit log messages for vnic profile commands

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add audit log messages for vnic profile commands .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_c

[Engine-patches] Change in ovirt-engine[master]: engine: Modify Vm Interface commands to work with VmNic

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify Vm Interface commands to work with VmNic .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VmNicDao

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VmNicDao .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2954/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: webadmin: network profiles

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: network profiles .. Patch Set 14: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2969/ : FA

[Engine-patches] Change in ovirt-engine[master]: engine: Replace use of VmNetworkInterfaceDao with VmNicDao

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Replace use of VmNetworkInterfaceDao with VmNicDao .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VnicProfileValidator

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VnicProfileValidator .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2

[Engine-patches] Change in ovirt-engine[master]: engine: Create a vnic profile implicitly when adding network

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Create a vnic profile implicitly when adding network .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compi

[Engine-patches] Change in ovirt-engine[master]: engine: Add rename logging capability to UpdateVnic

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add rename logging capability to UpdateVnic .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: webadmin: (wip) add profiles instead of networks to vnic and...

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: (wip) add profiles instead of networks to vnic and vm dialogs .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_s

[Engine-patches] Change in ovirt-engine[master]: engine: Modify custom properties type to map

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify custom properties type to map .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Remove vnic profiles of a removed a data-center

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Remove vnic profiles of a removed a data-center .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: engine: Add query to retrieve all vnic profiles

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add query to retrieve all vnic profiles .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle

[Engine-patches] Change in ovirt-engine[master]: core: Add vnic profiles to DB and entities

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add vnic profiles to DB and entities .. Patch Set 36: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Add update vnic profile command

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add update vnic profile command .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: core: cleanup related to memory state removal

2013-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: cleanup related to memory state removal .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17307 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: engine: Change pciAndIdeWithinLimit to accept VmNics

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Change pciAndIdeWithinLimit to accept VmNics .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: engine: Add remove vnic profile command

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add remove vnic profile command .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: engine: Replace use of VmNetworkInterface with VmNic

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Replace use of VmNetworkInterface with VmNic .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor VnicProfile row mapper

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Refactor VnicProfile row mapper .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VnicProfileCommon class

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VnicProfileCommon class .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerri

[Engine-patches] Change in ovirt-engine[master]: engine: cleanup static access

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: cleanup static access .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2935/ : S

[Engine-patches] Change in ovirt-engine[master]: engine: Delete vnic profiles when removing a network

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Delete vnic profiles when removing a network .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_check

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VnicProfileView and its DAO

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VnicProfileView and its DAO .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine: Utilize VmNicRowMapper base for VmNetworkInterfaceDa...

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Utilize VmNicRowMapper base for VmNetworkInterfaceDao .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compi

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetTemplatesByVnicProfileIdQuery

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetTemplatesByVnicProfileIdQuery .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Modify VM commands to work with VmNic

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify VM commands to work with VmNic .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent adding vnic profiles to non vm network

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Prevent adding vnic profiles to non vm network .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVnicProfilesByNetworkIdQuery

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVnicProfilesByNetworkIdQuery .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: engine: Remove publicUse from AddNetwork command

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Remove publicUse from AddNetwork command .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyl

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VmNic, a base class for VmNetworkInterface

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VmNic, a base class for VmNetworkInterface .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compil

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVmsByVnicProfileIdQuery

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVmsByVnicProfileIdQuery .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2

[Engine-patches] Change in ovirt-engine[master]: webadmin: removing port mirroring and custom props from vnic...

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: removing port mirroring and custom props from vnic dialog .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanit

[Engine-patches] Change in ovirt-engine[master]: engine: Extract removeVnicProfiles() to NetworkCommon

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Extract removeVnicProfiles() to NetworkCommon .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec

[Engine-patches] Change in ovirt-engine[master]: engine: Add SP for retrieving vms by vnic profile

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add SP for retrieving vms by vnic profile .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: engine: Use VmNic within UpdateVmCommand

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Use VmNic within UpdateVmCommand .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: engine: Add SP for retrieving templates by vnic profile

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add SP for retrieving templates by vnic profile .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: core: Add parameter class for vnic profile commands

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add parameter class for vnic profile commands .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: engine: Remove vnic profiles for non-vm network

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Remove vnic profiles for non-vm network .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle

[Engine-patches] Change in ovirt-engine[master]: engine: Use VmNic within VmPoolHandler

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Use VmNic within VmPoolHandler .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/29

[Engine-patches] Change in ovirt-engine[master]: engine Use VmNic within ChangeVMClusterCommand

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine Use VmNic within ChangeVMClusterCommand .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: core: adding vnic_profile_id to vm_interface

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: adding vnic_profile_id to vm_interface .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: add VnicProfile as main tab

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add VnicProfile as main tab .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/29

[Engine-patches] Change in ovirt-engine[master]: core: fix memory state removal on import vm rollback

2013-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix memory state removal on import vm rollback .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17057 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: minor cleanups in MemoryImageRemover class

2013-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: minor cleanups in MemoryImageRemover class .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16828 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: ignore image does not exists error on remove memory st...

2013-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: ignore image does not exists error on remove memory state .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17056 To uns

[Engine-patches] Change in ovirt-engine[master]: core: simplified memory states removal code

2013-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: simplified memory states removal code .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16827 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: core: fix the hierarchy of memory images removers

2013-07-25 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: fix the hierarchy of memory images removers .. core: fix the hierarchy of memory images removers The "RAM Snapshots" feature introduced the MemoryI

[Engine-patches] Change in ovirt-engine[master]: core: fix the hierarchy of memory images removers

2013-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix the hierarchy of memory images removers .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16826 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: fix the hierarchy of memory images removers

2013-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix the hierarchy of memory images removers .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/16826 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread agl
Adam Litke has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17207 To unsubsc

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread agl
Adam Litke has submitted this change and it was merged. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Make sure the balloon info uses numbers when provided by VDSM VDSM needs to strings for tr

[Engine-patches] Change in ovirt-engine[master]: core: fix the hierarchy of memory images removers

2013-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix the hierarchy of memory images removers .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16826 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: webadmin: add profiles instead of networks to vnic and vm di...

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add profiles instead of networks to vnic and vm dialogs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: do not re-start network service

2013-07-25 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: packages: do not re-start network service .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17321 To unsubscribe, visit

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: do not re-start network service

2013-07-25 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packages: do not re-start network service .. vdsm: packages: do not re-start network service rhel does not like re-start (second start) of network

[Engine-patches] Change in ovirt-engine[master]: webadmin: add profiles to vnic dialog and vm-vnic instance t...

2013-07-25 Thread alkaplan
Alona Kaplan has abandoned this change. Change subject: webadmin: add profiles to vnic dialog and vm-vnic instance type .. Patch Set 4: Abandoned Was substituted by http://gerrit.ovirt.org/#/c/17322/ -- To view, visit http://

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: do not re-start network service

2013-07-25 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: packages: do not re-start network service .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: do not re-start network service

2013-07-25 Thread dcaroest
David Caro has posted comments on this change. Change subject: vdsm: packages: do not re-start network service .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: do not re-start network service

2013-07-25 Thread dcaroest
David Caro has posted comments on this change. Change subject: vdsm: packages: do not re-start network service .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: do not re-start network service

2013-07-25 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: packages: do not re-start network service .. Patch Set 1: Looks good to me, but someone else must approve Yes. That should do it ;-) -- To view,

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: do not re-start network service

2013-07-25 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: vdsm: packages: do not re-start network service .. vdsm: packages: do not re-start network service rhel does not like re-start (second start) of network service.

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/17207 To unsubscribe, visit http

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Patch Set 3: (1 inline comment) File mom/Col

[Engine-patches] Change in ovirt-engine[master]: core, restapi: Introducing ImportVmFromConfigurationCommand

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, restapi: Introducing ImportVmFromConfigurationCommand .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile

[Engine-patches] Change in ovirt-engine[master]: core, restapi: Introducing ImportVmFromConfigurationCommand

2013-07-25 Thread laravot
Liron Ar has posted comments on this change. Change subject: core, restapi: Introducing ImportVmFromConfigurationCommand .. Patch Set 8: (8 inline comments) File backend/man

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread agl
Adam Litke has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) ...

[Engine-patches] Change in ovirt-engine-cli[master]: cli: status command description need to rephrase

2013-07-25 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: cli: status command description need to rephrase .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16781

[Engine-patches] Change in ovirt-dwh[master]: packaging: service: run dwh service as an ovirt user

2013-07-25 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: service: run dwh service as an ovirt user .. Patch Set 1: I would prefer that you didn't submit this Doesn't work. Needs more attention. -- To view, v

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: bin: added --console command

2013-07-25 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: bin: added --console command .. Patch Set 8: Verified; Looks good to me, approved /bin/remote-viewer works only on Fedora. use /usr/bin instead. -- To view,

[Engine-patches] Change in ovirt-engine[master]: engine: Don't log redundant exception

2013-07-25 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Don't log redundant exception .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17319 To unsubscribe, visit http://gerr

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Patch Set 2: (1 inline comment) File mom/Mon

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/17207 To unsubscribe, visit http

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread agl
Adam Litke has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Patch Set 2: (1 inline comment) File mom/Monit

[Engine-patches] Change in ovirt-engine[master]: userportal : Fix DiskForVmGuid high CPU

2013-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: userportal : Fix DiskForVmGuid high CPU .. Patch Set 5: I would prefer that you didn't submit this (4 inline comments)

[Engine-patches] Change in ovirt-engine[master]: restapi: add storage domain with existing conn id

2013-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: restapi: add storage domain with existing conn id .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/171

[Engine-patches] Change in ovirt-engine[master]: engine: use internal query for watchdog

2013-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: use internal query for watchdog .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17089 To unsu

[Engine-patches] Change in ovirt-engine[master]: restapi: add storage server connections resource

2013-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: restapi: add storage server connections resource .. Patch Set 25: (7 inline comments) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: restapi: add storage server connections resource

2013-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: restapi: add storage server connections resource .. Patch Set 23: (2 inline comments) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: engine: Change queries error logging to use @Logged

2013-07-25 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Change queries error logging to use @Logged .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst

[Engine-patches] Change in ovirt-engine[master]: engine: Change queries error logging to use @Logged

2013-07-25 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: engine: Change queries error logging to use @Logged .. engine: Change queries error logging to use @Logged Currently all VDS commands use the @Logged annotation

[Engine-patches] Change in mom[master]: Make sure the balloon info uses numbers when provided by VDS...

2013-07-25 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Make sure the balloon info uses numbers when provided by VDSM .. Patch Set 2: (1 inline comment) File mom/Mon

  1   2   3   4   >