Allon Mureinik has posted comments on this change.
Change subject: restapi: add storage server connections resource
......................................................................
Patch Set 23: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java
Line 68: validateParameters(storage, "path");
Line 69: break;
Line 70: case POSIXFS:
Line 71: case GLUSTERFS:
Line 72: validateParameters(storage, "path", "vfsType");
Seems wrong on both accounts, but I agree it's important to follow suite.
Line 73: break;
Line 74: default:
Line 75: break;
Line 76: }
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
Line 12: import org.ovirt.engine.api.restapi.model.StorageFormat;
Line 13: import org.ovirt.engine.api.restapi.utils.GuidUtils;
Line 14: import
org.ovirt.engine.core.common.businessentities.StorageDomainStatic;
Line 15: import
org.ovirt.engine.core.common.businessentities.StorageServerConnections;
Line 16:
Just take the patch before this one, apply the formatter and submit it as a
patch.
It's 3 minutes of work.
Line 17: public class StorageDomainMapper {
Line 18:
Line 19: @Mapping(from = StorageDomain.class, to =
StorageDomainStatic.class)
Line 20: public static StorageDomainStatic map(StorageDomain model,
StorageDomainStatic template) {
--
To view, visit http://gerrit.ovirt.org/16617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6bc32ead098390723825872f6fb292097d52835
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
