[Engine-patches] Change in ovirt-engine[master]: engine: add comment field to Cluster [2]

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: add comment field to Cluster [2] .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1884/ : FAILUR

[Engine-patches] Change in ovirt-engine[master]: engine: add comment field to Storage [5]

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: add comment field to Storage [5] .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1887/ : FAILUR

[Engine-patches] Change in ovirt-engine[master]: engine: add comment field to Network [4]

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: add comment field to Network [4] .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1886/ : FAILUR

[Engine-patches] Change in ovirt-engine[master]: gluster: Shown command and server name in evt log

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Shown command and server name in evt log .. Patch Set 2: No score Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri

[Engine-patches] Change in ovirt-engine[master]: engine: add comment field to Host [3]

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: add comment field to Host [3] .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1885/ : FAILURE

[Engine-patches] Change in ovirt-dwh[master]: [WIP] packaging: Added postgres listening external network

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: [WIP] packaging: Added postgres listening external network .. Patch Set 1: (2 inline comments) File packa

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected event log msg for add brick

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Corrected event log msg for add brick .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1881/ :

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected event log msg for add brick

2013-06-20 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Corrected event log msg for add brick .. Patch Set 1: No score (1 inline comment) File backe

[Engine-patches] Change in ovirt-engine[master]: core: RemoveDiskParameters - don't use Entity ID

2013-06-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: RemoveDiskParameters - don't use Entity ID .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1595

[Engine-patches] Change in ovirt-engine[master]: gluster: Shown command and server name in evt log

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Shown command and server name in evt log .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1879/ : FAI

[Engine-patches] Change in ovirt-engine[master]: restapi:Remove rebalance and replace brick from API

2013-06-20 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: restapi:Remove rebalance and replace brick from API .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: gluster:Support Striped_replicate volume types

2013-06-20 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster:Support Striped_replicate volume types .. Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) Minor comment ..

[Engine-patches] Change in ovirt-engine[master]: [WIP] engine:Trusted Compute Pools - Open Attestation integr...

2013-06-20 Thread lijuan . zhang
Emily Zhang has posted comments on this change. Change subject: [WIP] engine:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal .. Patch Set 16: Looks good to me, but someone else must approve (1 i

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 70 - Still Failing!

2013-06-20 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/70/ Build Number: 70 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 69 - Failure!

2013-06-20 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/69/ Build Number: 69 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: utils: introduce EngineSSHClient wrapper

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: introduce EngineSSHClient wrapper .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1878/ : FAILUR

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1041 - Still Failing!

2013-06-20 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1041/ Build Number: 1041 Build Status: Still Failing Triggered By: Started by timer, Started by timer - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: [WIP] packaging: added DB validation functions on upgrade

2013-06-20 Thread alourie
Alex Lourie has posted comments on this change. Change subject: [WIP] packaging: added DB validation functions on upgrade .. Patch Set 1: This code is not yet verified. -- To view, visit http://gerrit.ovirt.org/15970 To unsub

[Engine-patches] Change in ovirt-engine[master]: [WIP] packaging: added DB validation functions on upgrade

2013-06-20 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: [WIP] packaging: added DB validation functions on upgrade .. [WIP] packaging: added DB validation functions on upgrade Change-Id: I25979acbf54d980168be929638ff4ae

[Engine-patches] Change in ovirt-engine[master]: utils: introduce EngineSSHClient wrapper

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce EngineSSHClient wrapper .. Patch Set 1: Yaniv, This will make all the engine to use the EngineSSHClient, including the dialogs. So you can over

[Engine-patches] Change in ovirt-engine[master]: utils: introduce EngineSSHClient wrapper

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: utils: introduce EngineSSHClient wrapper .. utils: introduce EngineSSHClient wrapper EngineSSHClient enables the use of SSHClient it defaults of engine, it will

[Engine-patches] Change in ovirt-engine[master]: core: add the openstack dependency

2013-06-20 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: core: add the openstack dependency .. Patch Set 17: Verified -- To view, visit http://gerrit.ovirt.org/13434 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: [wip] backend: add glance storage domain support

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] backend: add glance storage domain support .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1877/ :

[Engine-patches] Change in ovirt-engine[master]: core: add the openstack dependency

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add the openstack dependency .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1876/ : SUCCESS --

[Engine-patches] Change in ovirt-engine[master]: webadmin: use RepoImage items in SubTabStorageIso

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: use RepoImage items in SubTabStorageIso .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1875/

[Engine-patches] Change in ovirt-engine[master]: providers: add the onAddition and onRemoval hooks

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: providers: add the onAddition and onRemoval hooks .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1874/ :

[Engine-patches] Change in ovirt-engine[master]: [wip] providers: add the openstack image support

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] providers: add the openstack image support .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1873/ :

[Engine-patches] Change in ovirt-engine[master]: [wip] frontend: add glance storage domain support

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] frontend: add glance storage domain support .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1872/

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: logical network editor

2013-06-20 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin, userportal: logical network editor .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15102 To un

[Engine-patches] Change in ovirt-engine[master]: core: adding OvfHelper

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: adding OvfHelper .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1871/ : SUCCESS -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: organize VDSReturnValue class

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: organize VDSReturnValue class .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1870/ : SUCCESS --

[Engine-patches] Change in ovirt-engine[master]: core: organize can-do methods

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: organize can-do methods .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1869/ : SUCCESS -- To vie

[Engine-patches] Change in ovirt-engine[master]: core: remove read lock of template being exported - cont

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: remove read lock of template being exported - cont .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/

[Engine-patches] Change in ovirt-engine[master]: core: organize RemoveDiskCommand#canRemoveTemplateDisk

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: organize RemoveDiskCommand#canRemoveTemplateDisk .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/

[Engine-patches] Change in ovirt-engine[master]: core: add the openstack dependency

2013-06-20 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: core: add the openstack dependency .. Patch Set 17: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13434 To uns

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: redesign of vm related dialogs

2013-06-20 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: redesign of vm related dialogs .. Patch Set 14: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15011 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: cleanup RemoveVmTemplateCommand#canDoAction

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup RemoveVmTemplateCommand#canDoAction .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1865/ :

[Engine-patches] Change in ovirt-engine[master]: core: organize RemoveDiskCommand#getSharedLocks()

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: organize RemoveDiskCommand#getSharedLocks() .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1866/ :

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: redesign of vm related dialogs

2013-06-20 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: redesign of vm related dialogs .. Patch Set 14: Tomas, please fix Checkstyle error in DataCenterWithCluster.java (unused import). -- To v

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: redesign of vm related dialogs

2013-06-20 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: redesign of vm related dialogs .. Patch Set 14: Giving +2 based on code review/discussion with Tomas. -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: type ahead list box

2013-06-20 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: type ahead list box .. Patch Set 10: Looks good to me, approved Giving +2 based on code review/discussion with Tomas. -- To view, visit ht

[Engine-patches] Change in ovirt-dwh[master]: [WIP] packaging: Added postgres listening external network

2013-06-20 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: [WIP] packaging: Added postgres listening external network .. [WIP] packaging: Added postgres listening external network This patch adds the interaction for the u

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: redesign of vm related dialogs

2013-06-20 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: redesign of vm related dialogs .. Patch Set 6: Looks good to me, approved Giving +2 based on code review/discussion with Tomas. Ideally, al

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: add advanced mode support for VM dialog...

2013-06-20 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: add advanced mode support for VM dialogs .. Patch Set 7: Looks good to me, approved Giving +2 based on code review/discussion with Tomas. -

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: type ahead list box

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: type ahead list box .. Patch Set 10: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1863/ : FAILU

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: redesign of vm related dialogs

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: redesign of vm related dialogs .. Patch Set 14: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/18

[Engine-patches] Change in ovirt-engine[master]: packaging: Add backup and restore utility

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: Add backup and restore utility .. Patch Set 11: I would prefer that you didn't submit this (4 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: webadmin: Improve UI Plugin tab API

2013-06-20 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: Improve UI Plugin tab API .. Patch Set 4: Verified Submitted new patch set that fixes a couple of issues: * isEnabled & isAccessible are now called as

[Engine-patches] Change in ovirt-engine[master]: Log setup events

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Log setup events .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15863 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Updated the nfs service name usage

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Updated the nfs service name usage .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: avoid answered questions on update

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: avoid answered questions on update .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/15958 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: add advanced mode support for VM dialog...

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: add advanced mode support for VM dialogs .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_ge

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: adjustments of the VM based dialogs

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: adjustments of the VM based dialogs .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri

[Engine-patches] Change in ovirt-engine[master]: core: remove vmType related logic

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: remove vmType related logic .. Patch Set 14: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1859/ : FAILURE --

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: unify new server/desktop to newVm

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: unify new server/desktop to newVm .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/

[Engine-patches] Change in ovirt-engine[master]: core: RemoveDiskParameters - don't use Entity ID

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: RemoveDiskParameters - don't use Entity ID .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1858/ :

[Engine-patches] Change in ovirt-engine[master]: engine: Tell VDSM the guaranteed amount of memory for VM

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Tell VDSM the guaranteed amount of memory for VM .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Improve UI Plugin tab API

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Improve UI Plugin tab API .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1856/ : SUCCESS --

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Frontend refactor[WIP]

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: Frontend refactor[WIP] .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1855/ : FAI

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix make rpm target

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: fix make rpm target .. Patch Set 2: No problem :-) -- To view, visit http://gerrit.ovirt.org/15963 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix make rpm target

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: build: fix make rpm target .. Patch Set 2: no offense to you... of course, great you noticed... :) -- To view, visit http://gerrit.ovirt.org/15963 To

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix make rpm target

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: build: fix make rpm target .. Patch Set 2: I want to wait a bit with merge... want to see if someone notice... if nobody notice I will remove these ta

[Engine-patches] Change in ovirt-engine[master]: core: Removed AddVmAndCloneImageCommand

2013-06-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Removed AddVmAndCloneImageCommand .. Patch Set 1: Yair/Omer, can we converge on this? -- To view, visit http://gerrit.ovirt.org/14572 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix make rpm target

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: fix make rpm target .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/159

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix make rpm target

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: build: fix make rpm target .. Patch Set 1: (1 inline comment) File Makefile Line 263: rpm: srpm L

[Engine-patches] Change in ovirt-engine[master]: gluster: Correct swift status display for UNKNOWN

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Correct swift status display for UNKNOWN .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1854/ :

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix make rpm target

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: fix make rpm target .. Patch Set 1: (1 inline comment) File Makefile Line 263: rpm: sr

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix make rpm target

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: fix make rpm target .. Patch Set 1: Fails rpmbuild --define="_topdir /root/ovirt-engine/tmp.rpmbuild" "output/ovirt-engine-3.3.0"*.src.rpm

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added the quota to the Pool-general subtab

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added the quota to the Pool-general subtab .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1853

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: provide 10-setup-jboss.conf

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: provide 10-setup-jboss.conf .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15889 To

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Updated the nfs service name usage

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Updated the nfs service name usage .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated the nfs service name usage

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: Updated the nfs service name usage .. Patch Set 4: (1 inline comment) Commit Message Line 3: Autho

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated the nfs service name usage

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: Updated the nfs service name usage .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15954

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: avoid iso domain questions on update

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: avoid iso domain questions on update .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/15958 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: added postinstall file creation

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: added postinstall file creation .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/15957 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix make rpm target

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: build: fix make rpm target .. packaging: build: fix make rpm target was broken by the quote all patch, as srpm had wildcards. remove the variable tha

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: avoid iso domain questions on update

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: avoid iso domain questions on update .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: added postinstall file creation

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added postinstall file creation .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated the nfs service name usage

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: Updated the nfs service name usage .. Patch Set 4: Looks good to me, but someone else must approve Thanks! -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disable select quota on edit vm-pool

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Disable select quota on edit vm-pool .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1852/ : SU

[Engine-patches] Change in ovirt-engine[master]: core: add clusterEmulatedMachines config values

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add clusterEmulatedMachines config values .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1851/ :

[Engine-patches] Change in ovirt-engine[master]: core: Add supportedEmulatedMachines to Host model cluster

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add supportedEmulatedMachines to Host model cluster .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Add new NonOperational reason for cluster emulation mo...

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add new NonOperational reason for cluster emulation mode .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_g

[Engine-patches] Change in ovirt-engine[master]: core: Use the cluster emulated machine to run a VM

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Use the cluster emulated machine to run a VM .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1848/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: avoid iso domain questions on update

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: avoid iso domain questions on update .. Patch Set 1: > what about the all-in-one? most of the all-in-one work is done in closeup, it has it

[Engine-patches] Change in ovirt-engine[master]: core: cluster emulation mode - add procedure to set emulated...

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cluster emulation mode - add procedure to set emulatedMachine .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_

[Engine-patches] Change in ovirt-engine[master]: webadmin: Show the emulated machine of a cluster

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Show the emulated machine of a cluster .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1847/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: avoid iso domain questions on update

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: avoid iso domain questions on update .. Patch Set 1: Looks good to me, but someone else must approve I would have squash these two patches... no

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: avoid iso domain questions on update

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: avoid iso domain questions on update .. Patch Set 1: what about the all-in-one? -- To view, visit http://gerrit.ovirt.org/15958 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core: adding OvfHelper

2013-06-20 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: adding OvfHelper .. Patch Set 5: Verified @Arik -I don't necessarily agree, I think that ovf manager just delegates calls by bll and adds bll logic, therefore

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: added postinstall file creation

2013-06-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added postinstall file creation .. Patch Set 1: (2 inline comments) File packaging/setup/ov

[Engine-patches] Change in ovirt-engine[master]: 16. core : Handle incomplete tasks on server restart

2013-06-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: 16. core : Handle incomplete tasks on server restart .. Patch Set 21: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: expand VDS monitoring with cluster emulation modes

2013-06-20 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: expand VDS monitoring with cluster emulation modes .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: adjustments of the VM based dialogs

2013-06-20 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: adjustments of the VM based dialogs .. Patch Set 4: Looks good to me, approved just copy of the +2 to keep context -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: unify new server/desktop to newVm

2013-06-20 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: unify new server/desktop to newVm .. Patch Set 8: Looks good to me, approved just copy of the +2 to keep context -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: remove read lock of template being exported - cont

2013-06-20 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: remove read lock of template being exported - cont .. core: remove read lock of template being exported - cont This is a complementary patch to http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: organize can-do methods

2013-06-20 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: organize can-do methods .. core: organize can-do methods AddVmCommand#canAddVm: 1. Return false with an error as soon as a problem is detected instead of usi

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: avoid iso domain questions on update

2013-06-20 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: setup: avoid iso domain questions on update .. packaging: setup: avoid iso domain questions on update avoid iso domain questions on update from a

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: added postinstall file creation

2013-06-20 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: setup: added postinstall file creation .. packaging: setup: added postinstall file creation Added a plugin for engine-setup-2 that creates a posti

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: added postinstall file creation

2013-06-20 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: added postinstall file creation .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15957 To unsubscribe, visit http://gerri

  1   2   3   >