Emily Zhang has posted comments on this change.
Change subject: [WIP] engine:Trusted Compute Pools - Open Attestation
integration with oVirt engine proposal
......................................................................
Patch Set 16: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java
Line 71: ExecutionHandler.createInternalJobContext());
Line 72: }
Line 73:
Line 74: private void moveVdsToUp(VDS vds) {
Line 75: trustedVdses.add(vds.getId());
1. maybe we need clear reason like this: vds.setNonOperationalReason(null).
2. Don't we need to check storage, network etc here?
Line 76: vds.setStatus(VDSStatus.Up);
Line 77:
DbFacade.getInstance().getVdsDynamicDao().update(vds.getDynamicData());
Line 78: }
Line 79:
--
To view, visit http://gerrit.ovirt.org/14605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com>
Gerrit-Reviewer: Gang Wei <gang....@intel.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
