[Engine-patches] Change in ovirt-engine[master]: engine: simplify AppConfig

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: simplify AppConfig .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1352/ : SUCCESS -- To view,

[Engine-patches] Change in ovirt-engine[master]: packaging: build: fix install file modes

2013-06-16 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: fix install file modes .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15739 To u

[Engine-patches] Change in ovirt-engine[master]: engine: checkstyle enabled in tools project

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: checkstyle enabled in tools project .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1351/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: enforcing Apache proxy on new install

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: enforcing Apache proxy on new install .. Patch Set 5: In other words... I don't care about ipa here at upstream, if someone else care he should

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: enforcing Apache proxy on new install

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: enforcing Apache proxy on new install .. Patch Set 5: > The patch itself looks good. but: 1. In any case freeipa/ipa-server is > installed, eng

[Engine-patches] Change in ovirt-engine[master]: core: RegisterDiskCommand - fix and refactor CDA

2013-06-16 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: RegisterDiskCommand - fix and refactor CDA .. Patch Set 5: Verified verified - 1. registration works on data domain 2. registration fails with CDA message for e

[Engine-patches] Change in ovirt-engine[master]: core: add validation to AddStorageServerConnection

2013-06-16 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: add validation to AddStorageServerConnection .. Patch Set 3: (3 inline comments) File backend/manage

[Engine-patches] Change in ovirt-engine[master]: core: Use OS repository instead of VmOsType

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Use OS repository instead of VmOsType .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1350/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: core: osinfo - add convenience no-version methods

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: osinfo - add convenience no-version methods .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1349/

[Engine-patches] Change in ovirt-engine[master]: core: Manage OS properties in a repository

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Manage OS properties in a repository .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1348/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: handle a yum error when no groups

2013-06-16 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: handle a yum error when no groups .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1036 - Still Failing!

2013-06-16 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1036/ Build Number: 1036 Build Status: Still Failing Triggered By: Started by timer, Started by timer - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected service sync job event log msg

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Corrected service sync job event log msg .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1347/ :

[Engine-patches] Change in ovirt-engine[master]: gluster: Host detach case sync message corrected

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Host detach case sync message corrected .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1345/ :

[Engine-patches] Change in ovirt-engine[master]: engine:Gluster events added to event_map

2013-06-16 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: engine:Gluster events added to event_map .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15712 To

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected service sync job event log msg

2013-06-16 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Corrected service sync job event log msg .. Patch Set 2: (1 inline comment) File backend/mana

[Engine-patches] Change in ovirt-engine[master]: engine:Gluster events added to event_map

2013-06-16 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: engine:Gluster events added to event_map .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15712 To unsubs

[Engine-patches] Change in ovirt-engine[master]: gluster: Resolve conflict for gluster hook content

2013-06-16 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Resolve conflict for gluster hook content .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: engine: sorting gluster volume options

2013-06-16 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: engine: sorting gluster volume options .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15773 To u

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected the event log message

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Corrected the event log message .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1342/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: webadmin: host gluster-swift sub tab

2013-06-16 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: host gluster-swift sub tab .. webadmin: host gluster-swift sub tab Adding a new sub-tab "Gluster Swift" under Hosts. This will list all the Glus

[Engine-patches] Change in ovirt-engine[master]: webadmin: host gluster-swift sub tab

2013-06-16 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: host gluster-swift sub tab .. Patch Set 12: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15296 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: gluster: Host detach case sync message corrected

2013-06-16 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Host detach case sync message corrected .. Patch Set 2: (1 inline comment) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: webadmin: host gluster-swift sub tab

2013-06-16 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: host gluster-swift sub tab .. Patch Set 10: (1 inline comment) Commit Message Line 6: Line 7: webad

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected the event log message

2013-06-16 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Corrected the event log message .. Patch Set 6: Verified (1 inline comment) File backend/man

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 58 - Failure!

2013-06-16 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/58/ Build Number: 58 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1035 - Failure!

2013-06-16 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1035/ Build Number: 1035 Build Status: Failure Triggered By: Started by timer - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: 12. core: Introducing EntityInfo class

2013-06-16 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: 12. core: Introducing EntityInfo class .. Patch Set 8: Fails Build fails - probably due to rebase issue with CopyImageGroup and MoveImageGroup. Please still r

[Engine-patches] Change in ovirt-engine[master]: 5. core: Persist all async task placeholders

2013-06-16 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: 5. core: Persist all async task placeholders .. Patch Set 7: (1 inline comment) File backend/manager/modul

[Engine-patches] Change in ovirt-engine[master]: core: add canDoAction to remove storage connection

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add canDoAction to remove storage connection .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1341/

[Engine-patches] Change in ovirt-engine[master]: restapi : during deleting disk an error in log “Could not fi...

2013-06-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : during deleting disk an error in log “Could not find sub-resource in the collection resource" .. Patch Set 1: Hi Michael, I could reproduce the bug and th

[Engine-patches] Change in ovirt-engine[master]: webadmin: Consolidated move & copy disk availability checks

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Consolidated move & copy disk availability checks .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_ge

[Engine-patches] Change in ovirt-engine[master]: core: add canDoAction to remove storage connection

2013-06-16 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: add canDoAction to remove storage connection .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/15269 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: 5. core: Persist all async task placeholders

2013-06-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: 5. core: Persist all async task placeholders .. Patch Set 7: (1 inline comment) File backend/manager/modules/bl

[Engine-patches] Change in ovirt-engine[master]: webadmin: Consolidated move & copy disk availability checks

2013-06-16 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: webadmin: Consolidated move & copy disk availability checks .. webadmin: Consolidated move & copy disk availability checks The logic for checking whether moving a d

[Engine-patches] Change in ovirt-engine[master]: engine: change path of console descriptors

2013-06-16 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: engine: change path of console descriptors .. Patch Set 2: I think Tomas can do this. -- To view, visit http://gerrit.ovirt.org/15727 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: core: revert when failing to export a vm

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: revert when failing to export a vm .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1335/ : FAILUR

[Engine-patches] Change in ovirt-engine[master]: engine: fix gluster hook conten-type detection

2013-06-16 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: engine: fix gluster hook conten-type detection .. engine: fix gluster hook conten-type detection The hook will be considered as human readable('TEXT') if

[Engine-patches] Change in ovirt-engine[master]: engine: fix gluster hook conten-type detection

2013-06-16 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: engine: fix gluster hook conten-type detection .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15708 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: gluster: renamed RefreshGlusterHook action

2013-06-16 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: gluster: renamed RefreshGlusterHook action .. gluster: renamed RefreshGlusterHook action changed from "RefreshGlusterHook" to "RefreshGlusterHooks" to be

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster hooks - sync with servers action

2013-06-16 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: gluster hooks - sync with servers action .. webadmin: gluster hooks - sync with servers action Added a new action "Sync" to gluster hooks sub-ta

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster hooks - sync with servers action

2013-06-16 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: gluster hooks - sync with servers action .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15574 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: RegisterDiskCommand - fix and refactor CDA

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: RegisterDiskCommand - fix and refactor CDA .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1333/

[Engine-patches] Change in ovirt-engine[master]: core: revert when failing to export a template

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: revert when failing to export a template .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1334/ :

[Engine-patches] Change in ovirt-engine[master]: engine: change path of console descriptors

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: change path of console descriptors .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1332/ : FAIL

[Engine-patches] Change in ovirt-engine[master]: gluster: renamed RefreshGlusterHook action

2013-06-16 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: renamed RefreshGlusterHook action .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15573 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: Notification service should send a notification when Databas...

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Notification service should send a notification when Database is down. .. Patch Set 1: No score Build Successful http://jenkins.ovirt.org/job/ovirt_

[Engine-patches] Change in ovirt-engine[master]: 7. core: Change CreateAllSnapshotsFromVmCommand to persist a...

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 7. core: Change CreateAllSnapshotsFromVmCommand to persist all placeholders .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engi

[Engine-patches] Change in ovirt-engine[master]: 5. core: Persist all async task placeholders

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 5. core: Persist all async task placeholders .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1327/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: 2. core : Persist AsyncTask before submitting to vdsm

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 2. core : Persist AsyncTask before submitting to vdsm .. Patch Set 27: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/13

[Engine-patches] Change in ovirt-engine[master]: 6. core : Change AddVmTemplateCommand

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 6. core : Change AddVmTemplateCommand .. Patch Set 7: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1325/ : FAILURE

[Engine-patches] Change in ovirt-engine[master]: 8. core : Change HibernateVmCommand to persist all placehold...

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 8. core : Change HibernateVmCommand to persist all placeholders .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_

[Engine-patches] Change in ovirt-engine[master]: findbugs: adding category ignore list

2013-06-16 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: findbugs: adding category ignore list .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15775 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: revert when failing to export a vm

2013-06-16 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: revert when failing to export a vm .. Patch Set 1: Fails -- To view, visit http://gerrit.ovirt.org/15782 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: display eventName when registration failed

2013-06-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: display eventName when registration failed .. Patch Set 1: Looks good to me, but someone else must approve Doron/Yair - who can give +2 on this component?

[Engine-patches] Change in ovirt-engine[master]: core: add check for iqn in addStorageServerConn

2013-06-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: add check for iqn in addStorageServerConn .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15516

[Engine-patches] Change in ovirt-engine[master]: core: add validation non empty connection field

2013-06-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: add validation non empty connection field .. Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) Giving +1, let's give Cheryn

[Engine-patches] Change in ovirt-engine[master]: core: revert when failing to export a vm

2013-06-16 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: revert when failing to export a vm .. core: revert when failing to export a vm When one or more tasks of exporting a vm fails, attempt to clear the disks that

[Engine-patches] Change in ovirt-engine[master]: core: add canDoAction to remove storage connection

2013-06-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: add canDoAction to remove storage connection .. Patch Set 5: Alissa - there's a world of conflicts when trying to apply this patch. Please rebase and veri

[Engine-patches] Change in ovirt-engine[master]: core: revert when failing to export a template

2013-06-16 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: revert when failing to export a template .. core: revert when failing to export a template When failing to export a template, the engine can attempt to delete

[Engine-patches] Change in ovirt-engine[master]: webadmin: align fields in Posix storage dialog

2013-06-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: webadmin: align fields in Posix storage dialog .. Patch Set 1: Tal, Alissa - can this be merged? -- To view, visit http://gerrit.ovirt.org/14879 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: [WIP] : [db] create application objects within own schema

2013-06-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: [WIP] : [db] create application objects within own schema .. Patch Set 5: (3 inline comments) See inline.

[Engine-patches] Change in ovirt-engine[master]: [WIP] : [db] create application objects within own schema

2013-06-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: [WIP] : [db] create application objects within own schema .. Patch Set 5: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: frontend: Make adding (virtio-)console to virtual machines o...

2013-06-16 Thread iheim
Itamar Heim has posted comments on this change. Change subject: frontend: Make adding (virtio-)console to virtual machines optional .. Patch Set 1: duplicate of 1? -- To view, visit http://gerrit.ovirt.org/15613 To unsub

[Engine-patches] Change in ovirt-engine[master]: engine: change path of console descriptors

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: change path of console descriptors .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15727 To uns

[Engine-patches] Change in ovirt-engine[master]: engine: change path of console descriptors

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: change path of console descriptors .. Patch Set 2: thanks! who can merge this? -- To view, visit http://gerrit.ovirt.org/15727 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: 9. core: adding root command id

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 9. core: adding root command id .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1323/ : SUCCESS -- To v

[Engine-patches] Change in ovirt-engine[master]: 10. core: Adding the ability to get async tasks by entity id

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 10. core: Adding the ability to get async tasks by entity id .. Patch Set 7: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_g

[Engine-patches] Change in ovirt-engine[master]: 11. core: SPMAsyncTask - change from associatedEntities + si...

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 11. core: SPMAsyncTask - change from associatedEntities + single type to map .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_eng

[Engine-patches] Change in ovirt-engine[master]: 1. core : Distingushing between entity and vdsm task ids

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 1. core : Distingushing between entity and vdsm task ids .. Patch Set 27: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerr

[Engine-patches] Change in ovirt-engine[master]: 3. core: Fail tasks that dont have Vdsm Id

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 3. core: Fail tasks that dont have Vdsm Id .. Patch Set 29: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1319/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: findbugs: adding category ignore list

2013-06-16 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: findbugs: adding category ignore list .. Patch Set 1: Yes, There is two problems: 1. not all places that we have pom file we have the ignore project, so findbugs

[Engine-patches] Change in ovirt-engine[master]: engine: change path of console descriptors

2013-06-16 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: engine: change path of console descriptors .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/15727 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: 4. core: Fix variable names in VdcReturnValueBase

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 4. core: Fix variable names in VdcReturnValueBase .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1318/

[Engine-patches] Change in ovirt-engine[master]: 12. core: Introducing EntityInfo class

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 12. core: Introducing EntityInfo class .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1317/ : FAILURE

[Engine-patches] Change in ovirt-engine[master]: 15. core : Handle incomplete tasks on server restart

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 15. core : Handle incomplete tasks on server restart .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1316

[Engine-patches] Change in ovirt-engine[master]: 13. core: Introducing "end command coordination" by command ...

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 13. core: Introducing "end command coordination" by command Id .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs

[Engine-patches] Change in ovirt-engine[master]: 14. core: Further cleanup for for end of command coordinatio...

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: 14. core: Further cleanup for for end of command coordination .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix disk allocation on new VM/Template

2013-06-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: Fix disk allocation on new VM/Template .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/15576 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix disk allocation on new VM/Template

2013-06-16 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix disk allocation on new VM/Template .. webadmin: Fix disk allocation on new VM/Template When creating a new template from VM or a new VM/pool f

[Engine-patches] Change in otopi[master]: packager: yum: refresh yum instance at every transaction

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packager: yum: refresh yum instance at every transaction .. packager: yum: refresh yum instance at every transaction yum has long history, especially at

[Engine-patches] Change in otopi[master]: packager: yum: refresh yum instance at every transaction

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packager: yum: refresh yum instance at every transaction .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15780 To

[Engine-patches] Change in otopi[master]: packagers: yum: add explicit destructor to miniyum

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packagers: yum: add explicit destructor to miniyum .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15779 To unsubs

[Engine-patches] Change in otopi[master]: packagers: yum: add explicit destructor to miniyum

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: add explicit destructor to miniyum .. packagers: yum: add explicit destructor to miniyum Change-Id: Ib75f01b8dd26a9f4d0b8748b45322d5619f3

[Engine-patches] Change in otopi[master]: packagers: yum: drop the local helper

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packagers: yum: drop the local helper .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15778 To unsubscribe, visit

[Engine-patches] Change in otopi[master]: packagers: yum: drop the local helper

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: drop the local helper .. packagers: yum: drop the local helper Change-Id: I65e3340bc805811e5e2a41af23bd53386ba340ae Signed-off-by: Alon B

[Engine-patches] Change in otopi[master]: packagers: yum: add explicit destructor to miniyum

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packagers: yum: add explicit destructor to miniyum .. packagers: yum: add explicit destructor to miniyum Change-Id: Ib75f01b8dd26a9f4d0b8748b45322d5619f34ac3 Sig

[Engine-patches] Change in otopi[master]: packagers: yum: drop the local helper

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packagers: yum: drop the local helper .. packagers: yum: drop the local helper Change-Id: I65e3340bc805811e5e2a41af23bd53386ba340ae Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in otopi[master]: packager: yum: refresh yum instance at every transaction

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packager: yum: refresh yum instance at every transaction .. packager: yum: refresh yum instance at every transaction yum has long history, especially at the suck

[Engine-patches] Change in ovirt-engine[master]: 15. core : Handle incomplete tasks on server restart

2013-06-16 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: 15. core : Handle incomplete tasks on server restart .. Patch Set 9: I see Ravi has answered Allon's comments. Allon - waiting for more input on this. -- To v

[Engine-patches] Change in ovirt-engine[master]: packaging: fix pep8 issues

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: fix pep8 issues .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/15759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: move setup related files out of versionloc...

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move setup related files out of versionlock .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15776 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: refactored cpu validation

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: refactored cpu validation .. Patch Set 4: Verified; I would prefer that you didn't submit this Do not merge until we publish otopi-1.1 rebase

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support package upgrade

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: support package upgrade .. Patch Set 1: Verified; I would prefer that you didn't submit this Do not merge until we publish otopi-1.1 -- To vie

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: use firewalld implementation of otopi

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: use firewalld implementation of otopi .. Patch Set 2: Verified; I would prefer that you didn't submit this Do not merge until we publish otopi-1

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support package upgrade

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: support package upgrade .. packaging: setup: support package upgrade yum reads exclude/include information to sack when first used. this has a

[Engine-patches] Change in ovirt-engine[master]: 11. core: SPMAsyncTask - change from associatedEntities + si...

2013-06-16 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: 11. core: SPMAsyncTask - change from associatedEntities + single type to map .. Patch Set 7: Allon, still need explanation from you on previous comments Thank

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: move setup related files out of versionloc...

2013-06-16 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: move setup related files out of versionlock .. packaging: setup: move setup related files out of versionlock the setup requires files that curr

[Engine-patches] Change in ovirt-engine[master]: 7. core: Change CreateAllSnapshotsFromVmCommand to persist a...

2013-06-16 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: 7. core: Change CreateAllSnapshotsFromVmCommand to persist all placeholders .. Patch Set 7: I see Ravi rebased and took care of Allon's comment -- To view, v

[Engine-patches] Change in ovirt-engine[master]: 6. core : Change AddVmTemplateCommand

2013-06-16 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: 6. core : Change AddVmTemplateCommand .. Patch Set 7: I see that Ravi rebased and took care of Allon's comment -- To view, visit http://gerrit.ovirt.org/15562

  1   2   3   4   >