[Engine-patches] Change in ovirt-engine[master]: Expose the info about HBA devices in frontend

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Expose the info about HBA devices in frontend .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1160/ : SUC

[Engine-patches] Change in ovirt-engine[master]: engine: Save VDSM information about HBA devices

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Save VDSM information about HBA devices .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1159/ : S

[Engine-patches] Change in ovirt-engine[master]: restapi: add refresh capabilities action to Host

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: add refresh capabilities action to Host .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1158/ :

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 3: (2 inline comments) I will give you an example why this may break. If we have two search pat

[Engine-patches] Change in ovirt-engine[master]: engine:Fixed FK violation on update of gluster event names

2013-06-13 Thread sabose
Sahina Bose has uploaded a new change for review. Change subject: engine:Fixed FK violation on update of gluster event names .. engine:Fixed FK violation on update of gluster event names A FK violation occurs during upgrade due

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added functionality to Add Provider Network popup

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added functionality to Add Provider Network popup .. Patch Set 14: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_g

[Engine-patches] Change in ovirt-engine[master]: webadmin: Provider/Networks subtab availability by provided ...

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Provider/Networks subtab availability by provided types .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bu

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added DC column to Provider/Networks subtab

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added DC column to Provider/Networks subtab .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/115

[Engine-patches] Change in ovirt-engine[master]: core: Added isExternal() method to Network

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Added isExternal() method to Network .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1151/ : SUCCES

[Engine-patches] Change in ovirt-engine[master]: core: Added provided object types to ProviderType

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Added provided object types to ProviderType .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1150/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: Created model for Remove Provider Networks popup

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Created model for Remove Provider Networks popup .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Refactored code concerning Network creation

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Refactored code concerning Network creation .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/114

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added Provider/Networks subtab

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added Provider/Networks subtab .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1147/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: webadmin: Housekeeping in ProviderNetworksListModel

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Housekeeping in ProviderNetworksListModel .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/114

[Engine-patches] Change in ovirt-engine[master]: webadmin: Moved provider discovery logic to popup

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Moved provider discovery logic to popup .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1146/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added provider column to Networks main tab

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added provider column to Networks main tab .. Patch Set 15: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1

[Engine-patches] Change in ovirt-engine[master]: core: Added search for Network by Provider name

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Added search for Network by Provider name .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1143/ : S

[Engine-patches] Change in ovirt-engine[master]: webadmin: add pulic use column to Discover Network dialog

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add pulic use column to Discover Network dialog .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Discover Network

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Discover Network .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1141/ : SUCCESS -- To view,

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added linking from Provider to Network

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added linking from Provider to Network .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1140/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: Set Provider system tree icon by type

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Set Provider system tree icon by type .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1139/ : S

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added DC-per-network choice in Discovery popup

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added DC-per-network choice in Discovery popup .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added linking from Network to Provider

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added linking from Network to Provider .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1137/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added infrastructure for linking to System Tree it...

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added infrastructure for linking to System Tree items .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bug

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added method AddChild() to SystemTreeItemModel

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added method AddChild() to SystemTreeItemModel .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1028 - Still Failing!

2013-06-13 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1028/ Build Number: 1028 Build Status: Still Failing Triggered By: Started by timer, Started by timer, Started by timer, Started by timer, Started by timer, Started by tim

[Engine-patches] Change in ovirt-engine[master]: gluster: Host detach case sync message corrected

2013-06-13 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Host detach case sync message corrected .. Patch Set 1: (3 inline comments) File backend/mana

[Engine-patches] Change in ovirt-engine[master]: webadmin: Warning when editing Network Provider URL

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Warning when editing Network Provider URL .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1134/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disabled VNIC properties for external networks

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Disabled VNIC properties for external networks .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disabled assign/unassign fields for external netwo...

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Disabled assign/unassign fields for external networks .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_

[Engine-patches] Change in ovirt-engine[master]: webadmin: Changed URL behaviour in Provider popup

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Changed URL behaviour in Provider popup .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1131/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: Improved Provider/Networks subtab command labels

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Improved Provider/Networks subtab command labels .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Improved UrlValidation

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Improved UrlValidation .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1129/ : SUCCESS -- To

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added "new network" popup on Providers tab

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Added "new network" popup on Providers tab .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/112

[Engine-patches] Change in ovirt-engine[master]: webadmin: Refactoring in ProviderModel

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Refactoring in ProviderModel .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1128/ : FAILURE

[Engine-patches] Change in ovirt-engine[master]: webadmin: Improved design of Provider popup

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Improved design of Provider popup .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1126/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: restapi: memory snapshot feature support

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: memory snapshot feature support .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1125/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: webadmin: preview snapshot with memory popup

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: preview snapshot with memory popup .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1123/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory column to snapshot subtab

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add memory column to snapshot subtab .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1124/ : SU

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory option to create snapshot popup

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add memory option to create snapshot popup .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1122

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1027 - Still Failing!

2013-06-13 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1027/ Build Number: 1027 Build Status: Still Failing Triggered By: Started by timer, Started by timer, Started by timer - Changes Since

[Engine-patches] Change in ovirt-engine[master]: core: cleanup CreateVmVDSCommand

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup CreateVmVDSCommand .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1121/ : FAILURE -- T

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 52 - Still Failing!

2013-06-13 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/52/ Build Number: 52 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: core: handling memory snapshots on export/import vm

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: handling memory snapshots on export/import vm .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1120/

[Engine-patches] Change in ovirt-engine[master]: core: restore memory from snapshot on run vm

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: restore memory from snapshot on run vm .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1118/ : FA

[Engine-patches] Change in ovirt-engine[master]: core: remove memory snapshot when its not needed

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: remove memory snapshot when its not needed .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1119/ :

[Engine-patches] Change in ovirt-engine[master]: core: memory state handling on preview/commit/undo

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: memory state handling on preview/commit/undo .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1117/

[Engine-patches] Change in ovirt-engine[master]: core: remove memory image on remove snapshot

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: remove memory image on remove snapshot .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1116/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: core: Reduce host connection timeout

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Reduce host connection timeout .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1115/ : SUCCESS --

[Engine-patches] Change in ovirt-engine[master]: webadmin: reuse code in StorageListModel

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: reuse code in StorageListModel .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit// : FAILUR

[Engine-patches] Change in ovirt-engine[master]: engine: Added provider custom properties

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added provider custom properties .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1110/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: engine: Added provider network for run & stop VM

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added provider network for run & stop VM .. Patch Set 22: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1108/

[Engine-patches] Change in ovirt-engine[master]: engine: Validations for exported external network

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Validations for exported external network .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1109/

[Engine-patches] Change in ovirt-engine[master]: engine: Added check that provider networks unused

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added check that provider networks unused .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1107/

[Engine-patches] Change in ovirt-engine[master]: engine: Added check for external network + port mirroring

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added check for external network + port mirroring .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Added checks for external network on cluster

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added checks for external network on cluster .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/110

[Engine-patches] Change in ovirt-engine[master]: engine: Added checks for external networks

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added checks for external networks .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1104/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: engine: Add keystone support in Openstack Network

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add keystone support in Openstack Network .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1103/ :

[Engine-patches] Change in ovirt-engine[master]: engine: Map VLAN & label to network

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Map VLAN & label to network .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1102/ : SUCCESS --

[Engine-patches] Change in ovirt-engine[master]: engine: Allow non auth provider to add network

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Allow non auth provider to add network .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1101/ :

[Engine-patches] Change in ovirt-engine[master]: engine: Add command to add network on provider

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add command to add network on provider .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1100/ : S

[Engine-patches] Change in ovirt-engine[master]: core: Add provider additional properties

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add provider additional properties .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1097/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: engine: Added runtime custom properties

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added runtime custom properties .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1099/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Added label to Network class

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Added label to Network class .. Patch Set 16: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1098/ : FAILURE --

[Engine-patches] Change in ovirt-engine[master]: core: Add ProviderNetwork class

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add ProviderNetwork class .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1096/ : SUCCESS -- To

[Engine-patches] Change in ovirt-engine[master]: engine: Block external networks in Setup Networks

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Block external networks in Setup Networks .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1095/

[Engine-patches] Change in ovirt-engine[master]: engine: Added provider name to NetworkView

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added provider name to NetworkView .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1093/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: engine: Block hot updating external networks

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Block hot updating external networks .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1094/ : SUC

[Engine-patches] Change in ovirt-engine[master]: engine: Block external network for legacy network commands

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Block external network for legacy network commands .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Added 'OpenStack Network' provider proxy

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added 'OpenStack Network' provider proxy .. Patch Set 25: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1091/

[Engine-patches] Change in ovirt-engine[master]: core: Add providedBy field to Network

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add providedBy field to Network .. Patch Set 26: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1090/ : SUCCESS -

[Engine-patches] Change in ovirt-engine[master]: engine: Added query for external networks on provider

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added query for external networks on provider .. Patch Set 27: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/10

[Engine-patches] Change in ovirt-engine[master]: engine: Added network provider proxy API

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added network provider proxy API .. Patch Set 25: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1088/ : FAILU

[Engine-patches] Change in ovirt-engine[master]: WIP core: fix businessentity hashCode/equals errors

2013-06-13 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: WIP core: fix businessentity hashCode/equals errors .. Patch Set 3: @Allon, @Laszlo: I think we should move forward with it. Maybe the best thing (limited time

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 3: (2 inline comments) base/BRANDING_PACKAGE/path base is determined at runtime (in our case

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 3: (2 inline comments) It is working and what I write is minor... I just was surprise to this t

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: type ahead list box

2013-06-13 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: userportal,webadmin: type ahead list box .. Patch Set 8: P.S. I still think it might be worth considering to inherit from ListModelListBox, it would make about as

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 3: Verified I am trying to understand what you are saying and I am having trouble. You don't

[Engine-patches] Change in ovirt-engine[master]: engine: Add support for vNICs in OpenstackNetwork

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add support for vNICs in OpenstackNetwork .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1087/

[Engine-patches] Change in ovirt-engine[master]: engine: Added query for all networks from provider

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Added query for all networks from provider .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1086/

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 1: Hi, My previous comment regarding the patch was that I expect two parameters to the servlet

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 1: (2 inline comments) File backend/manage

[Engine-patches] Change in ovirt-engine[master]: restapi : Placement policy template properties should be lis...

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi : Placement policy template properties should be listed(#949285) .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_

[Engine-patches] Change in ovirt-engine[master]: frontend, engine: inherit template permissions on VM creation

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: frontend,engine: inherit template permissions on VM creation .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_ger

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 1: (1 inline comment) Are we allowed to use commons-io FileUtils to do that path massaging for

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix displaying binary gluster hook

2013-06-13 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: fix displaying binary gluster hook .. webadmin: fix displaying binary gluster hook When resolving a conflict on a hook with differet content types in di

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix LocaleFilter

2013-06-13 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal,webadmin: fix LocaleFilter .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15703 To unsubs

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: fix comment from branding patch .. Patch Set 1: Verified This patch should address the remaining comment on the large branding patch. --

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix LocaleFilter

2013-06-13 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: fix LocaleFilter .. Patch Set 1: Verified While working on another patch I noticed that we had a util class for reading properties files.

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix LocaleFilter

2013-06-13 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: userportal,webadmin: fix LocaleFilter .. userportal,webadmin: fix LocaleFilter - Fixed a potential resource leak in LocaleFilter. The inputstream was opened bu

[Engine-patches] Change in ovirt-engine[master]: gluster: Corrected event log msg for add brick

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Corrected event log msg for add brick .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1076/ : SU

[Engine-patches] Change in ovirt-engine[master]: engine: include VdsGroup virt, gluster flags in VDS entity

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: include VdsGroup virt, gluster flags in VDS entity .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_ger

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: update branding manager

2013-06-13 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: userportal,webadmin: update branding manager .. Patch Set 8: Thanks Alexander! Are we done? more comments than lines of code :))) -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotate

2013-06-13 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: log rotate .. Patch Set 3: > any new insights? See bug... I am waiting a bit more if someone has different view. -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: type ahead list box

2013-06-13 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: userportal,webadmin: type ahead list box .. Patch Set 8: (12 inline comments) Please accept my sincere apology, I've come to terms with the base class, just not i

[Engine-patches] Change in ovirt-engine[master]: [WIP] Add temporary LDAP authenticator

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Add temporary LDAP authenticator .. Patch Set 1: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovirt_e

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add refresh capabilities button to hosts main tab

2013-06-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Add refresh capabilities button to hosts main tab .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerr

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: fix comment from branding patch

2013-06-13 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: userportal,webadmin: fix comment from branding patch .. userportal,webadmin: fix comment from branding patch - Fixed BrandingServlet getFullPath according to b

[Engine-patches] Change in ovirt-engine[master]: core: Add snapshot validation for empty guid.

2013-06-13 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Add snapshot validation for empty guid. .. core: Add snapshot validation for empty guid. Currently when virt-v2v is used to convert a vm from a foreign hyp

  1   2   3   4   5   >