Greg Sheremeta has posted comments on this change.
Change subject: userportal,webadmin: fix comment from branding patch
......................................................................
Patch Set 1: (1 inline comment)
Are we allowed to use commons-io FileUtils to do that path massaging for us?
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java
Line 185: * @param base Base part of the path.
Line 186: * @param path The path to attach to the base.
Line 187: * @return The merger of base and path.
Line 188: */
Line 189: public static String mergePaths(final String base, final String
path) {
commons-io FileUtils will do this, too.
http://commons.apache.org/proper/commons-io/apidocs/org/apache/commons/io/FilenameUtils.html#normalize(java.lang.String,
boolean)
I'm new and not sure about library inclusion, though :)
Line 190: String mergedPath = "/";
Line 191: if (base != null) {
Line 192: mergedPath = base;
Line 193: // Make sure base always ends with a '/'
--
To view, visit http://gerrit.ovirt.org/15702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fad1cda014713724f294fe8454fb5f36870c137
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
