[Engine-patches] Change in ovirt-engine[master]: engine: Added canDoAction checks in case of gluster host rem...

2013-06-09 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: Added canDoAction checks in case of gluster host removal .. Patch Set 1: (1 inline comment) Will update patchset based on Yair's comments

[Engine-patches] Change in ovirt-engine[master]: core: memory state handling on preview/commit/undo

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: memory state handling on preview/commit/undo .. Patch Set 19: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/557

[Engine-patches] Change in ovirt-engine[master]: core: restore memory from snapshot on run vm

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: restore memory from snapshot on run vm .. Patch Set 19: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/559/ : FA

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory column to snapshot subtab

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add memory column to snapshot subtab .. Patch Set 19: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/jo

[Engine-patches] Change in ovirt-engine[master]: core: save memory state on live snapshot with memory

2013-06-09 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: save memory state on live snapshot with memory .. Patch Set 21: (2 inline comments) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: core: cleanup CreateVmVDSCommand

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup CreateVmVDSCommand .. Patch Set 16: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/558/ : FAILURE -- T

[Engine-patches] Change in ovirt-engine[master]: pki: split enroll out of create CA

2013-06-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: split enroll out of create CA .. Patch Set 2: Verified Added die at chown. -- To view, visit http://gerrit.ovirt.org/15499 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory option to create snapshot popup

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add memory option to create snapshot popup .. Patch Set 18: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.

[Engine-patches] Change in ovirt-engine[master]: pki: split enroll out of create CA

2013-06-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: split enroll out of create CA .. Patch Set 1: (3 inline comments) Thanks! File packaging/etc/pki/Create

[Engine-patches] Change in ovirt-engine[master]: core: [WIP] handling memory snapshots on export/import vm

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: [WIP] handling memory snapshots on export/import vm .. Patch Set 16: I would prefer that you didn't submit this Build Unstable http://jenkins.o

[Engine-patches] Change in ovirt-engine[master]: pki: split enroll out of create CA

2013-06-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: pki: split enroll out of create CA .. Patch Set 1: (3 inline comments) few inline comments File packagin

[Engine-patches] Change in ovirt-engine[master]: core: save memory state on live snapshot with memory

2013-06-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: save memory state on live snapshot with memory .. Patch Set 21: (2 inline comments) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: core: save memory state on live snapshot with memory

2013-06-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: save memory state on live snapshot with memory .. Patch Set 21: (4 inline comments) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: core : update of bootable disk

2013-06-09 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: core : update of bootable disk .. core : update of bootable disk when updating a bootable disk, a CDA message was always shown because of a check that

[Engine-patches] Change in ovirt-engine[master]: core : update of bootable disk

2013-06-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core : update of bootable disk .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15218 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support non standard umask

2013-06-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: support non standard umask .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15496

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0130_change_dwh_history_timekeeping_date_...

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0130_change_dwh_history_timekeeping_date_type.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgr

[Engine-patches] Change in ovirt-engine[master]: restapi: add memory attribute to snapshot

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: add memory attribute to snapshot .. Patch Set 15: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovi

[Engine-patches] Change in ovirt-engine[master]: core : update of bootable disk

2013-06-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core : update of bootable disk .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15218 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: restapi: support for creating snapshot with memory

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: support for creating snapshot with memory .. Patch Set 15: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0430_update_locked_status_to_ok.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0430_update_locked_status_to_ok.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0420_encrypt_pm_passwd.sh

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0420_encrypt_pm_passwd.sh .. Patch Set 2: Please elaborate here on why you could make the squash -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: preview snapshot with memory popup

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: preview snapshot with memory popup .. Patch Set 18: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0410_add_disks_usage.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0410_add_disks_usage.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15470 To

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0380_add_otp_validity_to_vds_static.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0380_add_otp_validity_to_vds_static.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0360_upgrade_default_vds_group_thp.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0360_upgrade_default_vds_group_thp.sql .. Patch Set 2: where is the matching squash code? -- To view, visit http://gerrit.ovirt.org/15468 T

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0330_add_configuration_action_group_to_su...

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0330_add_configuration_action_group_to_super_user_role.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0300_add_local_admin_user.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0300_add_local_admin_user.sql .. Patch Set 2: Where is the matching squash part? -- To view, visit http://gerrit.ovirt.org/15466 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0280_change_blank_template_default_displa...

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0280_change_blank_template_default_display_type_to_spice.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0270_change_users_group_ids_field_to_text...

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0270_change_users_group_ids_field_to_text.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0260_change_app_list_type_to_text.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0260_change_app_list_type_to_text.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-iso-uploader[master]: core: modify copyright of base po

2013-06-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 1: Verified; Looks good to me, approved Merging based on previous ack. -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-iso-uploader[master]: core: modify copyright of base po

2013-06-09 Thread sbonazzo
Sandro Bonazzola has submitted this change and it was merged. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: I11ea0e9a840168d180182685078c9dcb43aa7bd5 Signed-off-by: Alon Bar-L

[Engine-patches] Change in ovirt-log-collector[master]: core: modify copyright of base po

2013-06-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous ack. -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0220_add_MaxAuditLogMessageLength_to_conf...

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0220_add_MaxAuditLogMessageLength_to_config.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://ge

[Engine-patches] Change in ovirt-image-uploader[master]: core: modify copyright of base po

2013-06-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 1: Verified; Looks good to me, approved Merging based on previous ack. -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-log-collector[master]: core: modify copyright of base po

2013-06-09 Thread sbonazzo
Sandro Bonazzola has submitted this change and it was merged. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: Ieef2401dea531e7d264006f3cbdf40f44e3c2de1 Signed-off-by: Alon Bar-L

[Engine-patches] Change in ovirt-image-uploader[master]: core: modify copyright of base po

2013-06-09 Thread sbonazzo
Sandro Bonazzola has submitted this change and it was merged. Change subject: core: modify copyright of base po .. core: modify copyright of base po Change-Id: Id860018b4a5cfbfc17ead67e14270a1506f8ab78 Signed-off-by: Alon Bar-L

[Engine-patches] Change in ovirt-engine[master]: webadmin: add gateway to edit network from setup networks di...

2013-06-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: add gateway to edit network from setup networks dialog .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0190_add_latency_vm_disks.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0190_add_latency_vm_disks.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1546

[Engine-patches] Change in ovirt-log-collector[master]: core: modify copyright of base po

2013-06-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: core: modify copyright of base po .. Patch Set 1: Verified; Looks good to me, approved Merging based on previous ack. -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0180_add_guest_disk_size.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0180_add_guest_disk_size.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15460

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0150_update_roles.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0150_update_roles.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15459 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Use OS repository intead of VmOsType

2013-06-09 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: Use OS repository intead of VmOsType .. Patch Set 10: (1 inline comment) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0130_change_dwh_history_timekeeping_date_...

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0130_change_dwh_history_timekeeping_date_type.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: Fix unit tests that were broken by multiple gateways

2013-06-09 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: engine: Fix unit tests that were broken by multiple gateways .. Patch Set 2: (2 inline comments) File backen

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0120_add_update_date_to_vm_templates.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0120_add_update_date_to_vm_templates.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0100_add_device_size_to_luns.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0100_add_device_size_to_luns.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0060_add_group_everyone.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0060_add_group_everyone.sql .. Patch Set 2: Ok, looks like the previous patch includes the matching change for this change - i mean, you're

[Engine-patches] Change in ovirt-engine[master]: core: remove memory image on remove snapshot

2013-06-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: remove memory image on remove snapshot .. Patch Set 20: (4 inline comments) File backend/manager/modules/b

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0050_make_blank_template_pulic.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0050_make_blank_template_pulic.sql .. Patch Set 2: Not sure I understood here the logic, please explain -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: add gateway to edit network from setup networks di...

2013-06-09 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: add gateway to edit network from setup networks dialog .. Patch Set 7: (1 inline comment) File fro

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0040_change_vm_dynamic_vm_ip_type.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0040_change_vm_dynamic_vm_ip_type.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0030_change_storage_format_type_to_str.sq...

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0030_change_storage_format_type_to_str.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0010_add_group_ids_to_users.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00_0010_add_group_ids_to_users.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0000_add_schema_version.sql

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: squash 03_00__add_schema_version.sql .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15450

[Engine-patches] Change in ovirt-engine[master]: core: wip: Introducing ImportVmFromConfigurationCommand

2013-06-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: wip: Introducing ImportVmFromConfigurationCommand .. Patch Set 2: @Itamer The OVF format was chosen as currently we use it for storing the vm configuration on

[Engine-patches] Change in ovirt-engine[master]: core : update of bootable disk

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : update of bootable disk .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/548/ : SUCCESS -- To vie

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0150_update_roles.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0150_update_roles.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_maste

[Engine-patches] Change in ovirt-engine[master]: webadmin: host gluster-swift sub tab

2013-06-09 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: host gluster-swift sub tab .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/15296 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: core : update of bootable disk

2013-06-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core : update of bootable disk .. Patch Set 2: Verified verified by Tal, I've rebased and ran the build again. -- To view, visit http://gerrit.ovirt.org/15218 To un

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0220_add_MaxAuditLogMessageLength_to_conf...

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0220_add_MaxAuditLogMessageLength_to_config.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrad

[Engine-patches] Change in ovirt-engine[master]: webadmin: host gluster-swift sub tab

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: host gluster-swift sub tab .. Patch Set 9: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/ovirt_eng

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0100_add_device_size_to_luns.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0100_add_device_size_to_luns.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_l

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0120_add_update_date_to_vm_templates.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0120_add_update_date_to_vm_templates.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable

[Engine-patches] Change in ovirt-engine[master]: engine: Remove name query parameters containers

2013-06-09 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Remove name query parameters containers .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15182

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0260_change_app_list_type_to_text.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0260_change_app_list_type_to_text.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0180_add_guest_disk_size.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0180_add_guest_disk_size.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_lates

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0190_add_latency_vm_disks.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0190_add_latency_vm_disks.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_late

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0300_add_local_admin_user.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0300_add_local_admin_user.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_late

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0330_add_configuration_action_group_to_su...

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0330_add_configuration_action_group_to_super_user_role.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_en

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0270_change_users_group_ids_field_to_text...

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0270_change_users_group_ids_field_to_text.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_s

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0280_change_blank_template_default_displa...

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0280_change_blank_template_default_display_type_to_spice.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0410_add_disks_usage.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0410_add_disks_usage.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_ma

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0420_encrypt_pm_passwd.sh

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0420_encrypt_pm_passwd.sh .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_m

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0360_upgrade_default_vds_group_thp.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0360_upgrade_default_vds_group_thp.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_3

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0380_add_otp_validity_to_vds_static.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0380_add_otp_validity_to_vds_static.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0430_update_locked_status_to_ok.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0430_update_locked_status_to_ok.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_t

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0010_add_group_ids_to_users.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0010_add_group_ids_to_users.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_la

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0040_change_vm_dynamic_vm_ip_type.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0040_change_vm_dynamic_vm_ip_type.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0000_add_schema_version.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00__add_schema_version.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0030_change_storage_format_type_to_str.sq...

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0030_change_storage_format_type_to_str.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stab

[Engine-patches] Change in ovirt-engine[master]: pki: split enroll out of create CA

2013-06-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: split enroll out of create CA .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15499 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: pki: support umask 0077

2013-06-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: support umask 0077 .. Patch Set 3: Verified rebase -- To view, visit http://gerrit.ovirt.org/15495 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: pki: always reset ca db owner after signature

2013-06-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: always reset ca db owner after signature .. Patch Set 2: Verified clean all database files and create .rnd with right permissions. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: pki: exit SignReq with error if invalid usage

2013-06-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: exit SignReq with error if invalid usage .. Patch Set 2: Verified rebase -- To view, visit http://gerrit.ovirt.org/15487 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: pki: subject is actually optional

2013-06-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: pki: subject is actually optional .. Patch Set 2: Verified Rebase -- To view, visit http://gerrit.ovirt.org/15488 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: pki: split enroll out of create CA

2013-06-09 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: pki: split enroll out of create CA .. pki: split enroll out of create CA the enroll functionality is handy after installation, and soon to be used by the websock

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0060_add_group_everyone.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0060_add_group_everyone.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest

[Engine-patches] Change in ovirt-engine[master]: core: squash 03_00_0050_make_blank_template_pulic.sql

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: squash 03_00_0050_make_blank_template_pulic.sql .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to

[Engine-patches] Change in ovirt-engine[master]: findbugs: Loaded null value of local variables

2013-06-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: findbugs: Loaded null value of local variables .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15321 To u

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix NPE in VmModelBehaviorBase

2013-06-09 Thread mbetak
Martin Beták has posted comments on this change. Change subject: webadmin: Fix NPE in VmModelBehaviorBase .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15282 To unsub

[Engine-patches] Change in ovirt-engine[master]: packaging: service: cleanup: remove unused member

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: service: cleanup: remove unused member .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_lat

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1023 - Still Failing!

2013-06-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1023/ Build Number: 1023 Build Status: Still Failing Triggered By: Started by timer - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: support non standard umask

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: setup: support non standard umask .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_m

[Engine-patches] Change in ovirt-engine[master]: core : Fix for HibernateVm command

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Fix for HibernateVm command .. Patch Set 1: Ravi, I assume that you checked the other commands (AddDisk, create snapshot, etc..) with this change - if w

[Engine-patches] Change in ovirt-engine[master]: engine : Fix variable names in VdcReturnValueBase

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : Fix variable names in VdcReturnValueBase .. Patch Set 14: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: engine : Move all tasks classes to bll.tasks package

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : Move all tasks classes to bll.tasks package .. Patch Set 13: I would prefer that you didn't submit this Do not submit this - it refers to future work o

[Engine-patches] Change in ovirt-engine[master]: engine : Fail tasks that dont have Vdsm Id

2013-06-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : Fail tasks that dont have Vdsm Id .. Patch Set 22: (2 inline comments) File backend/manager/modul

[Engine-patches] Change in ovirt-engine[master]: findbugs: method may pass null to method that cant get null ...

2013-06-09 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: findbugs: method may pass null to method that cant get null value .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.or

  1   2   3   >