Sandro Bonazzola has posted comments on this change.
Change subject: pki: split enroll out of create CA
......................................................................
Patch Set 1: (3 inline comments)
few inline comments
....................................................
File packaging/etc/pki/CreateCA.sh
Line 24: rm -f database.txt*
Line 25: touch database.txt .rnd || die "Cannot write to database.txt"
Line 26: chown --reference=. serial.txt* database.txt* .rnd* || die
"Cannot set database permissions"
Line 27:
Line 28: touch private/ca.pem
|| die "Cannot create private/ca.pem" ?
Line 29: chown --reference=private private/ca.pem || die "Cannot set CA
private key permissions"
Line 30: openssl genrsa \
Line 31: -out private/ca.pem \
Line 32: 2048 \
....................................................
File packaging/etc/pki/enroll.sh
Line 30: "${pass}" \
Line 31: || die "Cannot sign request"
Line 32: [ -s "${PKIDIR}/certs/${name}.cer" ] || die "Certificate
enrollment failed"
Line 33:
Line 34: touch "${PKIDIR}/keys/${name}.p12"
|| die?
Line 35: chmod go-rwx "${PKIDIR}/keys/${name}.p12"
Line 36: openssl \
Line 37: pkcs12 \
Line 38: -export \
Line 31: || die "Cannot sign request"
Line 32: [ -s "${PKIDIR}/certs/${name}.cer" ] || die "Certificate
enrollment failed"
Line 33:
Line 34: touch "${PKIDIR}/keys/${name}.p12"
Line 35: chmod go-rwx "${PKIDIR}/keys/${name}.p12"
|| die?
Line 36: openssl \
Line 37: pkcs12 \
Line 38: -export \
Line 39: -in "${PKIDIR}/certs/${name}.cer" \
--
To view, visit http://gerrit.ovirt.org/15499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f3a8ae1fb061532cdafd5bc7961c5178d7948a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
