Shireesh Anjal has posted comments on this change.
Change subject: engine: Manage Gluster hooks support
..
Patch Set 23: Looks good to me, approved
Please rebase
--
To view, visit http://gerrit.ovirt.org/10650
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: System permissions tab don't update
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12866
To unsubscribe, visit ht
Sahina Bose has posted comments on this change.
Change subject: engine: Manage Gluster hooks support
..
Patch Set 23: Verified
--
To view, visit http://gerrit.ovirt.org/10650
To unsubscribe, visit http://gerrit.ovirt.org/settin
Alon Bar-Lev has posted comments on this change.
Change subject: build: solve m2e manifest problems
..
Patch Set 1:
I don't have any intelligent to write as I have never used eclipse... but looks
great!
--
To view, visit http
Allon Mureinik has posted comments on this change.
Change subject: build: remove double definition of test-jar-plugin.version
..
Patch Set 1: Verified
(1 inline comment)
Fil
Allon Mureinik has posted comments on this change.
Change subject: build: solve m2e manifest problems
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12870
To unsubscribe, visit http://gerrit.ovirt.org/settin
Allon Mureinik has uploaded a new change for review.
Change subject: build: remove double definition of test-jar-plugin.version
..
build: remove double definition of test-jar-plugin.version
Change-Id: I7aaaf5c04bf80ca5848759f3a0
Allon Mureinik has uploaded a new change for review.
Change subject: build: solve m2e manifest problems
..
build: solve m2e manifest problems
The m2e plugin for Eclipse IDE that many developers use is incompatible
with the cutti
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: TreeTable no items to display
..
webadmin: TreeTable no items to display
- Added 'No XX to Display' to tree tables. Where XX
is the appropriate
Einav Cohen has posted comments on this change.
Change subject: webadmin: TreeTable no items to display
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/12738
To unsubscrib
Ravi Nori has posted comments on this change.
Change subject: webadmin: System permissions tab don't update
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/12866
To unsubscribe, visit http://gerrit.ovirt.org/
Einav Cohen has posted comments on this change.
Change subject: core: provided cleared frontend logging
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/commo
Alexander Wels has posted comments on this change.
Change subject: webadmin,userportal: Decouple AspectJ config from
gwt-plugin.extraJvmArgs
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit htt
Alexander Wels has posted comments on this change.
Change subject: webadmin,userportal: Improve form-based sub tabs
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12325
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3686/
Build Number: 3686
Build Status: Fixed
Triggered By: Started by user eyal edri
-
Changes Since Last Success:
Ayal Baron has posted comments on this change.
Change subject: engine: connectStorageServer is not sent for inactive domains
before connectStoragePool
..
Patch Set 2: I would prefer that you didn't submit this
(6 inline commen
Ravi Nori has posted comments on this change.
Change subject: webadmin: System permissions tab don't update
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12866
To unsubscribe, visit http://gerrit.ovirt.org/
Ravi Nori has uploaded a new change for review.
Change subject: webadmin: System permissions tab don't update
..
webadmin: System permissions tab don't update
System permissions tab doesnt update content on
initialization and af
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3685/
Build Number: 3685
Build Status: Failure
Triggered By: Started by an SCM change, Started by an SCM change, Started by an
SCM change
Juan Hernandez has uploaded a new change for review.
Change subject: core: Move the session cleaner interceptor to bll
..
core: Move the session cleaner interceptor to bll
Commit 028ff6 moved the utils library to a JBoss module,
Hello Ofer Schreiber,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/12859
to review the following change.
Change subject: packaging: engine-setup - make firewall checking more robust
..
packaging:
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Move passwd encryption script to tools
..
packaging: Move passwd encryption script to tools
This script used to be in the PKI directory, but it is a
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Use Id=... to check systemd services
..
packaging: Use Id=... to check systemd services
The services managed by systemd can have an unique identifie
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Try nfs and nfs-server
..
packaging: Try nfs and nfs-server
When configuring the NFS service we need to try with both names, as some
distributions u
Juan Hernandez has uploaded a new change for review.
Change subject: core: Add commons-collections to the dal module
..
core: Add commons-collections to the dal module
Commit 81742e created a module for the DAL, but it is missin
Juan Hernandez has uploaded a new change for review.
Change subject: restapi: Use context classloader from YAML
..
restapi: Use context classloader from YAML
The YAML library that we use to build load the RSDL metadata assumes
t
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Conditionally use systemd and System V
..
packaging: Conditionally use systemd and System V
This change introduces two new "install_systemd" and "in
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Prepare for el6 build
..
packaging: Prepare for el6 build
Change the value of macros to build the package for el6 distributions,
remove the maven de
Juan Hernandez has uploaded a new change for review.
Change subject: core: Add JBoss modules for libraries
..
core: Add JBoss modules for libraries
This patch creates JBoss modules for the common, compat, dal, utils,
tooks and s
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Add beanutils as dependency of utils
..
packaging: Add beanutils as dependency of utils
This is needed by the OVF related code.
Change-Id: I370c88f
Juan Hernandez has uploaded a new change for review.
Change subject: tools: Use JBoss modules instead of class path
..
tools: Use JBoss modules instead of class path
Currently in order to run the tools we build the class path us
Juan Hernandez has uploaded a new change for review.
Change subject: core: Add jxpath as commons-configuration dep
..
core: Add jxpath as commons-configuration dep
The commons-configuration module provided by JBoss AS doesn't in
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Move dependencies to a JBoss module
..
packaging: Move dependencies to a JBoss module
Currently we package dependencies as .jar files in the lib dir
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Don't resolve plugins
..
packaging: Don't resolve plugins
Now that we have a plugin in the project that is required for the build
(the jboss modules
Juan Hernandez has uploaded a new change for review.
Change subject: core: Create artifact for PostgreSQL module
..
core: Create artifact for PostgreSQL module
Currently we are deploying the PostgreSQL module using the "setup"
p
Juan Hernandez has uploaded a new change for review.
Change subject: core: Make explicit version of maven ear plugin
..
core: Make explicit version of maven ear plugin
Currently we don't explicitly specify the version of the mav
Juan Hernandez has uploaded a new change for review.
Change subject: core: Make antrun plugin version explicit
..
core: Make antrun plugin version explicit
Currently we don't explicitly specify the version of the maven ant
plugi
Juan Hernandez has uploaded a new change for review.
Change subject: core: Maven plugin to generate JBoss modules
..
core: Maven plugin to generate JBoss modules
This change introduces a new maven plugin that generates .zip file
Juan Hernandez has uploaded a new change for review.
Change subject: core: Make explicit version of maven war plugin
..
core: Make explicit version of maven war plugin
Currently we don't explicitly specify the version of the mav
Juan Hernandez has uploaded a new change for review.
Change subject: core: Don't use commons collections clone method
..
core: Don't use commons collections clone method
The commons collections package provides a mechanism to cl
Juan Hernandez has uploaded a new change for review.
Change subject: core: Remove Encr?ptionManagerMessages
..
core: Remove Encr?ptionManagerMessages
There are two classes with this name, one with "y" and one with "i".
None of t
Juan Hernandez has uploaded a new change for review.
Change subject: core: Move encryption utilities to utils
..
core: Move encryption utilities to utils
We have only two utility classes in the engineencryptutils project, and
th
Juan Hernandez has abandoned this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12642
To unsubscribe, visit http://gerrit.ovirt.org/se
Juan Hernandez has abandoned this change.
Change subject: core: Remove Encr?ptionManagerMessages
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12643
To unsubscribe, visit http://gerrit.ovirt.org/settings
Juan Hernandez has abandoned this change.
Change subject: core: Move encryption utilities to utils
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Juan Hernandez has abandoned this change.
Change subject: core: Don't use commons collections clone method
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12645
To unsubscribe, visit http://gerrit.ovirt.org/
Juan Hernandez has abandoned this change.
Change subject: core: Make explicit version of maven ear plugin
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12646
To unsubscribe, visit http://gerrit.ovirt.org/s
Juan Hernandez has abandoned this change.
Change subject: core: Make antrun plugin version explicit
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12647
To unsubscribe, visit http://gerrit.ovirt.org/setting
Juan Hernandez has abandoned this change.
Change subject: core: Make explicit version of maven war plugin
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12648
To unsubscribe, visit http://gerrit.ovirt.org/s
Juan Hernandez has abandoned this change.
Change subject: core: Maven plugin to generate JBoss modules
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12649
To unsubscribe, visit http://gerrit.ovirt.org/sett
Juan Hernandez has abandoned this change.
Change subject: core: Create artifact for PostgreSQL module
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12650
To unsubscribe, visit http://gerrit.ovirt.org/setti
Juan Hernandez has abandoned this change.
Change subject: packaging: Move dependencies to a JBoss module
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12651
To unsubscribe, visit http://gerrit.ovirt.org/se
Juan Hernandez has abandoned this change.
Change subject: core: Add JBoss modules for libraries
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12652
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Juan Hernandez has abandoned this change.
Change subject: core: Add jxpath as commons-configuration dep
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12653
To unsubscribe, visit http://gerrit.ovirt.org/set
Juan Hernandez has abandoned this change.
Change subject: tools: Use JBoss modules instead of class path
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12654
To unsubscribe, visit http://gerrit.ovirt.org/se
Juan Hernandez has abandoned this change.
Change subject: packaging: Add beanutils as dependency of utils
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12655
To unsubscribe, visit http://gerrit.ovirt.org/s
Juan Hernandez has abandoned this change.
Change subject: core: Move the session cleaner interceptor to bll
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12656
To unsubscribe, visit http://gerrit.ovirt.org
Juan Hernandez has abandoned this change.
Change subject: packaging: Don't resolve plugins
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Juan Hernandez has abandoned this change.
Change subject: restapi: Use context classloader from YAML
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12658
To unsubscribe, visit http://gerrit.ovirt.org/settin
Juan Hernandez has abandoned this change.
Change subject: core: Add commons-collections to the dal module
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12659
To unsubscribe, visit http://gerrit.ovirt.org/s
Juan Hernandez has abandoned this change.
Change subject: packaging: engine-setup - make firewall checking more robust
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12660
To unsubscribe, visit http://gerri
Juan Hernandez has abandoned this change.
Change subject: packaging: Move passwd encryption script to tools
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12662
To unsubscribe, visit http://gerrit.ovirt.org
Juan Hernandez has abandoned this change.
Change subject: packaging: Changes required for el6
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12663
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Juan Hernandez has abandoned this change.
Change subject: core: Removed the ResXResourceReader class
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12661
To unsubscribe, visit http://gerrit.ovirt.org/settin
Daniel Erez has posted comments on this change.
Change subject: webadmin: TreeTable no items to display
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12738
To unsubscribe, visit
Ravi Nori has posted comments on this change.
Change subject: cli: Ping command success message need to be rephrased(#918749)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12840
To unsubscribe, visit http:/
Ravi Nori has uploaded a new change for review.
Change subject: cli: Ping command success message need to be rephrased(#918749)
..
cli: Ping command success message need to be rephrased(#918749)
ovirt-shell ping success message
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: fixing Materialized Views function signatures
..
core: fixing Materialized Views function signatures
Adding missing signatures and fixing some th
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing Materialized Views function signatures
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12041
To unsu
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing Materialized Views function signatures
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12041
To unsu
Alexander Wels has posted comments on this change.
Change subject: webadmin: TreeTable no items to display
..
Patch Set 3: (1 inline comment)
File
frontend/webadmin/modules/
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin,userportal: replaced dialog error icon
..
webadmin,userportal: replaced dialog error icon
Replaced error dialog 'X' icon with '!' icon.
Change-I
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: replaced dialog error icon
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12684
To unsubscribe
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin,userportal: replaced close dialog icon
..
webadmin,userportal: replaced close dialog icon
Replaced the close dialog 'X' icon.
Change-Id: I0475b1
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: replaced close dialog icon
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12683
To unsubscribe
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Storage dialog - fix description width
..
webadmin: Storage dialog - fix description width
Storage dialog - fix the width of description field
(
Daniel Erez has posted comments on this change.
Change subject: webadmin: Storage dialog - fix description width
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12585
To unsubscrib
Arik Hadas has uploaded a new change for review.
Change subject: core: remove duplicate event on successful hibernation
..
core: remove duplicate event on successful hibernation
Successful hibernating (suspending) VM resulted in
Daniel Erez has posted comments on this change.
Change subject: webadmin: TreeTable no items to display
..
Patch Set 3: (1 inline comment)
File
frontend/webadmin/modules/web
Alexander Wels has posted comments on this change.
Change subject: webadmin: TreeTable no items to display
..
Patch Set 3:
Added cast check.
--
To view, visit http://gerrit.ovirt.org/12738
To unsubscribe, visit http://gerrit.o
Eli Mesika has submitted this change and it was merged.
Change subject: core: Authentication error messages on the engine.
..
core: Authentication error messages on the engine.
Authentication error messages on the engine.log sh
Eli Mesika has posted comments on this change.
Change subject: core: Authentication error messages on the engine.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12828
To unsubscri
Eli Mesika has posted comments on this change.
Change subject: core: Authentication error messages on the engine.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12828
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: userportal,webadmin: Builders infrastructure
..
Patch Set 9:
1) we can add a new method to the RpcService we have client logic there 'on
server side', sth like
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: double click invokes default command
..
webadmin: double click invokes default command
- Added code to allow double click to invoke the default
Daniel Erez has posted comments on this change.
Change subject: webadmin: double click invokes default command
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10640
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: webadmin: double click invokes default command
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10640
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: webadmin: Cleanup of AdElementListModel constructor
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12667
To unsubscribe, visi
Michael Kublin has posted comments on this change.
Change subject: core: Authentication error messages on the engine.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12828
To unsubscribe, vi
Eli Mesika has posted comments on this change.
Change subject: engine: Manage Gluster hooks support
..
Patch Set 23: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10650
To unsubscribe
Alexander Wels has posted comments on this change.
Change subject: webadmin: double click invokes default command
..
Patch Set 7: Verified
And some trailing white space...
--
To view, visit http://gerrit.ovirt.org/10640
To uns
Alexander Wels has posted comments on this change.
Change subject: webadmin: double click invokes default command
..
Patch Set 6: Verified
Updated javadoc to make intentions of the getDefaultCommand more clear.
--
To view, vis
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Clean-up for AbstractVmPopupWidget.ui.xml
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/127
Yair Zaslavsky has submitted this change and it was merged.
Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd
service"
..
Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd service"
Thi
Yair Zaslavsky has posted comments on this change.
Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd
service"
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ov
Yair Zaslavsky has posted comments on this change.
Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd
service"
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ov
Eli Mesika has reverted this change.
Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd
service"
..
Patch Set 2: Reverted
This patchset was reverted in change: Iee79b36e1aece45fe3dc15f3b164f1cbaf892
Alexander Wels has posted comments on this change.
Change subject: webadmin: double click invokes default command
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/m
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin,userportal: red border for invalid widgets
..
webadmin,userportal: red border for invalid widgets
Color invalid widgets in red (instead of orange
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: red border for invalid widgets
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12584
To unsubsc
1 - 100 of 204 matches
Mail list logo