[Engine-patches] Change in ovirt-engine[master]: engine: Manage Gluster hooks support

2013-03-07 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Manage Gluster hooks support .. Patch Set 23: Looks good to me, approved Please rebase -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: webadmin: System permissions tab don't update

2013-03-07 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: System permissions tab don't update .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12866 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: engine: Manage Gluster hooks support

2013-03-07 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: Manage Gluster hooks support .. Patch Set 23: Verified -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: build: solve m2e manifest problems

2013-03-07 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: build: solve m2e manifest problems .. Patch Set 1: I don't have any intelligent to write as I have never used eclipse... but looks great! -- To view, visit http

[Engine-patches] Change in ovirt-engine[master]: build: remove double definition of test-jar-plugin.version

2013-03-07 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: build: remove double definition of test-jar-plugin.version .. Patch Set 1: Verified (1 inline comment) Fil

[Engine-patches] Change in ovirt-engine[master]: build: solve m2e manifest problems

2013-03-07 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: build: solve m2e manifest problems .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12870 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: build: remove double definition of test-jar-plugin.version

2013-03-07 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: build: remove double definition of test-jar-plugin.version .. build: remove double definition of test-jar-plugin.version Change-Id: I7aaaf5c04bf80ca5848759f3a0

[Engine-patches] Change in ovirt-engine[master]: build: solve m2e manifest problems

2013-03-07 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: build: solve m2e manifest problems .. build: solve m2e manifest problems The m2e plugin for Eclipse IDE that many developers use is incompatible with the cutti

[Engine-patches] Change in ovirt-engine[master]: webadmin: TreeTable no items to display

2013-03-07 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: webadmin: TreeTable no items to display .. webadmin: TreeTable no items to display - Added 'No XX to Display' to tree tables. Where XX is the appropriate

[Engine-patches] Change in ovirt-engine[master]: webadmin: TreeTable no items to display

2013-03-07 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: TreeTable no items to display .. Patch Set 4: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/12738 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: System permissions tab don't update

2013-03-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: System permissions tab don't update .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/12866 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: provided cleared frontend logging

2013-03-07 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: core: provided cleared frontend logging .. Patch Set 3: (1 inline comment) File backend/manager/modules/commo

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Decouple AspectJ config from gwt-plugin...

2013-03-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin,userportal: Decouple AspectJ config from gwt-plugin.extraJvmArgs .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Improve form-based sub tabs

2013-03-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12325

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3686 - Fixed!

2013-03-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3686/ Build Number: 3686 Build Status: Fixed Triggered By: Started by user eyal edri - Changes Since Last Success:

[Engine-patches] Change in ovirt-engine[master]: engine: connectStorageServer is not sent for inactive domain...

2013-03-07 Thread abaron
Ayal Baron has posted comments on this change. Change subject: engine: connectStorageServer is not sent for inactive domains before connectStoragePool .. Patch Set 2: I would prefer that you didn't submit this (6 inline commen

[Engine-patches] Change in ovirt-engine[master]: webadmin: System permissions tab don't update

2013-03-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: System permissions tab don't update .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12866 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: System permissions tab don't update

2013-03-07 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: webadmin: System permissions tab don't update .. webadmin: System permissions tab don't update System permissions tab doesnt update content on initialization and af

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3685 - Failure!

2013-03-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3685/ Build Number: 3685 Build Status: Failure Triggered By: Started by an SCM change, Started by an SCM change, Started by an SCM change

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Move the session cleaner interceptor to bll

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Move the session cleaner interceptor to bll .. core: Move the session cleaner interceptor to bll Commit 028ff6 moved the utils library to a JBoss module,

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: engine-setup - make firewall checking more robust

2013-03-07 Thread juan . hernandez
Hello Ofer Schreiber, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/12859 to review the following change. Change subject: packaging: engine-setup - make firewall checking more robust .. packaging:

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Move passwd encryption script to tools

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Move passwd encryption script to tools .. packaging: Move passwd encryption script to tools This script used to be in the PKI directory, but it is a

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Use Id=... to check systemd services

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Use Id=... to check systemd services .. packaging: Use Id=... to check systemd services The services managed by systemd can have an unique identifie

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Try nfs and nfs-server

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Try nfs and nfs-server .. packaging: Try nfs and nfs-server When configuring the NFS service we need to try with both names, as some distributions u

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Add commons-collections to the dal module

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Add commons-collections to the dal module .. core: Add commons-collections to the dal module Commit 81742e created a module for the DAL, but it is missin

[Engine-patches] Change in ovirt-engine[engine_3.2]: restapi: Use context classloader from YAML

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: restapi: Use context classloader from YAML .. restapi: Use context classloader from YAML The YAML library that we use to build load the RSDL metadata assumes t

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Conditionally use systemd and System V

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Conditionally use systemd and System V .. packaging: Conditionally use systemd and System V This change introduces two new "install_systemd" and "in

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Prepare for el6 build

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Prepare for el6 build .. packaging: Prepare for el6 build Change the value of macros to build the package for el6 distributions, remove the maven de

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Add JBoss modules for libraries

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Add JBoss modules for libraries .. core: Add JBoss modules for libraries This patch creates JBoss modules for the common, compat, dal, utils, tooks and s

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Add beanutils as dependency of utils

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Add beanutils as dependency of utils .. packaging: Add beanutils as dependency of utils This is needed by the OVF related code. Change-Id: I370c88f

[Engine-patches] Change in ovirt-engine[engine_3.2]: tools: Use JBoss modules instead of class path

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: tools: Use JBoss modules instead of class path .. tools: Use JBoss modules instead of class path Currently in order to run the tools we build the class path us

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Add jxpath as commons-configuration dep

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Add jxpath as commons-configuration dep .. core: Add jxpath as commons-configuration dep The commons-configuration module provided by JBoss AS doesn't in

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Move dependencies to a JBoss module

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Move dependencies to a JBoss module .. packaging: Move dependencies to a JBoss module Currently we package dependencies as .jar files in the lib dir

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Don't resolve plugins

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Don't resolve plugins .. packaging: Don't resolve plugins Now that we have a plugin in the project that is required for the build (the jboss modules

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Create artifact for PostgreSQL module

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Create artifact for PostgreSQL module .. core: Create artifact for PostgreSQL module Currently we are deploying the PostgreSQL module using the "setup" p

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Make explicit version of maven ear plugin

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Make explicit version of maven ear plugin .. core: Make explicit version of maven ear plugin Currently we don't explicitly specify the version of the mav

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Make antrun plugin version explicit

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Make antrun plugin version explicit .. core: Make antrun plugin version explicit Currently we don't explicitly specify the version of the maven ant plugi

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Maven plugin to generate JBoss modules

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Maven plugin to generate JBoss modules .. core: Maven plugin to generate JBoss modules This change introduces a new maven plugin that generates .zip file

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Make explicit version of maven war plugin

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Make explicit version of maven war plugin .. core: Make explicit version of maven war plugin Currently we don't explicitly specify the version of the mav

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Don't use commons collections clone method

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Don't use commons collections clone method .. core: Don't use commons collections clone method The commons collections package provides a mechanism to cl

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Remove Encr?ptionManagerMessages

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Remove Encr?ptionManagerMessages .. core: Remove Encr?ptionManagerMessages There are two classes with this name, one with "y" and one with "i". None of t

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Move encryption utilities to utils

2013-03-07 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Move encryption utilities to utils .. core: Move encryption utilities to utils We have only two utility classes in the engineencryptutils project, and th

[Engine-patches] Change in ovirt-engine[engine_3.2]: tools: Consolidate all tools to single project

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: tools: Consolidate all tools to single project .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12642 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Remove Encr?ptionManagerMessages

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Remove Encr?ptionManagerMessages .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12643 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Move encryption utilities to utils

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Move encryption utilities to utils .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12644 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Don't use commons collections clone method

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Don't use commons collections clone method .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12645 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Make explicit version of maven ear plugin

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Make explicit version of maven ear plugin .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12646 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Make antrun plugin version explicit

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Make antrun plugin version explicit .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12647 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Make explicit version of maven war plugin

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Make explicit version of maven war plugin .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12648 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Maven plugin to generate JBoss modules

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Maven plugin to generate JBoss modules .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12649 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Create artifact for PostgreSQL module

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Create artifact for PostgreSQL module .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12650 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Move dependencies to a JBoss module

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: packaging: Move dependencies to a JBoss module .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12651 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Add JBoss modules for libraries

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Add JBoss modules for libraries .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12652 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Add jxpath as commons-configuration dep

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Add jxpath as commons-configuration dep .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12653 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[engine_3.2]: tools: Use JBoss modules instead of class path

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: tools: Use JBoss modules instead of class path .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12654 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Add beanutils as dependency of utils

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: packaging: Add beanutils as dependency of utils .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12655 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Move the session cleaner interceptor to bll

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Move the session cleaner interceptor to bll .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12656 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Don't resolve plugins

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: packaging: Don't resolve plugins .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[engine_3.2]: restapi: Use context classloader from YAML

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: restapi: Use context classloader from YAML .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12658 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Add commons-collections to the dal module

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Add commons-collections to the dal module .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12659 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: engine-setup - make firewall checking more robust

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: packaging: engine-setup - make firewall checking more robust .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12660 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Move passwd encryption script to tools

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: packaging: Move passwd encryption script to tools .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12662 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Changes required for el6

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: packaging: Changes required for el6 .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12663 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[engine_3.2]: core: Removed the ResXResourceReader class

2013-03-07 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: core: Removed the ResXResourceReader class .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/12661 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: webadmin: TreeTable no items to display

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: TreeTable no items to display .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12738 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Ping command success message need to be rephrased(#9187...

2013-03-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: cli: Ping command success message need to be rephrased(#918749) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12840 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Ping command success message need to be rephrased(#9187...

2013-03-07 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: cli: Ping command success message need to be rephrased(#918749) .. cli: Ping command success message need to be rephrased(#918749) ovirt-shell ping success message

[Engine-patches] Change in ovirt-engine[master]: core: fixing Materialized Views function signatures

2013-03-07 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fixing Materialized Views function signatures .. core: fixing Materialized Views function signatures Adding missing signatures and fixing some th

[Engine-patches] Change in ovirt-engine[master]: core: fixing Materialized Views function signatures

2013-03-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fixing Materialized Views function signatures .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12041 To unsu

[Engine-patches] Change in ovirt-engine[master]: core: fixing Materialized Views function signatures

2013-03-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fixing Materialized Views function signatures .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12041 To unsu

[Engine-patches] Change in ovirt-engine[master]: webadmin: TreeTable no items to display

2013-03-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: TreeTable no items to display .. Patch Set 3: (1 inline comment) File frontend/webadmin/modules/

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: replaced dialog error icon

2013-03-07 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: replaced dialog error icon .. webadmin,userportal: replaced dialog error icon Replaced error dialog 'X' icon with '!' icon. Change-I

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: replaced dialog error icon

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin,userportal: replaced dialog error icon .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12684 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: replaced close dialog icon

2013-03-07 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: replaced close dialog icon .. webadmin,userportal: replaced close dialog icon Replaced the close dialog 'X' icon. Change-Id: I0475b1

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: replaced close dialog icon

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin,userportal: replaced close dialog icon .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12683 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: webadmin: Storage dialog - fix description width

2013-03-07 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Storage dialog - fix description width .. webadmin: Storage dialog - fix description width Storage dialog - fix the width of description field (

[Engine-patches] Change in ovirt-engine[master]: webadmin: Storage dialog - fix description width

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Storage dialog - fix description width .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12585 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: remove duplicate event on successful hibernation

2013-03-07 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: remove duplicate event on successful hibernation .. core: remove duplicate event on successful hibernation Successful hibernating (suspending) VM resulted in

[Engine-patches] Change in ovirt-engine[master]: webadmin: TreeTable no items to display

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: TreeTable no items to display .. Patch Set 3: (1 inline comment) File frontend/webadmin/modules/web

[Engine-patches] Change in ovirt-engine[master]: webadmin: TreeTable no items to display

2013-03-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: TreeTable no items to display .. Patch Set 3: Added cast check. -- To view, visit http://gerrit.ovirt.org/12738 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Authentication error messages on the engine.

2013-03-07 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core: Authentication error messages on the engine. .. core: Authentication error messages on the engine. Authentication error messages on the engine.log sh

[Engine-patches] Change in ovirt-engine[master]: core: Authentication error messages on the engine.

2013-03-07 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Authentication error messages on the engine. .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12828 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core: Authentication error messages on the engine.

2013-03-07 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Authentication error messages on the engine. .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12828 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Builders infrastructure

2013-03-07 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: userportal,webadmin: Builders infrastructure .. Patch Set 9: 1) we can add a new method to the RpcService we have client logic there 'on server side', sth like

[Engine-patches] Change in ovirt-engine[master]: webadmin: double click invokes default command

2013-03-07 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: double click invokes default command .. webadmin: double click invokes default command - Added code to allow double click to invoke the default

[Engine-patches] Change in ovirt-engine[master]: webadmin: double click invokes default command

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: double click invokes default command .. Patch Set 8: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10640 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: webadmin: double click invokes default command

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: double click invokes default command .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10640 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: webadmin: Cleanup of AdElementListModel constructor

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Cleanup of AdElementListModel constructor .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12667 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Authentication error messages on the engine.

2013-03-07 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Authentication error messages on the engine. .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12828 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: Manage Gluster hooks support

2013-03-07 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: Manage Gluster hooks support .. Patch Set 23: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: webadmin: double click invokes default command

2013-03-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: double click invokes default command .. Patch Set 7: Verified And some trailing white space... -- To view, visit http://gerrit.ovirt.org/10640 To uns

[Engine-patches] Change in ovirt-engine[master]: webadmin: double click invokes default command

2013-03-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: double click invokes default command .. Patch Set 6: Verified Updated javadoc to make intentions of the getDefaultCommand more clear. -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: webadmin: Clean-up for AbstractVmPopupWidget.ui.xml

2013-03-07 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Clean-up for AbstractVmPopupWidget.ui.xml .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/127

[Engine-patches] Change in ovirt-engine[master]: Revert "core:Upgrade - Error Can't start the ovirt-engine-dw...

2013-03-07 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd service" .. Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd service" Thi

[Engine-patches] Change in ovirt-engine[master]: Revert "core:Upgrade - Error Can't start the ovirt-engine-dw...

2013-03-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd service" .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: Revert "core:Upgrade - Error Can't start the ovirt-engine-dw...

2013-03-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd service" .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: Revert "core:Upgrade - Error Can't start the ovirt-engine-dw...

2013-03-07 Thread emesika
Eli Mesika has reverted this change. Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd service" .. Patch Set 2: Reverted This patchset was reverted in change: Iee79b36e1aece45fe3dc15f3b164f1cbaf892

[Engine-patches] Change in ovirt-engine[master]: webadmin: double click invokes default command

2013-03-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: double click invokes default command .. Patch Set 2: (1 inline comment) File frontend/webadmin/m

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: red border for invalid widgets

2013-03-07 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: red border for invalid widgets .. webadmin,userportal: red border for invalid widgets Color invalid widgets in red (instead of orange

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: red border for invalid widgets

2013-03-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin,userportal: red border for invalid widgets .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12584 To unsubsc

  1   2   3   >