Allon Mureinik has uploaded a new change for review.

Change subject: build: solve m2e manifest problems
......................................................................

build: solve m2e manifest problems

The m2e plugin for Eclipse IDE that many developers use is incompatible
with the cutting edge manifest-related maven plugins.

This patch locks down the version of the maven-war-plugin (to 2.1.1) and
maven-ear-plugin (to 2.6), so that Eclipse can import the project with
not problems.

Change-Id: Ib678e50b9403ae16415f5e10fb8f1e9a58d77661
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M ear/pom.xml
M pom.xml
4 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/70/12870/1

diff --git a/backend/manager/modules/restapi/webapp/pom.xml 
b/backend/manager/modules/restapi/webapp/pom.xml
index 384ce2b..163d32b 100644
--- a/backend/manager/modules/restapi/webapp/pom.xml
+++ b/backend/manager/modules/restapi/webapp/pom.xml
@@ -32,6 +32,7 @@
     <plugins>
       <plugin>
         <artifactId>maven-war-plugin</artifactId>
+        <version>${maven-war-plugin.version}</version>
         <configuration>
 
           <!-- Add a the manifest that contains the required
diff --git a/backend/manager/modules/root/pom.xml 
b/backend/manager/modules/root/pom.xml
index cd22cf2..1d38cfb 100644
--- a/backend/manager/modules/root/pom.xml
+++ b/backend/manager/modules/root/pom.xml
@@ -67,6 +67,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-war-plugin</artifactId>
+        <version>${maven-war-plugin.version}</version>
         <configuration>
           <archive>
             <addMavenDescriptor>false</addMavenDescriptor>
diff --git a/ear/pom.xml b/ear/pom.xml
index 6dc83378..ed68f7a 100644
--- a/ear/pom.xml
+++ b/ear/pom.xml
@@ -153,6 +153,7 @@
     <plugins>
       <plugin>
         <artifactId>maven-ear-plugin</artifactId>
+        <version>${maven-ear-plugin.version}</version>
         <configuration>
           <!-- params common to ear:ear and ear:generate-application-xml -->
           <defaultLibBundleDir>lib</defaultLibBundleDir>
diff --git a/pom.xml b/pom.xml
index f13fad1..2f12425 100644
--- a/pom.xml
+++ b/pom.xml
@@ -88,6 +88,8 @@
     <maven-compiler-plugin.version>2.3.2</maven-compiler-plugin.version>
     <gwt.plugin.version>2.3.0</gwt.plugin.version>
     <test-jar.plugin.version>2.2</test-jar.plugin.version>
+    <maven-war-plugin.version>2.1.1</maven-war-plugin.version>
+    <maven-ear-plugin.version>2.6</maven-ear-plugin.version>
     <jboss-modules.plugin.version>1.0-SNAPSHOT</jboss-modules.plugin.version>
   </properties>
   <dependencyManagement>


--
To view, visit http://gerrit.ovirt.org/12870
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib678e50b9403ae16415f5e10fb8f1e9a58d77661
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to