[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3648 - Unstable!

2013-03-01 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3648/ Build Number: 3648 Build Status: Unstable Triggered By: Started by upstream project "ovirt_engine" build number 4,464, Started by upstream project "ovirt_engine" build n

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Replace static Driver init

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: Replace static Driver init .. Patch Set 1: Alex - thanks for the explanation, however I believe that Itamar referred to updating the git com

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Listener cleanup in UiCommandButtonDefi...

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin,userportal: Listener cleanup in UiCommandButtonDefinition .. Patch Set 1: Vojtech - please note that patch http://gerrit.ovirt.org/#/c/11975/ (merged) e

[Engine-patches] Change in ovirt-engine[master]: userportal: Fix UI update for Basic list item

2013-03-01 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: Fix UI update for Basic list item .. userportal: Fix UI update for Basic list item Since MainTabBasicListItemPresenterWidget is bound as non-s

[Engine-patches] Change in ovirt-engine[master]: userportal: fix memory leaks

2013-03-01 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: fix memory leaks .. userportal: fix memory leaks - Fixed a memory leak in user portal extended tab - Fixed a memory leak in user portal basic

[Engine-patches] Change in ovirt-engine[master]: userportal: Set default VM/Pool refresh rate to 30s for IE8

2013-03-01 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: Set default VM/Pool refresh rate to 30s for IE8 .. userportal: Set default VM/Pool refresh rate to 30s for IE8 For IE8 and below, default refr

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimization fixes

2013-03-01 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: Optimization fixes .. userportal: Optimization fixes 1. Fixed a problem when Basic view item selection was not retained after subsequent da

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize basic view

2013-03-01 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: Optimize basic view .. userportal: Optimize basic view 1. Fixed VmPool.equals method 2. Added UserPortalItemModel.entityStateEqualTo method

[Engine-patches] Change in ovirt-engine[master]: userportal: stop basic list provider on extended tab

2013-03-01 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: stop basic list provider on extended tab .. userportal: stop basic list provider on extended tab - Modified how listener is attached - Fix Use

[Engine-patches] Change in ovirt-engine[master]: userportal: fix memory leak when VM selected

2013-03-01 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: fix memory leak when VM selected .. userportal: fix memory leak when VM selected - Fixed a slow memory leak when selecting a VM. Change-Id: I

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize extended view VM/Pool grid

2013-03-01 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: Optimize extended view VM/Pool grid .. userportal: Optimize extended view VM/Pool grid This patch applies the original optimization logic to b

[Engine-patches] Change in ovirt-engine[master]: userportal: fix memory leaks

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: fix memory leaks .. Patch Set 21: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/11975 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: userportal: stop basic list provider on extended tab

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: stop basic list provider on extended tab .. Patch Set 14: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/12104

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize basic view

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: Optimize basic view .. Patch Set 18: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/10509 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize extended view VM/Pool grid

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: Optimize extended view VM/Pool grid .. Patch Set 16: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/10579 To u

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimization fixes

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: Optimization fixes .. Patch Set 10: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/12213 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: userportal: fix memory leak when VM selected

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: fix memory leak when VM selected .. Patch Set 14: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/12301 To unsu

[Engine-patches] Change in ovirt-engine[master]: userportal: Set default VM/Pool refresh rate to 30s for IE8

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: Set default VM/Pool refresh rate to 30s for IE8 .. Patch Set 11: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: userportal: Fix UI update for Basic list item

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: Fix UI update for Basic list item .. Patch Set 4: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/12524 To unsu

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Replace static Driver init

2013-03-01 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: Replace static Driver init .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12560

[Engine-patches] Change in ovirt-engine[master]: engine : Refactoring Async tasks code

2013-03-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Refactoring Async tasks code .. Patch Set 2: Verified Started moving code around. Getting started on first step. -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: engine : Refactoring Async tasks code

2013-03-01 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: engine : Refactoring Async tasks code .. engine : Refactoring Async tasks code Change-Id: Ie3839ed09825f1e0db914f55f5ee358b6b3c0449 Signed-off-by: Ravi Nori --- M

[Engine-patches] Change in ovirt-engine[master]: webadmin: bookmarks appear without scroll

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: bookmarks appear without scroll .. Patch Set 1: Another really small change that should be easy to review. No actions on this for over 30 days now.

[Engine-patches] Change in ovirt-engine[master]: webadmin: escape during dialog loading causes problems.

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: escape during dialog loading causes problems. .. Patch Set 1: This should be an easy review, just one line change. Can someone please review it and a

[Engine-patches] Change in ovirt-engine[master]: webadmin: grids jump to last selected entity

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: grids jump to last selected entity .. Patch Set 1: I need someone to review this so we can merge it. This has been untouched for well over a month no

[Engine-patches] Change in ovirt-engine[master]: webadmin: double click invokes default command

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: double click invokes default command .. Patch Set 2: I need someone to review this code so we can merge it. It has been here untouched for well over

[Engine-patches] Change in ovirt-engine[master]: core: provided cleared frontend logging

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: core: provided cleared frontend logging .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12559 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core: provided cleared frontend logging

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: core: provided cleared frontend logging .. Patch Set 1: (1 inline comment) File frontend/webadmin/modules/

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: i18n splash screen.

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: core, webadmin: i18n splash screen. .. Patch Set 12: Verified Added comment on the servlet, as well as addressed the spacing issues. -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: i18n splash screen.

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: core, webadmin: i18n splash screen. .. Patch Set 11: Verified (1 inline comment) File backend/manager/modu

[Engine-patches] Change in ovirt-engine[master]: userportal: Fix UI update for Basic list item

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: Fix UI update for Basic list item .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/12524 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: userportal: Set default VM/Pool refresh rate to 30s for IE8

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: Set default VM/Pool refresh rate to 30s for IE8 .. Patch Set 10: Verified -- To view, visit http://gerrit.ovirt.org/12340 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimization fixes

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: Optimization fixes .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/12213 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize extended view VM/Pool grid

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: Optimize extended view VM/Pool grid .. Patch Set 15: Verified -- To view, visit http://gerrit.ovirt.org/10579 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize basic view

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: Optimize basic view .. Patch Set 17: Verified -- To view, visit http://gerrit.ovirt.org/10509 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Replace static Driver init

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: Replace static Driver init .. Patch Set 1: Good point. The reason I am doing this is that Driver is stateful (it displays data from objec

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Replace static Driver init

2013-03-01 Thread iheim
Itamar Heim has posted comments on this change. Change subject: userportal, webadmin: Replace static Driver init .. Patch Set 1: I'd specify in the comment why this would be a good thing -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Replace static Driver init

2013-03-01 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: Replace static Driver init .. Patch Set 1: Verified Replaced all static initialization from: interface Driver extends SimpleBeanEditorDri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Wrong error on decreasing data center compatibilit...

2013-03-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: Wrong error on decreasing data center compatibility version .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12464 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: provided cleared frontend logging

2013-03-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: core: provided cleared frontend logging .. Patch Set 1: (1 inline comment) - adding an engine-core maintainer to review changes in common entities. - please note

[Engine-patches] Change in ovirt-engine[master]: frontend: VM Linux Boot options aren't parsing properly

2013-03-01 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: frontend: VM Linux Boot options aren't parsing properly .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12494 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: frontend: VM Linux Boot options aren't parsing properly

2013-03-01 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: frontend: VM Linux Boot options aren't parsing properly .. Patch Set 1: (4 inline comments) Commit Message Li

[Engine-patches] Change in ovirt-engine[master]: engine: Manage Gluster hooks support

2013-03-01 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: Manage Gluster hooks support .. Patch Set 20: (10 inline comments) File backend/manager/dbscripts/gl

[Engine-patches] Change in ovirt-engine[master]: core: provided cleared frontend logging

2013-03-01 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: core: provided cleared frontend logging .. core: provided cleared frontend logging - Added code to display better debug messages for -- RunQuery -- RunPublicQu

[Engine-patches] Change in ovirt-engine[master]: core: clean up businessentity hashCode() methods [part 1]

2013-03-01 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core: clean up businessentity hashCode() methods [part 1] .. Patch Set 1: hashCode() shouldn't return a different hash for two objects that are the same accordin

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix gluster cluster selection in host dialog

2013-03-01 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Fix gluster cluster selection in host dialog .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12549 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: clean up businessentity hashCode() methods [part 1]

2013-03-01 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: clean up businessentity hashCode() methods [part 1] .. Patch Set 1: why we need to implement hashCode() everywhere? -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: engine: Manage Gluster hooks support

2013-03-01 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Manage Gluster hooks support .. Patch Set 20: (15 inline comments) File backend/manager/dbscripts/g

[Engine-patches] Change in ovirt-engine[master]: frontend: Non-plugin automatic invocation of console session

2013-03-01 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Non-plugin automatic invocation of console session .. frontend: Non-plugin automatic invocation of console session This patch adds a native wa

[Engine-patches] Change in ovirt-engine[master]: frontend: Non-plugin automatic invocation of console session

2013-03-01 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: frontend: Non-plugin automatic invocation of console session .. Patch Set 12: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11703 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session

2013-03-01 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: core: Non-plugin automatic invocation of console session .. core: Non-plugin automatic invocation of console session This patch adds a native way of con

[Engine-patches] Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session

2013-03-01 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: Non-plugin automatic invocation of console session .. Patch Set 12: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11702 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core:SPM role should not be granted to Gluster only nodes

2013-03-01 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: core:SPM role should not be granted to Gluster only nodes .. Patch Set 2: Looks good to me, but someone else must approve Needs Eli's approval as it's a DB patc

[Engine-patches] Change in ovirt-engine[master]: frontend: Non-plugin automatic invocation of console session

2013-03-01 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: frontend: Non-plugin automatic invocation of console session .. Patch Set 12: Verified -- To view, visit http://gerrit.ovirt.org/11703 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session

2013-03-01 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: core: Non-plugin automatic invocation of console session .. Patch Set 12: Verified -- To view, visit http://gerrit.ovirt.org/11702 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: engine: Manage Gluster hooks support

2013-03-01 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: engine: Manage Gluster hooks support .. Patch Set 20: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10650 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: Trusted Compute Pools - Open Attestation integration with oV...

2013-03-01 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: Trusted Compute Pools - Open Attestation integration with oVirt engine proposal .. Patch Set 3: (12 inline comments) Thanks for the change to use commons-httpc

[Engine-patches] Change in ovirt-engine[master]: core:SPM role should not be granted to Gluster only nodes

2013-03-01 Thread sabose
Sahina Bose has uploaded a new change for review. Change subject: core:SPM role should not be granted to Gluster only nodes .. core:SPM role should not be granted to Gluster only nodes In a DC with gluster cluster and vdsm clust

[Engine-patches] Change in ovirt-engine[master]: core:Upgrade from 3.1 to 3.2 fails

2013-03-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core:Upgrade from 3.1 to 3.2 fails .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12551 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core:Upgrade from 3.1 to 3.2 fails

2013-03-01 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core:Upgrade from 3.1 to 3.2 fails .. core:Upgrade from 3.1 to 3.2 fails Upgrade failed on 3.1.3 to 3.2 on both PG 8.4.x and 9.x On 8.4.x : Problem was that atte