Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: Replace static Driver init ......................................................................
Patch Set 1: Good point. The reason I am doing this is that Driver is stateful (it displays data from objects). Static invocation is by definition stateless. So doing static invocation of a stateful object will lead to problems. In our case the problem arose in the user portal when we did some optimizations and values were not updating. The object that last called initialize on the static Driver was not the object we were displaying, so our data was not being updated properly. This patch addresses all those issues (yes we were doing it wrong in a LOT of places). -- To view, visit http://gerrit.ovirt.org/12560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73ba1fa29629538d6160fa042113859a6bf1ae7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
