[Engine-patches] Change in ovirt-engine[master]: userportal: stop basic list provider on extended tab

2013-02-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal: stop basic list provider on extended tab .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12104 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize basic view

2013-02-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal: Optimize basic view .. Patch Set 13: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10509 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Upgrade maven-checkstyle-plugin to 2.9.1

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: Upgrade maven-checkstyle-plugin to 2.9.1 .. Patch Set 3: Looks good to me, but someone else must approve Hi Allon! Any news with this patch? (changing my

[Engine-patches] Change in ovirt-engine[master]: userportal: optimization fixes.

2013-02-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: optimization fixes. .. Patch Set 5: The patch removes methods added in the previous patch (http://gerrit.ovirt.org/#/c/12213/). Would be clearer if yo

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize extended view VM/Pool grid

2013-02-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal: Optimize extended view VM/Pool grid .. Patch Set 11: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10579 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimization fixes

2013-02-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: Optimization fixes .. Patch Set 6: (1 inline comment) File frontend/webadmin/modules/uicommonweb/

[Engine-patches] Change in ovirt-engine[master]: restapi: trace export template command by job status

2013-02-25 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: restapi: trace export template command by job status .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12432 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimization fixes

2013-02-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal: Optimization fixes .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12213 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: userportal: optimization fixes.

2013-02-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal: optimization fixes. .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12245 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: restapi: trace export template command by job status

2013-02-25 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: restapi: trace export template command by job status .. restapi: trace export template command by job status This patch prevents a situation in which the REST repo

[Engine-patches] Change in ovirt-engine[master]: userportal: fix memory leak when VM selected

2013-02-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal: fix memory leak when VM selected .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12301 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Don't let quartz call home for updates

2013-02-25 Thread lhornyak
Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Don't let quartz call home for updates .. core: Don't let quartz call home for updates The quartz scheduler connects to its web site to check for

[Engine-patches] Change in ovirt-engine[master]: core: Don't let quartz call home for updates

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: Don't let quartz call home for updates .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12411 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor GlusterQueriesCommand Base

2013-02-25 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: Refactor GlusterQueriesCommand Base .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12398 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: userportal: Set default refresh rate to 30s

2013-02-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: Set default refresh rate to 30s .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12340 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: LSM - standardize version checks in CDA

2013-02-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: LSM - standardize version checks in CDA .. Patch Set 2: (1 inline comment) File frontend/webadmin/modul

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor GlusterQueriesCommand Base

2013-02-25 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: Refactor GlusterQueriesCommand Base .. Patch Set 1: (1 inline comment) File backend/manager/modules/b

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: translations update

2013-02-25 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: webadmin, userportal: translations update .. webadmin, userportal: translations update pulled translation from Zanata oVirt project, master version. Chan

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: translations update

2013-02-25 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin, userportal: translations update .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/12111 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Remove CompatException class and it's usages

2013-02-25 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: Remove CompatException class and it's usages .. core: Remove CompatException class and it's usages Change-Id: I726e0f9e7fb0c9bff00b8d510dc3907d202e0fa2 Signed

[Engine-patches] Change in ovirt-engine[master]: core: Remove Path class from Compat module

2013-02-25 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: Remove Path class from Compat module .. core: Remove Path class from Compat module Removed the Path class from the Compat module Change-Id: I2a4a1e051050196d

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog support [wip]

2013-02-25 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: engine: watchdog support [wip] .. Patch Set 1: Looks pretty good so far. (I'm amazed at the number of places that VM parameters have to be propagated.) One que

[Engine-patches] Change in ovirt-engine[master]: tools : Unable to add remote domain using engine-manage-doma...

2013-02-25 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools : Unable to add remote domain using engine-manage-domains .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12428 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: tools : Unable to add remote domain using engine-manage-doma...

2013-02-25 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: tools : Unable to add remote domain using engine-manage-domains .. tools : Unable to add remote domain using engine-manage-domains When there is an error with engin

[Engine-patches] Change in ovirt-engine[master]: webadmin: Update storage pop view to add Gluster FS.

2013-02-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Update storage pop view to add Gluster FS. .. Patch Set 14: (4 inline comments) File frontend/webad

[Engine-patches] Change in ovirt-engine[master]: restapi : Creating template by specifing vm name, does not w...

2013-02-25 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : Creating template by specifing vm name, does not work (#915285) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12426 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: restapi : Creating template by specifing vm name, does not w...

2013-02-25 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: restapi : Creating template by specifing vm name, does not work (#915285) .. restapi : Creating template by specifing vm name, does not work (#915285) Creating tem

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Added caching

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: Added caching .. Patch Set 14: Verified; No score -- To view, visit http://gerrit.ovirt.org/10449 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: userportal: refresh icon not fully visible

2013-02-25 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal: refresh icon not fully visible .. userportal: refresh icon not fully visible - Fixed the refresh icon not being fully visible in the user port

[Engine-patches] Change in ovirt-engine[master]: userportal: refresh icon not fully visible

2013-02-25 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: refresh icon not fully visible .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/12415 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: userportal: refresh icon not fully visible

2013-02-25 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: refresh icon not fully visible .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12415 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: userportal: refresh icon not fully visible

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: refresh icon not fully visible .. Patch Set 1: Verified; Looks good to me, but someone else must approve Yes I verified in IE8 and FF and Chrome tha

[Engine-patches] Change in ovirt-engine[master]: userportal: refresh icon not fully visible

2013-02-25 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: refresh icon not fully visible .. Patch Set 1: verified that everything stayed intact in chrome and firefox: Firefox Extended: http://i47.tinypic.com/

[Engine-patches] Change in ovirt-engine[master]: core: Remove FileUtil unneeded methods

2013-02-25 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: Remove FileUtil unneeded methods .. core: Remove FileUtil unneeded methods Remove the FileUtil unused methods and replace the ones used to standard implementa

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Added caching

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: Added caching .. Patch Set 14: Looks good to me, but someone else must approve Renamed frontend-overlay to frontend-fragment to better den

[Engine-patches] Change in ovirt-engine[master]: core: Remove the Helper class

2013-02-25 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Remove the Helper class .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12422 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringCompatTest

2013-02-25 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Remove StringCompatTest .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12423 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12416 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 2: - added the missing properties for Gilad's request - added special equals method (Object

[Engine-patches] Change in ovirt-engine[master]: restapi : RSDL lists host display address as mandatory(#9150...

2013-02-25 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : RSDL lists host display address as mandatory(#915066) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12424 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: restapi : RSDL lists host display address as mandatory(#9150...

2013-02-25 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: restapi : RSDL lists host display address as mandatory(#915066) .. restapi : RSDL lists host display address as mandatory(#915066) Host display address is listed as

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 1: (1 inline comment) File backend/ma

[Engine-patches] Change in ovirt-engine[master]: core:Add Data Center event message is missing ...

2013-02-25 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core:Add Data Center event message is missing ... .. core:Add Data Center event message is missing ... Add Data Center event message is missing important p

[Engine-patches] Change in ovirt-engine[master]: core:Add Data Center event message is missing ...

2013-02-25 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core:Add Data Center event message is missing ... .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12399 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 1: Please check again, it seems the change VdsStatistics broke a unit test -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: core:we are fencing a host when putting it in ...

2013-02-25 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core:we are fencing a host when putting it in ... .. core:we are fencing a host when putting it in ... we are fencing a host when putting it in maintenance

[Engine-patches] Change in ovirt-engine[master]: core:we are fencing a host when putting it in ...

2013-02-25 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core:we are fencing a host when putting it in ... .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12284 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Remove the Helper class

2013-02-25 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: Remove the Helper class .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12422 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringCompatTest

2013-02-25 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: Remove StringCompatTest .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12423 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 1: Allon - thanks, other patch abandoned. From email (for others' visibility) leaving the "

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringCompatTest

2013-02-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove StringCompatTest .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12423 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread gpadgett
Greg Padgett has abandoned this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 1: Abandoned Squashed with part 3, now at http://gerrit.ovirt.org/12416 -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: Remove the Helper class

2013-02-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove the Helper class .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12422 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringCompatTest

2013-02-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Remove StringCompatTest .. core: Remove StringCompatTest StringCompatTest did not in fact test StringCompat (which was already removed), but StringHelper

[Engine-patches] Change in ovirt-engine[master]: core: Remove the Helper class

2013-02-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Remove the Helper class .. core: Remove the Helper class org.ovirt.engine.core.utils.Helper had only one method, ToList, which was, in fact, just creatin

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog support [wip]

2013-02-25 Thread lhornyak
Laszlo Hornyak has uploaded a new change for review. Change subject: engine: watchdog support [wip] .. engine: watchdog support [wip] Watchdog device support for the engine: - Backend logic to handle the new device - Frontend mo

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 1: Greg - please abandon http://gerrit.ovirt.org/#/c/12343/ and remove the "part 2" from t

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: backend: shorten message for PM test (#909891)

2013-02-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: backend: shorten message for PM test (#909891) .. Patch Set 2: (1 inline comment) File backend/manager/mod

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated psql calls not to ask password

2013-02-25 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: packaging: Updated psql calls not to ask password .. packaging: Updated psql calls not to ask password Currently we use our own pgpass file to supply the required

[Engine-patches] Change in ovirt-engine[master]: webadmin: add the image block alignment scan

2013-02-25 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: webadmin: add the image block alignment scan .. webadmin: add the image block alignment scan Change-Id: Idf3a80a73e6f30f75806736a77a76247c61250b4 Signed-o

[Engine-patches] Change in ovirt-engine[master]: webadmin: wrap tree item content

2013-02-25 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: wrap tree item content .. webadmin: wrap tree item content Bug-Url: http://bugzilla.redhat.com/911071 Change-Id: I03056eee90cee5f57b619d9513

[Engine-patches] Change in ovirt-engine[master]: webadmin: wrap tree item content

2013-02-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: webadmin: wrap tree item content .. Patch Set 6: Verified; Looks good to me, approved Merged per +2 by derez. -- To view, visit http://gerrit.ovirt.org/12397 T

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fixed network sorting in VM networks popup

2013-02-25 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Fixed network sorting in VM networks popup .. Patch Set 4: (1 inline comment) File frontend/webadm

[Engine-patches] Change in ovirt-engine[master]: webadmin: wrap tree item content (#911071)

2013-02-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: wrap tree item content (#911071) .. Patch Set 5: Looks good to me, approved (1 inline comment) Comm

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated order of services starting

2013-02-25 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: Updated order of services starting .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12405 To uns

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Use X-UA-Compatible with IE=edge

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin,userportal: Use X-UA-Compatible with IE=edge .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 3]

2013-02-25 Thread gpadgett
Greg Padgett has abandoned this change. Change subject: core: simplify businessentity equals() methods [part 3] .. Patch Set 1: Abandoned Squashed with part 2, now at http://gerrit.ovirt.org/12416 -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimization fixes

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: Optimization fixes .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12213 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 1]

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 1] .. Patch Set 1: (1 inline comment) File backend/ma

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]

2013-02-25 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 2] .. Patch Set 1: Verified Squashed parts 2 and 3 of prior patches (here: http://gerrit.ovirt.org/12343 and

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Listener cleanup in UiCommandButtonDefi...

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin,userportal: Listener cleanup in UiCommandButtonDefinition .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize extended view VM/Pool grid

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: Optimize extended view VM/Pool grid .. Patch Set 11: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10579

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize basic view

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal: Optimize basic view .. Patch Set 13: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10509 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: userportal: refresh icon not fully visible

2013-02-25 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: userportal: refresh icon not fully visible .. userportal: refresh icon not fully visible - Fixed the refresh icon not being fully visible in the user portal ba

[Engine-patches] Change in ovirt-engine[master]: core: Add commons-collections to the dal module

2013-02-25 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: core: Add commons-collections to the dal module .. core: Add commons-collections to the dal module Commit 81742e created a module for the DAL, but it i

[Engine-patches] Change in ovirt-engine[master]: core: Add commons-collections to the dal module

2013-02-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Add commons-collections to the dal module .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous ack and verification. -- To view

[Engine-patches] Change in ovirt-engine[master]: core: Add commons-collections to the dal module

2013-02-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Add commons-collections to the dal module .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12414 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 1]

2013-02-25 Thread lhornyak
Laszlo Hornyak has submitted this change and it was merged. Change subject: core: simplify businessentity equals() methods [part 1] .. core: simplify businessentity equals() methods [part 1] Instead of manually doing a null-saf

[Engine-patches] Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 1]

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 1] .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12342 To

[Engine-patches] Change in ovirt-engine[master]: core: Add commons-collections to the dal module

2013-02-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Add commons-collections to the dal module .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12414 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Add commons-collections to the dal module

2013-02-25 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Add commons-collections to the dal module .. core: Add commons-collections to the dal module Commit 81742e created a module for the DAL, but it is missin

[Engine-patches] Change in ovirt-engine[master]: packaging: open source like versioning scheme

2013-02-25 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: open source like versioning scheme .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12406

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated order of services starting

2013-02-25 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: Updated order of services starting .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12405

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fixed sorting of bonds in create bond popup

2013-02-25 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Fixed sorting of bonds in create bond popup .. Patch Set 4: (1 inline comment) File frontend/webad

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Guaranteed memory not propagated

2013-02-25 Thread lspevak
Libor Spevak has uploaded a new change for review. Change subject: userportal, webadmin: Guaranteed memory not propagated .. userportal, webadmin: Guaranteed memory not propagated Physical Memory Guaranteed parameter (min. alloc

[Engine-patches] Change in ovirt-engine[master]: packaging: validate MAC addresses range provided by the user

2013-02-25 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: validate MAC addresses range provided by the user .. Patch Set 4: Looks good to me, but someone else must approve Code looks good to me, please ver

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: defend against malformed server reply

2013-02-25 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: defend against malformed server reply .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12412 To unsubscrib

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: defend against malformed server reply

2013-02-25 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: defend against malformed server reply .. sdk: defend against malformed server reply Change-Id: I236863ab9fee7b5af43402f1beb055dc6ea0e39b Signed

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fixed NIC sorting in Setup Networks popup

2013-02-25 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Fixed NIC sorting in Setup Networks popup .. Patch Set 5: (1 inline comment) File frontend/webadmi

[Engine-patches] Change in ovirt-engine[master]: core: Don't let quartz call home for updates

2013-02-25 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: core: Don't let quartz call home for updates .. Patch Set 2: Verified; Looks good to me, approved works fine Btw it seems that newer versions of quartz need a

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: defend against malformed server reply

2013-02-25 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: defend against malformed server reply .. sdk: defend against malformed server reply Change-Id: I236863ab9fee7b5af43402f1beb055dc6ea0e39b Signed-off-by:

[Engine-patches] Change in ovirt-engine[master]: core: Don't let quartz call home for updates

2013-02-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Don't let quartz call home for updates .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12411 To un

[Engine-patches] Change in ovirt-engine[master]: core: Don't let quartz call home for updates

2013-02-25 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Don't let quartz call home for updates .. core: Don't let quartz call home for updates The quartz scheduler connects to its web site to check for updates

[Engine-patches] Change in ovirt-engine[master]: packaging: open source like versioning scheme

2013-02-25 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: open source like versioning scheme .. Patch Set 1: (3 inline comments) File Makefile Line 24: incl

[Engine-patches] Change in ovirt-engine[master]: webadmin: Rewrote arranging of NICs in Host/Networks subtab

2013-02-25 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: Rewrote arranging of NICs in Host/Networks subtab .. Patch Set 6: (1 inline comment) File frontend/

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Improve form-based sub tabs

2013-02-25 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: webadmin: cpu pinning visibility in vm dialog

2013-02-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: cpu pinning visibility in vm dialog .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11972 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: packaging: open source like versioning scheme

2013-02-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: open source like versioning scheme .. Patch Set 1: (3 inline comments) File Makefile Line 24: in

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Use X-UA-Compatible with IE=edge

2013-02-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin,userportal: Use X-UA-Compatible with IE=edge .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12215 To unsubscribe, vi

  1   2   3   >