Arik Hadas has uploaded a new change for review.

Change subject: restapi: trace export template command by job status
......................................................................

restapi: trace export template command by job status

This patch prevents a situation in which the REST reports that export
template command was finished before the end-action event is added.

This situation occured because the REST part monitored the command
according to the statuses of its VDSM tasks - when they were done,
it reports back to the user that the command has finished and gave
him back the control (the command was invoked synchronously),
sometimes before the engine managed to add the end-action event.

This patch change the way the export template command is monitored by
the REST to be according to the command's job status, that way we ensure
that the end-action event is added before REST is reporting back to the
user that the command is finished.

Change-Id: I4442b337e0242aa756825243dbcf6db1a2b0559f
Bug-Url: https://bugzilla.redhat.com/860194
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/12432/1

diff --git 
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
 
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
index 7ebac7a..416a9eb 100644
--- 
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
+++ 
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
@@ -65,7 +65,7 @@
             params.setForceOverride(true);
         }
 
-        return doAction(VdcActionType.ExportVmTemplate, params, action);
+        return doAction(VdcActionType.ExportVmTemplate, params, action, 
PollingType.JOB);
     }
 
     @Override


--
To view, visit http://gerrit.ovirt.org/12432
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4442b337e0242aa756825243dbcf6db1a2b0559f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to