liron aravot has posted comments on this change.
Change subject: core: TimeoutBase: Prevent updating mutable Date
..
Patch Set 2: No score
--
To view, visit http://gerrit.ovirt.org/11897
To unsubscribe, visit http://gerrit.ovir
Mike Kolesnik has posted comments on this change.
Change subject: core: Implemented Nameable in VmStatic
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/comm
Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactoring in unassign network from cluster command
..
Patch Set 3: (2 inline comments)
File
backe
Liron Aravot has posted comments on this change.
Change subject: core: TimeoutBase: Prevent updating mutable Date
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
..
Moti Asayag has posted comments on this change.
Change subject: engine: NetworkClusterValidator refactoring
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/b
Muli Salem has posted comments on this change.
Change subject: core: Allow Removal of Network on Host from DC
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11968
To unsubscribe,
Muli Salem has submitted this change and it was merged.
Change subject: core: Allow Removal of Network on Host from DC
..
core: Allow Removal of Network on Host from DC
This patch removes the canDoAction that checks
whether a n
Sahina Bose has posted comments on this change.
Change subject: webadmin: using search backend to find Up server in cluster
..
Patch Set 3: (1 inline comment)
Looks good. Minor comment inline
..
Roy Golan has posted comments on this change.
Change subject: core: patterned pool names support
..
Patch Set 2:
* please create a test to cover all of the above mentioned scenarios
* add documentation with examples on the reg
Kanagaraj M has posted comments on this change.
Change subject: webadmin: using search backend to find Up server in cluster
..
Patch Set 2: (1 inline comment)
New patch set to follow.
..
Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactored code into NetworkValidator class
..
Patch Set 10: (3 inline comments)
File
backend/manag
Sahina Bose has posted comments on this change.
Change subject: webadmin: using search backend to find Up server in cluster
..
Patch Set 2: (1 inline comment)
Can GetUpHostListByCluster be reused?
.
Kanagaraj M has abandoned this change.
Change subject: engine: get Up server by cluster query
..
Patch Set 2: Abandoned
Thanks Gilad, good point.
Abandoning this and a new patch has been sent to use the Search Backend.
http:/
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: using search backend to find Up server in cluster
..
webadmin: using search backend to find Up server in cluster
To find whether there are any host in U
Yair Zaslavsky has posted comments on this change.
Change subject: tools : manage-domains messages should be more clear
..
Patch Set 2: (1 inline comment)
One comment.
In general - I really liked your solution - it is more comp
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3505/
Build Number: 3505
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,281
-
Changes Since
Greg Padgett has posted comments on this change.
Change subject: webadmin: validation for "Use Host CPU" setting
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11994
To unsubscribe, visit http://gerrit.ovirt
Greg Padgett has uploaded a new change for review.
Change subject: webadmin: validation for "Use Host CPU" setting
..
webadmin: validation for "Use Host CPU" setting
To enable CPU Host, one of the two no-migrate flags for a VM (
Tal Nisan has posted comments on this change.
Change subject: core: TimeoutBase: Prevent updating mutable Date
..
Patch Set 2: Verified; Looks good to me, approved
Nice one!
--
To view, visit http://gerrit.ovirt.org/11897
To u
Tal Nisan has submitted this change and it was merged.
Change subject: core: Moved ui event related classes from compat
..
core: Moved ui event related classes from compat
Moved the ui event related classes that existed in the
Tal Nisan has posted comments on this change.
Change subject: core: Moved ui event related classes from compat
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11806
To unsubscribe,
Tal Nisan has submitted this change and it was merged.
Change subject: core: Adjust VM Failure message(#907900)
..
core: Adjust VM Failure message(#907900)
When creation of a snapshot fails due to VM state, a more informative
m
Tal Nisan has posted comments on this change.
Change subject: core: Adjust VM Failure message(#907900)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11991
To unsubscribe, visit h
Tal Nisan has posted comments on this change.
Change subject: core: Adjust VM Failure message(#907900)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11991
To unsubscribe, visit h
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Refactored import VM/Temaplate dialog
..
webadmin: Refactored import VM/Temaplate dialog
Refactored the import VM/Template dialog to let the clone
Tal Nisan has posted comments on this change.
Change subject: webadmin: Refactored import VM/Temaplate dialog
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10828
To unsubscribe,
Moti Asayag has submitted this change and it was merged.
Change subject: tools: error in engine-notifierd init script
..
tools: error in engine-notifierd init script
When starting the notification service, the init script calls
Moti Asayag has posted comments on this change.
Change subject: tools: error in engine-notifierd init script
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11821
To unsubscribe, v
Moti Asayag has posted comments on this change.
Change subject: tools: error in engine-notifierd init script
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11821
To unsubscribe, visit http:
liron aravot has posted comments on this change.
Change subject: core: Adjust VM Failure message(#907900)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11991
To unsubs
Ravi Nori has posted comments on this change.
Change subject: tools : manage-domains messages should be more clear
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11992
To unsubscribe, visit http://gerrit.ovi
Ravi Nori has uploaded a new change for review.
Change subject: tools : manage-domains messages should be more clear
..
tools : manage-domains messages should be more clear
When user adds a domain with no "-addPermissions" the m
Moti Asayag has posted comments on this change.
Change subject: core: cleanup AddVmPoolWithVmsCommand#getJobMessageProperties
..
Patch Set 1: (1 inline comment)
File
backend
Vered Volansky has posted comments on this change.
Change subject: core: Adjust VM Failure message(#907900)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11991
To unsubscribe, visit http://gerrit.ovirt.org/
Vered Volansky has uploaded a new change for review.
Change subject: core: Adjust VM Failure message(#907900)
..
core: Adjust VM Failure message(#907900)
When creation of a snapshot fails due to VM state, a more informative
mess
Eli Mesika has submitted this change and it was merged.
Change subject: core:Cannot add external event if flood rate is...
..
core:Cannot add external event if flood rate is...
Cannot add external event if flood rate is not pas
Eli Mesika has posted comments on this change.
Change subject: core:Cannot add external event if flood rate is...
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11847
To unsubscri
liron aravot has posted comments on this change.
Change subject: core: TimeoutBase: Prevent updating mutable Date
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11897
T
liron aravot has posted comments on this change.
Change subject: core: Remove AutoLogin enum.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11935
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: core: Moved ui event related classes from compat
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11806
To unsubscribe, visit h
Alon Bar-Lev has posted comments on this change.
Change subject: tools: Use LocalConfig to read configuration
..
Patch Set 1: Looks good to me, but someone else must approve
Nice!
I already had this one, but waited for the reo
Daniel Erez has posted comments on this change.
Change subject: core: Remove AutoLogin enum.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11935
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: webadmin: Refactored import VM/Temaplate dialog
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10828
To unsubscribe, visit ht
Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 4: (2 inline comments)
File
backend/ma
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
..
Patch Set 4: (2 inline comments)
File
fronte
Juan Hernandez has posted comments on this change.
Change subject: tools: error in engine-notifierd init script
..
Patch Set 2: Looks good to me, but someone else must approve
Thanks for the clarifications Greg.
--
To view, vi
Greg Padgett has posted comments on this change.
Change subject: tools: error in engine-notifierd init script
..
Patch Set 2: Verified
Rebased. Also updated the commit message to fix the bug link and better
describe what caus
Vered Volansky has posted comments on this change.
Change subject: core: TimeoutBase: Prevent updating mutable Date
..
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
..
Allon Mureinik has posted comments on this change.
Change subject: engine: remove empty else branch from DbFacade
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11987
To unsubscribe, visit
Sharad Mishra has posted comments on this change.
Change subject: core: Adding compatibility version support for GlusterFS.
..
Patch Set 9: (1 inline comment)
File backend/ma
Allon Mureinik has posted comments on this change.
Change subject: core: TimeoutBase: Prevent updating mutable Date
..
Patch Set 2: Verified
Changed implementation to simply work with a primitive long instead of a
java.util.Da
Michael Kublin has posted comments on this change.
Change subject: core: Mae IVdcUser extend Serializable
..
Patch Set 1:
It messed a lines, so a line should be:
public class VdcUser implements IVdcUser {
--
To view, visit htt
Michael Kublin has posted comments on this change.
Change subject: core: Mae IVdcUser extend Serializable
..
Patch Set 1:
VdcUser implements IVdcUser, Serializable
interface IVdcUser extends Serializable
It is means that VdcUse
Allon Mureinik has posted comments on this change.
Change subject: core: Mae IVdcUser extend Serializable
..
Patch Set 1: (1 inline comment)
@Michael - I think I did not explain the issue correctly.
E.g., look at AuditLogableB
Alona Kaplan has uploaded a new change for review.
Change subject: engine: moving VM with empty nic to unsupported cluster should
be blocked
..
engine: moving VM with empty nic to unsupported cluster should be blocked
When movi
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Move saveIsInitialized to VmDao
..
core: Move saveIsInitialized to VmDao
Moved saveIsInitialized(vmId, isInitialized) from DbFacade to VmDao,
whe
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove default audit logging
..
core: Remove default audit logging
Removed the notion of default logging from AuditLogDirector and
AuditLogableBa
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Seriazlizable DiskImage comperators
..
core: Seriazlizable DiskImage comperators
Both DiskImage comperators in the dal packages were not defined
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove redundant cast from AuditLogableBase
..
core: Remove redundant cast from AuditLogableBase
Removed a cast of getuser_id() to NGuid, as it i
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Singleton row mapper for Tags
..
core: Singleton row mapper for Tags
Added a singleton row mapper for TagDAO, as specified by
http://www.ovirt.or
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix modifiers in VmGuestAgentInterfaceDao
..
core: Fix modifiers in VmGuestAgentInterfaceDao
Added missing implied final and static modifiers and
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ADL - remove redundant null check
..
core: ADL - remove redundant null check
Removed a redundant null check in AuditLogDirector.log.
The if bran
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Audit logging method names
..
core: Audit logging method names
Changed AuditLogDirector and AudtiLoggableBase's method names to adhere
to Java's
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Java conventions for DbFacade method names
..
core: Java conventions for DbFacade method names
Renamed DbFacade's methods to use Java camelCase c
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Singleton row mapper for Bookmarks
..
core: Singleton row mapper for Bookmarks
Added a singleton row mapper for BookmarkDAO, as specified by
http
Allon Mureinik has submitted this change and it was merged.
Change subject: core: MapEntry iterator in PostgresDbEngineDialect
..
core: MapEntry iterator in PostgresDbEngineDialect
Iterated over the entries in
extractOutputPara
Allon Mureinik has posted comments on this change.
Change subject: core: Fix modifiers in VmGuestAgentInterfaceDao
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Move saveIsInitialized to VmDao
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: Java conventions for DbFacade method names
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Remove default audit logging
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Remove redundant cast from AuditLogableBase
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visi
Allon Mureinik has posted comments on this change.
Change subject: core: Audit logging method names
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: ADL - remove redundant null check
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: Seriazlizable DiskImage comperators
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: Singleton row mapper for Bookmarks
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: Singleton row mapper for Tags
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: MapEntry iterator in PostgresDbEngineDialect
..
Patch Set 3: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, vis
Juan Hernandez has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Fix modifiers in VmGuestAgentInterfaceDao
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Java conventions for DbFacade method names
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Move saveIsInitialized to VmDao
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://ger
Juan Hernandez has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Remove default audit logging
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Remove redundant cast from AuditLogableBase
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visi
Allon Mureinik has posted comments on this change.
Change subject: core: Audit logging method names
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, fix conflicts with VDS method names, no "real" changes.
+2 by Mich
Allon Mureinik has posted comments on this change.
Change subject: core: ADL - remove redundant null check
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: Seriazlizable DiskImage comperators
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: Singleton row mapper for Bookmarks
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: Singleton row mapper for Tags
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: MapEntry iterator in PostgresDbEngineDialect
..
Patch Set 2: Verified; Looks good to me, approved
Rebase, no code changes.
+2 by Michael.
--
To view, vis
Omer Frenkel has posted comments on this change.
Change subject: core: patterned pool names support
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11986
To unsubscribe,
Frank Kobzik has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11703
To unsubscribe, visit http:/
Frank Kobzik has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://ger
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: remove empty else branch from DbFacade
..
engine: remove empty else branch from DbFacade
The else branch was for hibernate.
Change-Id: I87e1628814f7cd
Doron Fediuck has submitted this change and it was merged.
Change subject: tools: notifier - add aditional validation
..
tools: notifier - add aditional validation
Check for valid email (simple @ validation)
Check for valid por
Doron Fediuck has posted comments on this change.
Change subject: tools: notifier - add aditional validation
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11549
To unsubscribe, visit http:
Doron Fediuck has posted comments on this change.
Change subject: webadmin: cpu pinning visibility in vm dialog
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11972
To
Omer Frenkel has posted comments on this change.
Change subject: webadmin: patterned pool names support
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11985
To unsubscr
Arik Hadas has posted comments on this change.
Change subject: core: cleanup AddVmPoolWithVmsCommand#getJobMessageProperties
..
Patch Set 1: (1 inline comment)
File
backend/
Einav Cohen has posted comments on this change.
Change subject: webadmin: Failure message popup window text unified
..
Patch Set 3:
Libor - can you please update the commit-comment message to include more
details on what will
1 - 100 of 344 matches
Mail list logo
