Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java
Line 25: response.setHeader("Content-Disposition", "attachment;
filename=\"" + fileName + "\"");
Line 26: response.setHeader("Cache-Control", "no-cache,
must-revalidate"); //disable caching HTTP/1.1
Line 27: response.setHeader("Expires", "Sat, 26 Jul 1997 05:00:00
GMT"); //disable caching HTTP/1.0
Line 28:
Line 29: response.getWriter().println(content);
I understood exactly the opposite... that OutputStream is more safe (and more
generic...) so you don't need to checkError() at all.
Line 30: }
....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 48: </servlet-mapping>
Line 49:
Line 50: <!-- Servlet to serve config files for console client -->
Line 51: <servlet>
Line 52: <servlet-name>ConsoleConfigServlet</servlet-name>
I don't understand the problem... you chose the attachment name, which always
open the attachment, unless 'Don't Ask' is specified, which is fine.
What else is the problem?
Anyway the servlet name can be GetAttachment and the mapping can map the
/console.vv to this servlet....
But I wish to work with you to solve whatever issue you may have first...
Please describe it again.
Line 53:
<servlet-class>org.ovirt.engine.core.GetAttachmentServlet</servlet-class>
Line 54: </servlet>
Line 55: <servlet-mapping>
Line 56: <servlet-name>ConsoleConfigServlet</servlet-name>
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
