[Engine-patches] Change in ovirt-engine[master]: tools: error in engine-notifierd init script

2013-02-08 Thread masayag
Moti Asayag has posted comments on this change. Change subject: tools: error in engine-notifierd init script .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11821 To uns

[Engine-patches] Change in ovirt-engine[master]: [WIP] webadmin: UI plugin dialog API improved

2013-02-08 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: [WIP] webadmin: UI plugin dialog API improved .. Patch Set 1: I think the "getLabel: function() { return "Button Label"; }" part of a dialog button definition i

[Engine-patches] Change in ovirt-engine[master]: tools: error in engine-notifierd init script

2013-02-08 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: tools: error in engine-notifierd init script .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11821 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: [WIP] Local authentication

2013-02-08 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: [WIP] Local authentication .. [WIP] Local authentication This patch adds an authentication provider that uses the local users and groups database. It will appe

[Engine-patches] Change in ovirt-engine[master]: WIP: working CDI solution for backend

2013-02-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: WIP: working CDI solution for backend .. Patch Set 4: (1 inline comment) File backend/manager/modules/bll/

[Engine-patches] Change in ovirt-engine[master]: WIP: working CDI solution for backend

2013-02-08 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: WIP: working CDI solution for backend .. Patch Set 4: Verified Verified building a new set of packages after applying this patch with the suggestions I maded a

[Engine-patches] Change in ovirt-engine-cli[master]: Use vncviewer passwordFile instead of passwdInput

2013-02-08 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: Use vncviewer passwordFile instead of passwdInput .. Patch Set 3: Verified Verified building a new package with this patch for Fedora 18. The VNC console works

[Engine-patches] Change in ovirt-engine-cli[master]: Use vncviewer passwordFile instead of passwdInput

2013-02-08 Thread ewoud
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Use vncviewer passwordFile instead of passwdInput .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine-cli[master]: Use vncviewer passwordFile instead of passwdInput

2013-02-08 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: Use vncviewer passwordFile instead of passwdInput .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1185

[Engine-patches] Change in ovirt-engine[master]: webadmin: making RegexValidation testable

2013-02-08 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: making RegexValidation testable .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11843 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix typo in ExistingPoolNameLengthValidationTest

2013-02-08 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: fix typo in ExistingPoolNameLengthValidationTest .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11844 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: StorageHelper class for GlusterFS.

2013-02-08 Thread deepakcs
Deepak C Shetty has posted comments on this change. Change subject: core: StorageHelper class for GlusterFS. .. Patch Set 10: @Sharad, This should be posted to topic 'glusterfs' since all of your patches in the past were t

[Engine-patches] Change in ovirt-engine-cli[master]: Use vncviewer passwordFile instead of passwdInput

2013-02-08 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: Use vncviewer passwordFile instead of passwdInput .. Patch Set 2: (1 inline comment) File src/ovirtcli/plat

[Engine-patches] Change in ovirt-engine[master]: webadmin: Error message popup window text unified

2013-02-08 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: Error message popup window text unified .. Patch Set 1: (3 inline comments) This patch is quite invasive - it changes the behavior of the whole applic

[Engine-patches] Change in ovirt-engine[master]: webadmin: Error message popup window text unified

2013-02-08 Thread lspevak
Libor Spevak has posted comments on this change. Change subject: webadmin: Error message popup window text unified .. Patch Set 1: Sorry, investigating for a while... There is difference between sf5 and 6 and oVirt formatting o

[Engine-patches] Change in ovirt-engine[master]: core: Added RegisterDiskCommand and GetUnregisteredDisksQuer...

2013-02-08 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery .. Patch Set 1: (1 inline comment) File backend/m

[Engine-patches] Change in ovirt-engine[master]: webadmin: Error message popup window text unified

2013-02-08 Thread lspevak
Libor Spevak has uploaded a new change for review. Change subject: webadmin: Error message popup window text unified .. webadmin: Error message popup window text unified 'Error:' text message removed for error messages displayed

[Engine-patches] Change in ovirt-engine-cli[master]: Use vncviewer passwordFile instead of passwdInput

2013-02-08 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: Use vncviewer passwordFile instead of passwdInput .. Patch Set 2: (2 inline comments) Some minor comments inside. .

[Engine-patches] Change in ovirt-engine[master]: tools: Consolidate all tools to single project

2013-02-08 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: Consolidate all tools to single project .. Patch Set 2: Had I been Juan, I would have merged this long ago. Yair, Juan waits for explicit authorization to

[Engine-patches] Change in ovirt-engine-cli[master]: Use vncviewer passwordFile instead of passwdInput

2013-02-08 Thread ewoud
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Use vncviewer passwordFile instead of passwdInput .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine-cli[master]: Use vncviewer passwordFile instead of passwdInput

2013-02-08 Thread ewoud
Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Use vncviewer passwordFile instead of passwdInput .. Patch Set 1: I would prefer that you didn't submit this (3 inline comments) ..

[Engine-patches] Change in ovirt-engine[master]: engine: Enable AJP in development configuration

2013-02-08 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: engine: Enable AJP in development configuration .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1150

[Engine-patches] Change in ovirt-engine[master]: packaging: Prepare for CDI

2013-02-08 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: Prepare for CDI .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11794 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session

2013-02-08 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: core: Non-plugin automatic invocation of console session .. Patch Set 2: (1 inline comment) File backend/man