Tomas Jelinek has posted comments on this change. Change subject: webadmin: Error message popup window text unified ......................................................................
Patch Set 1: (3 inline comments) This patch is quite invasive - it changes the behavior of the whole application. I don't say it is a problem, but are you sure we want to do this? Are you sure it is OK that the "Error:" will not be shown for any error message anymore? Are you sure that the intended behavior is not the opposite (e.g. show the "Error:" also for errors in RunMultipleAction)? .................................................... Commit Message Line 5: CommitDate: 2013-02-08 13:13:02 +0100 Line 6: Line 7: webadmin: Error message popup window text unified Line 8: Line 9: 'Error:' text message removed for error messages displayed using FrontendFailureEventListener. the lines should be max 80 chars long - this is 95. Please shorten it Line 10: Line 11: Change-Id: I80a9b71e1a3e6f97342184e71ffcbb7cee1df4e9 Line 12: Bug-Url: https://bugzilla.redhat.com/908404 .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java Line 10: import com.google.gwt.core.client.GWT; Line 11: import com.google.inject.Inject; Line 12: Line 13: public class FrontendFailureEventListener implements IEventListener { Line 14: private final ErrorPopupManager errorPopupManager; the MESSAGES is not used anymore - please remove it Line 15: private static final CommonApplicationMessages MESSAGES = GWT.create(CommonApplicationMessages.class); Line 16: Line 17: @Inject Line 18: public FrontendFailureEventListener(ErrorPopupManager errorPopupManager) { Line 23: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 24: FrontendFailureEventArgs failureArgs = (FrontendFailureEventArgs) args; Line 25: Line 26: if (failureArgs.getMessage() != null) { Line 27: errorPopupManager.show(ErrorMessageFormatter.formatMessage(failureArgs.getMessage())); this is the only place where the CommonApplicationMessages.uiCommonFrontendFailure is used - please remove this message from CommonApplicationMessages entirely. Line 28: } else if (failureArgs.getMessages() != null) { Line 29: errorPopupManager.show(ErrorMessageFormatter.formatMessages(failureArgs.getMessages())); Line 30: } Line 31: } -- To view, visit http://gerrit.ovirt.org/11860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80a9b71e1a3e6f97342184e71ffcbb7cee1df4e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspe...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
