Alissa Bonas has posted comments on this change.
Change subject: core: fix logging and mispelling in few classes
..
Patch Set 1: (2 inline comments)
File
backend/manager/mod
Moti Asayag has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
Patch Set 1: (1 inline comment)
F
Alon Bar-Lev has posted comments on this change.
Change subject: storage: revert change to RhevhLocalFSPath
..
Patch Set 2: (1 inline comment)
File backend/manager/dbscripts/
Sharad Mishra has posted comments on this change.
Change subject: core: WIP: Add suppoort for SSL in LDAP.
..
Patch Set 1:
Thanks Alon for your comments and review.
Yes, this is a partial patch and hence I marked it as WIP. Th
Yair Zaslavsky has posted comments on this change.
Change subject: storage: revert change to RhevhLocalFSPath
..
Patch Set 2: (1 inline comment)
File backend/manager/dbscript
Yair Zaslavsky has posted comments on this change.
Change subject: engine: putIfAbsent in EnumUtils.valueOf is ignored.
..
Patch Set 1: (1 inline comment)
File
backend/manag
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Changed Event.equal signature to override Object.equal
..
Patch Set 1: (1 inline comment)
File
bac
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: A check for possible NPE BackendVmsResource:remove
method
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ger
Shireesh Anjal has posted comments on this change.
Change subject: packaging: Application Mode option in installer
..
Patch Set 5:
One more thing we need to do is, if application mode is selected as "Gluster",
the questions re
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Log details of option being set
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Log volume creation before option set
..
Patch Set 2: (1 inline comment)
File
backend/manager/mod
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Make set option a step of create volume
..
Patch Set 1: (8 inline comments)
File
backend/manager/
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
Patch Set 1: (1 inline comment)
...
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: (1 inline comment)
File src/engine-is
Keith Robertson has submitted this change and it was merged.
Change subject: cleanup: pep8 compliant
..
cleanup: pep8 compliant
Change-Id: Id27d66958e176c1c67cb932cad21fd30258e09ae
Signed-off-by: Alon Bar-Lev
---
M src/__main_
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 compliant
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10934
To unsubscribe, visit http://gerrit.ovirt.or
Keith Robertson has posted comments on this change.
Change subject: build: maintainer-clean to not warn if empty lines in .gitignore
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10933
To
Keith Robertson has submitted this change and it was merged.
Change subject: build: maintainer-clean to not warn if empty lines in .gitignore
..
build: maintainer-clean to not warn if empty lines in .gitignore
Change-Id: I1df90
Keith Robertson has posted comments on this change.
Change subject: build: support rpm package branding
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10923
To unsubscribe, visit http://ger
Keith Robertson has submitted this change and it was merged.
Change subject: build: support rpm package branding
..
build: support rpm package branding
Change-Id: I22ceb99d8cc81188f0fc5e5ec107a38c2009752e
Signed-off-by: Alon Ba
Alon Bar-Lev has posted comments on this change.
Change subject: storage: revert change to RhevhLocalFSPath
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10965
To unsubscribe, visit http://gerrit.ovirt.org/
Moti Asayag has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
Patch Set 1: (1 inline comment)
F
Moti Asayag has posted comments on this change.
Change subject: engine: Changed Event.equal signature to override Object.equal
..
Patch Set 1: (1 inline comment)
File
backen
Moti Asayag has posted comments on this change.
Change subject: engine: A check for possible NPE in
RemoveExternalEventCommand.canDoAction
..
Patch Set 1: (1 inline comment)
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3235/
Build Number: 3235
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,966
-
Changes Since La
Moti Asayag has posted comments on this change.
Change subject: engine: Assigned resultset to a local var in
StandaloneDataSource:checkConnection()
..
Patch Set 1: (1 inline comment)
...
Alon Bar-Lev has posted comments on this change.
Change subject: storage: revert change to RhevhLocalFSPath
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscripts/
Daniel Erez has posted comments on this change.
Change subject: storage: revert change to RhevhLocalFSPath
..
Patch Set 1: (2 inline comments)
File backend/manager/dbscripts/
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 8:
I don't think the vdsm errors properties file is the correct place for the
errors. Please move them to AppErrors.pro
Alon Bar-Lev has posted comments on this change.
Change subject: storage: revert change to RhevhLocalFSPath
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscripts/
Daniel Erez has posted comments on this change.
Change subject: storage: revert change to RhevhLocalFSPath
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscripts/u
Moran Goldboim has posted comments on this change.
Change subject: packaging: engine-setup - add firewalld support
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10493
Daniel Erez has posted comments on this change.
Change subject: core: Elaborate on maintenance err msg (#862440)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10599
To unsubscribe, visit h
Moti Asayag has submitted this change and it was merged.
Change subject: core: add isTraceEnabled to Log class
..
core: add isTraceEnabled to Log class
Add isTraceEnabled to trace methods of Log class for performance
Change-Id
Moti Asayag has posted comments on this change.
Change subject: core: add isTraceEnabled to Log class
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10873
To unsubscribe, visit ht
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3234/
Build Number: 3234
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,965
-
Changes Since
Yair Zaslavsky has posted comments on this change.
Change subject: engine : NameNotFoundException when processing DNs containing
umlauts
..
Patch Set 1:
Please verify -
1. Try creating a group with umlauts and give it permissi
Moti Asayag has posted comments on this change.
Change subject: core: fix logging and mispelling in few classes
..
Patch Set 1: (2 inline comments)
File
backend/manager/modu
Moti Asayag has posted comments on this change.
Change subject: engine: Cleanup Logging in MacPoolManager
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10833
To unsubscribe, visit http://g
Michael Pasternak has uploaded a new change for review.
Change subject: cli: detailed command syntax in help
..
cli: detailed command syntax in help
Change-Id: I7f1f15a01f49a179038084d5e67c83a0fa64ba41
Signed-off-by: Michael Pas
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: wrong user id in /api/users//permissions(#890124)
..
restapi: wrong user id in /api/users//permissions(#890124)
The user id returned by /ap
Michael Pasternak has posted comments on this change.
Change subject: restapi: wrong user id in /api/users//permissions(#890124)
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/105
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : error when adding disk with missing
parameters(#890524)
..
restapi : error when adding disk with missing parameters(#890524)
When trying
Michael Pasternak has posted comments on this change.
Change subject: restapi : error when adding disk with missing
parameters(#890524)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Michael Pasternak has posted comments on this change.
Change subject: restapi : error when adding disk with missing
parameters(#890524)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10820
Daniel Erez has posted comments on this change.
Change subject: storage: revert change to RhevhLocalFSPath
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10965
To unsub
Alon Bar-Lev has uploaded a new change for review.
Change subject: storage: revert change to RhevhLocalFSPath
..
storage: revert change to RhevhLocalFSPath
This revert a change to RhevhLocalFSPath in change I3fa85dd89.
It was w
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: release 3.2.0.9-1
..
cli: release 3.2.0.9-1
Change-Id: Ibb6e7d4176177d87a22cf7506b4253ab5c68a834
Signed-off-by: Michael Pasternak
---
M Makefi
Michael Pasternak has posted comments on this change.
Change subject: cli: release 3.2.0.9-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10964
To unsubscribe, visit http://gerr
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: detailed command syntax in help
..
cli: detailed command syntax in help
Change-Id: I42c2c4f1d448cfd380ffbb5917167f1813bdfdbc
Signed-off-by: Mic
Michael Pasternak has posted comments on this change.
Change subject: cli: detailed command syntax in help
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10963
To unsubscribe, vis
Michael Pasternak has uploaded a new change for review.
Change subject: cli: detailed command syntax in help
..
cli: detailed command syntax in help
Change-Id: I42c2c4f1d448cfd380ffbb5917167f1813bdfdbc
Signed-off-by: Michael Pas
Michael Pasternak has uploaded a new change for review.
Change subject: cli: release 3.2.0.9-1
..
cli: release 3.2.0.9-1
Change-Id: Ibb6e7d4176177d87a22cf7506b4253ab5c68a834
Signed-off-by: Michael Pasternak
---
M Makefile
M ovi
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 3.2.0.8-1
..
sdk: release 3.2.0.8-1
Change-Id: I6ab559727f8ef1bc6f07a66a2308833bdf9a1345
Signed-off-by: Michael Pasternak
---
M Makefi
Michael Pasternak has posted comments on this change.
Change subject: sdk: release 3.2.0.8-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10962
To unsubscribe, visit http://gerr
Michael Pasternak has posted comments on this change.
Change subject: sdk: fix date in ovirt-engine-sdk.spec.in
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10961
To unsubscribe
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: fix date in ovirt-engine-sdk.spec.in
..
sdk: fix date in ovirt-engine-sdk.spec.in
Change-Id: I4702fcb1ebe8645bc957e07be9b442ab28a9a5b8
Signed-o
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: fix date in ovirt-engine-sdk.spec.in
..
sdk: fix date in ovirt-engine-sdk.spec.in
Change-Id: I4702fcb1ebe8645bc957e07be9b442ab28a9a5b8
Signed-off-by: M
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: release 3.2.0.8-1
..
sdk: release 3.2.0.8-1
Change-Id: I6ab559727f8ef1bc6f07a66a2308833bdf9a1345
Signed-off-by: Michael Pasternak
---
M Makefile
M ovi
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3230/
Build Number: 3230
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,959,
Started by upstream project "ovirt_engine" bu
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: solve python output oddness
..
packaging: solve python output oddness
For some strange reason python loses sync with its handles when mixed
flush/file
Liron Aravot has abandoned this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
..
Patch Set 4: Abandoned
At the moment it was decided to not merge this until we will decide on which
host th
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: putIfAbsent in EnumUtils.valueOf is ignored.
..
engine: putIfAbsent in EnumUtils.valueOf is ignored.
The return value of cacheEnumValuesInCapitalLetter
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Assigned resultset to a local var in
StandaloneDataSource:checkConnection()
..
engine: Assigned resultset to a local var in
StandaloneDataSource:check
Asaf Shakarchi has uploaded a new change for review.
Change subject: restapi: A check for possible NPE BackendVmsResource:remove
method
..
restapi: A check for possible NPE BackendVmsResource:remove method
A check for possible
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Changed Event.equal signature to override Object.equal
..
engine: Changed Event.equal signature to override Object.equal
Changed the covariant version
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
webadmin: A check for possible NPE in NicActivateStatusColumn:getTooltip
A check f
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: A check for possible NPE in
RemoveExternalEventCommand.canDoAction
..
engine: A check for possible NPE in RemoveExternalEventCommand.canDoAction
Added
Michael Pasternak has posted comments on this change.
Change subject: sdk: release 3.2.0.7-1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10953
To unsubscribe, visit http://gerr
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 3.2.0.7-1
..
sdk: release 3.2.0.7-1
Change-Id: If5c791dcf26f62687742fdbdb28a03be99436056
Signed-off-by: Michael Pasternak
---
M Makefi
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: regenerate against latest api
..
sdk: regenerate against latest api
- events can be added now (user defined events)
- events can be removed now
Michael Pasternak has posted comments on this change.
Change subject: sdk: regenerate against latest api
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10952
To unsubscribe, visit
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: release 3.2.0.7-1
..
sdk: release 3.2.0.7-1
Change-Id: If5c791dcf26f62687742fdbdb28a03be99436056
Signed-off-by: Michael Pasternak
---
M Makefile
M ovi
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add validation for locked template
..
core: Add validation for locked template
Engine validation should be correlated with the GUI, for REST purpos
Maor Lipchuk has posted comments on this change.
Change subject: core: Add validation for locked template
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9070
To unsubscribe, visit http://ge
Daniel Erez has posted comments on this change.
Change subject: core: Add validation for locked template
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9070
To unsubscribe, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: persist LUN with correct volume_group_id
..
Patch Set 1: Looks good to me, but someone else must approve
(4 inline comments)
Text issues, see inline.
Al
Maor Lipchuk has posted comments on this change.
Change subject: core: Add validation for locked template
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/9070
To unsubscribe, visit http://gerrit.ovirt.org/set
Maor Lipchuk has posted comments on this change.
Change subject: core: Add validation for locked template
..
Patch Set 6: (1 inline comment)
Commit Message
Line 5: CommitDate
Allon Mureinik has posted comments on this change.
Change subject: core: Use storage helper to fetch (related to BZ882825)
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10141
To unsubscrib
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: fix broken naming convention in the xsd schema
..
restapi: fix broken naming convention in the xsd schema
Change-Id: Ibf70e76f3d39144768b86
Michael Pasternak has posted comments on this change.
Change subject: restapi: fix broken naming convention in the xsd schema
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10947
Michael Pasternak has posted comments on this change.
Change subject: restapi: fix broken naming convention in the xsd schema
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10947
Daniel Erez has posted comments on this change.
Change subject: ui: replacing favicon.ico file
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Allon Mureinik has posted comments on this change.
Change subject: core:StorageHelper cleanup, code clean
..
Patch Set 5: Looks good to me, approved
(1 inline comment)
Please fix the commit message when you rebase.
..
Allon Mureinik has posted comments on this change.
Change subject: core:(WIP) VM pool snapshot should not be stateless.
..
Patch Set 1: I would prefer that you didn't submit this
The spirit of the fix seems correct to me, but a
Alissa Bonas has uploaded a new change for review.
Change subject: core: fix logging and mispelling in few classes
..
core: fix logging and mispelling in few classes
1.Fix mispelling of comment
2.Rephrase logging message
3.Log e
Allon Mureinik has posted comments on this change.
Change subject: [WIP] core: compensation should not clean entities with
associated tasks
..
Patch Set 4: I would prefer that you didn't submit this
Agree with Barak.
Flagging
Allon Mureinik has posted comments on this change.
Change subject: core: Add validation for locked template
..
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
minor text issues, might as well f
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10573
To u
Allon Mureinik has posted comments on this change.
Change subject: core: Add VDSM missing error messages.
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
.
Daniel Erez has uploaded a new change for review.
Change subject: ui: replacing favicon.ico file
..
ui: replacing favicon.ico file
New oVirt favicon.ico file (website icon).
Change-Id: I37424dcd6c422d6ffdfff4b8d8befb07d481190d
Allon Mureinik has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
..
Patch Set 4: I would prefer that you didn't submit this
flagging with -1 until my questions are a
Ohad Basan has posted comments on this change.
Change subject: packaging: initial repo creation
..
Patch Set 15: Verified
--
To view, visit http://gerrit.ovirt.org/9733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3229/
Build Number: 3229
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,953
-
Changes Since
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Removing unneeded setVdsId() from constructors
..
engine: Removing unneeded setVdsId() from constructors
The following call is unneeded because
Allon Mureinik has posted comments on this change.
Change subject: engine: Removing unneeded setVdsId() from constructors
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
Verified.
Approved by me,
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2647/
Build Number: 2647
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Allon Mureinik has posted comments on this change.
Change subject: core: add toString method to VM and VDS
..
Patch Set 6: I would prefer that you didn't submit this
Agree with the inline comments by Moti, Yair and Omer, giving
1 - 100 of 295 matches
Mail list logo
