Moti Asayag has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java
Line 51: tooltip =
Line 52:
tooltip.append(templates.cardStatus(constants.unpluggedNetworkInteface()).asString());
Line 53: }
Line 54:
Line 55: tooltip = tooltip.append("<BR>"); //$NON-NLS-1$
you've added above: vnic != null which implies vnic might be a null.
In the statement below you're accessing its method by vnic.isLinked().
if vnic is null, you'll get NPE.
Line 56: if (vnic.isLinked()) {
Line 57: tooltip =
Line 58:
tooltip.append(templates.linkState(constants.linkedNetworkInteface())
Line 59: .asString());
--
To view, visit http://gerrit.ovirt.org/10957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib350579b4ff7d7193a9870c83f4014df57bb3da4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
