Omer Frenkel has posted comments on this change.
Change subject: core: Change class name from action_version_map to
ActionVersionMap.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ger
Omer Frenkel has posted comments on this change.
Change subject: core: Renamed vm_template_image_map_id.java to
VmTemplateImageMapId.java
..
Patch Set 1: No score
well it looks like this is used only in vm_template_image_map,
Omer Frenkel has posted comments on this change.
Change subject: core: Renamed vm_template_image_map.java to
VmTemplateImageMap.java
..
Patch Set 1:
looks like this class can be just removed completely, no?
--
To view, visit
Omer Frenkel has posted comments on this change.
Change subject: core: Renamed vm_template_image_map_id.java to
VmTemplateImageMapId.java
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/100
Omer Frenkel has posted comments on this change.
Change subject: core Renamed vm_pool_map.java to VmPoolMap.java
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10085
To unsubscribe, visit h
Liron Aravot has posted comments on this change.
Change subject: core: RemoveVmCommand canDoAction cleanup
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bl
Liron Aravot has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/bl
Liron Aravot has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/bl
Liron Aravot has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/bl
Michael Pasternak has posted comments on this change.
Change subject: restapi: Activate/Deactivate vnic should use edit
..
Patch Set 2: I would prefer that you didn't submit this
well done Alona!,
1. please add api tests for t
Michael Pasternak has posted comments on this change.
Change subject: restapi: fix NPE when adding vm with no cpu mode
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10372
To unsubscribe, v
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Validation added in Import Cluster
..
Patch Set 4: (2 inline comments)
Incorporated review comments.
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Allow remove of a VM without removing its disks
..
webadmin: Allow remove of a VM without removing its disks
Change-Id: Iba531f7a87295564e20bd99763d185f78
Tal Nisan has posted comments on this change.
Change subject: core: RemoveVmCommand canDoAction cleanup
..
Patch Set 4: (4 inline comments)
File
backend/manager/modules/bll/
liron aravot has posted comments on this change.
Change subject: core: RemoveVmCommand canDoAction cleanup
..
Patch Set 4: (4 inline comments)
File
backend/manager/modules/b
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_map.java to EventMap.java
..
Patch Set 3: Verified
rebased. no code changes
--
To view, visit http://gerrit.ovirt.org/10053
To unsubscribe,
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_notification_methods.java to
EventNotificationMethod.java
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10068
To unsubs
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_map_id.java EventMapId.java
..
Patch Set 2: Verified
rebased, no code changes
--
To view, visit http://gerrit.ovirt.org/10052
To unsubscribe
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_audit_log_subscriber.java to
EventAuditLogSubscriber.java
..
Patch Set 2: Verified
rebased, no code change.
--
To view, visit http://gerrit
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed bookmarks.java to Bookmark.java
..
Patch Set 5: Verified
rebased, no code change
--
To view, visit http://gerrit.ovirt.org/10049
To unsubscribe, v
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing compensation of RemoveStoragePool
..
core: Fixing compensation of RemoveStoragePool
The following patch takes advantage of the on delete
c
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing compensation of RemoveStoragePool
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10333
To unsubscri
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing compensation of RemoveStoragePool
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10333
T
Yair Zaslavsky has posted comments on this change.
Change subject: core:[RFE]Improve power management proxy ...
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9673
To unsubscribe, visit htt
Sharad Mishra has posted comments on this change.
Change subject: core: Removed unused class.
..
Patch Set 2:
Can I get help to test the upgrade script?
--
To view, visit http://gerrit.ovirt.org/10071
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10260
To unsubscribe, visit http:
Alissa Bonas has posted comments on this change.
Change subject: core: RemoveVmCommand canDoAction cleanup
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10373
To unsub
Tal Nisan has uploaded a new change for review.
Change subject: core: RemoveVmCommand canDoAction cleanup
..
core: RemoveVmCommand canDoAction cleanup
Change-Id: Iad7c7f44437bed6280a81bcd99aa2d556818e6be
Signed-off-by: Tal Nisan
Gilad Chaplik has posted comments on this change.
Change subject: engine: Fix storage quota distribution bug
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
..
Arik Hadas has posted comments on this change.
Change subject: restapi: fix NPE when adding vm with no cpu mode
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10372
To unsubscribe, visit http://gerrit.ovirt.
Arik Hadas has uploaded a new change for review.
Change subject: restapi: fix NPE when adding vm with no cpu mode
..
restapi: fix NPE when adding vm with no cpu mode
A check whether the lately added attribute 'cpu mode' is defin
Muli Salem has uploaded a new change for review.
Change subject: restapi: Guest Agent Network Devices of Nic (WIP)
..
restapi: Guest Agent Network Devices of Nic (WIP)
This patch adds the Guest Agent information to
a Nic, accord
Eli Mesika has posted comments on this change.
Change subject: API: [RFE] Add PM Proxy Preferences
..
Patch Set 8: (4 inline comments)
File
backend/manager/modules/restapi/i
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: remove "all" filter from Network Host sub tab
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10368
To unsubscribe
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add filters to NetworkVm sub tab- running, not
running.
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
ack, tiny comment/question
...
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Show additional columns for events
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10315
To unsubscribe, visit htt
Liron Aravot has posted comments on this change.
Change subject: engine: Add validation to cpu pinning
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/bll/s
Arik Hadas has posted comments on this change.
Change subject: restapi: fix usb mapping on update vm call
..
Patch Set 2: (4 inline comments)
File
backend/manager/modules/re
Arik Hadas has posted comments on this change.
Change subject: restapi: fix usb mapping on update vm call
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/9792
To unsubscribe, visit http://gerrit.ovirt.org/set
Eli Mesika has posted comments on this change.
Change subject: core : API changes Multi-Tier fencing
..
Patch Set 5: (4 inline comments)
File
backend/manager/modules/restapi
Liron Aravot has posted comments on this change.
Change subject: engine: Add validation to cpu pinning
..
Patch Set 2: (8 inline comments)
File
backend/manager/modules/bll/s
Arik Hadas has posted comments on this change.
Change subject: restapi: fix usb mapping on update vm call
..
Patch Set 4: No score
--
To view, visit http://gerrit.ovirt.org/9792
To unsubscribe, visit http://gerrit.ovirt.org/set
Eli Mesika has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules/bll
Arik Hadas has posted comments on this change.
Change subject: restapi: fix usb mapping on update vm call
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/9792
To unsubscribe, visit http://gerrit.ovirt.org/set
ofri masad has uploaded a new change for review.
Change subject: engine: Fix storage quota distribution bug
..
engine: Fix storage quota distribution bug
In user portal the storage quota distribution was not presented because
th
Yair Zaslavsky has posted comments on this change.
Change subject: core : adding GetAuditLogByIdQuery
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10092
To unsubscribe, visit http://gerri
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding external events BE support and testing
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10091
To unsubscribe, v
Yair Zaslavsky has posted comments on this change.
Change subject: core: DB Changes
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10090
To unsubscribe, visit http://gerrit.ovirt.org/settin
Yair Zaslavsky has posted comments on this change.
Change subject: core: RFE: Allow plugins to add events into the...
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10089
To unsubscribe, vi
Barak Azulay has submitted this change and it was merged.
Change subject: updated change-log for version 1.0.7
..
updated change-log for version 1.0.7
Change-Id: I8439b85ca0b479455dc7b03ff25ceccd04594f60
Signed-off-by: Gal Hamm
Barak Azulay has posted comments on this change.
Change subject: updated change-log for version 1.0.7
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10369
To unsubscribe, visit http://gerri
Gal Hammer has posted comments on this change.
Change subject: updated change-log for version 1.0.7
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10369
To un
Gal Hammer has uploaded a new change for review.
Change subject: updated change-log for version 1.0.7
..
updated change-log for version 1.0.7
Change-Id: I8439b85ca0b479455dc7b03ff25ceccd04594f60
Signed-off-by: Gal Hammer
---
M
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: cleanup in VdsDeploy
..
core: cleanup in VdsDeploy
Remove unused variable and code in VdsDeploy
Change-Id: I09d8322c88bd4982c232fa8217532a541e24
Yair Zaslavsky has posted comments on this change.
Change subject: core: cleanup in VdsDeploy
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10290
To unsubscribe, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: core: cleanup in VdsDeploy
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10290
To unsubscribe, visit http://gerrit.ovirt.
Maor Lipchuk has posted comments on this change.
Change subject: core,ui: support multiple concurrent disks migration
..
Patch Set 4:
same comment for LiveMigrateDisksParameters.
This classes will be hard to maintain when the h
Maor Lipchuk has posted comments on this change.
Change subject: core,ui: support multiple concurrent disks migration
..
Patch Set 4:
Consider to change the class name LiveMigrateDisksCommand, it could be
confusing with LiveMi
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: remove "all" filter from Network Host sub tab
..
webadmin: remove "all" filter from Network Host sub tab
The all radio button in the Network Host sub t
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Add filters to NetworkVm sub tab- running, not
running.
..
webadmin: Add filters to NetworkVm sub tab- running, not running.
In this patch a radio but
Omer Frenkel has posted comments on this change.
Change subject: frontend: [RFE] Display of both the console user and the guest
user
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10274
To unsubscribe, visi
Omer Frenkel has posted comments on this change.
Change subject: core: [RFE] Display of both the console user and the guest user
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/10219
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Show additional columns for events
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10315
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: Search Engine changes
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10095
To unsubscribe, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: core : implementing AddExternalEventCommand ...
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10094
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Set Object Type & Action Group for external events
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10093
To unsubscri
Yair Zaslavsky has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 4:
Please fix according to Liron's comment
--
To view, visit http://gerrit.ovirt.org/10260
To unsubscrib
Michael Pasternak has uploaded a new change for review.
Change subject: cli: "remove permit" command doesnt work by-id #887805
..
cli: "remove permit" command doesnt work by-id #887805
https://bugzilla.redhat.com/show_bug.cgi?id
Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 19: (1 inline comment)
File
backend/manager/modules/vds
Oved Ourfali has posted comments on this change.
Change subject: cli: wrong response for suspend VM #886944
..
Patch Set 1: (1 inline comment)
File src/ovirtcli/command/actio
Yair Zaslavsky has posted comments on this change.
Change subject: Adding host bios fields to vds_dynamic table
..
Patch Set 7: (1 inline comment)
Yaniv, please close about bios prefixes with Alon Bar Lev.
As you see - I asked
Michael Pasternak has uploaded a new change for review.
Change subject: cli: wrong response for suspend VM #886944
..
cli: wrong response for suspend VM #886944
https://bugzilla.redhat.com/show_bug.cgi?id=886944
Change-Id: I345
Alona Kaplan has posted comments on this change.
Change subject: webadmin: allow a single user lookup at a time
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10241
To unsubscribe, visit ht
Daniel Erez has abandoned this change.
Change subject: webadmin: correlate models to move multiple disks API
..
Patch Set 3: Abandoned
Squashed into http://gerrit.ovirt.org/#/c/10154/
--
To view, visit http://gerrit.ovirt.org/
Noam Slomianko has posted comments on this change.
Change subject: engine: Add validation to cpu pinning
..
Patch Set 2: Verified
Still waiting for answer about pCPU validation
--
To view, visit http://gerrit.ovirt.org/10364
T
Liron Aravot has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
..
Patch Set 29:
vered, your comments will be addressed in a further patch
--
To view, visit http:
Gilad Chaplik has submitted this change and it was merged.
Change subject: webamin: hide cpuPin section according to config values
..
webamin: hide cpuPin section according to config values
According to cpuPinningEnabled flag,
Gilad Chaplik has posted comments on this change.
Change subject: webamin: hide cpuPin section according to config values
..
Patch Set 8: Verified; Looks good to me, approved
rebased & verified.
--
To view, visit http://gerrit
Noam Slomianko has uploaded a new change for review.
Change subject: engine: Add validation to cpu pinning
..
engine: Add validation to cpu pinning
Validation the following conditions:
- syntax is correct
- all given vcpus exist
Daniel Erez has posted comments on this change.
Change subject: perform connectStorageServer to hosts after during
reconstruct/recovery(#880180)
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.
Daniel Erez has posted comments on this change.
Change subject: core: ReconstructMasterDomain -connect/disconnect hosts
simultaneously
..
Patch Set 4: Looks good to me, approved
please fix comment on rebase
--
To view, visit
Daniel Erez has posted comments on this change.
Change subject: core: add executor for execution of runnables with
CountDownLatch
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Liron Aravot has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 19: (1 inline comment)
File
backend/manager/modules/vdsbr
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: pki: pending key fixups
..
vdsm: pki: pending key fixups
pending key existence should be deferred to misc stage as we do not have
the actual vdsm k
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: pki: pending key fixups
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10362
To unsubscribe, visit http://ge
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: pki: fix accept enrollment
..
vdsm: pki: fix accept enrollment
Due to python indent typo
Change-Id: I2cb780e61a6071616187e0e21aae768866aba976
Sign
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: pki: fix accept enrollment
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10361
To unsubscribe, visit http:/
Liron Aravot has posted comments on this change.
Change subject: core: ReconstructMasterDomain -connect/disconnect hosts
simultaneously
..
Patch Set 3: (7 inline comments)
vered, sorry - forgot to publish the comments as well
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: pki: pending key fixups
..
vdsm: pki: pending key fixups
pending key existence should be deferred to misc stage as we do not have
the actual vdsm key store
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: pki: fix accept enrollment
..
vdsm: pki: fix accept enrollment
Due to python indent typo
Change-Id: I2cb780e61a6071616187e0e21aae768866aba976
Signed-off-b
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: misc: dump environment before validation
..
core: misc: dump environment before validation
Useful for debug.
Change-Id: I026da7e83bd7cf9b17b73156c
Alon Bar-Lev has posted comments on this change.
Change subject: core: misc: dump environment before validation
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10360
To unsubscribe
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: config: add enforce environment configuration
..
core: config: add enforce environment configuration
Change-Id: I50129b16d59a7ad8e1337fad9fc9b2cb65
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: add enforce environment configuration
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10359
To unsubs
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: config: add enforce environment configuration
..
core: config: add enforce environment configuration
Change-Id: I50129b16d59a7ad8e1337fad9fc9b2cb650e8e0a
S
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: misc: dump environment before validation
..
core: misc: dump environment before validation
Useful for debug.
Change-Id: I026da7e83bd7cf9b17b73156c7e090649
Omer Frenkel has posted comments on this change.
Change subject: frontend: [RFE] Display of both the console user and the guest
user
..
Patch Set 1: (1 inline comment)
File
Michael Pasternak has posted comments on this change.
Change subject: API: [RFE] Add PM Proxy Preferences
..
Patch Set 8: I would prefer that you didn't submit this
(5 inline comments)
please implement mapping tests for your u
Michael Pasternak has posted comments on this change.
Change subject: api: Support libvirt version for Host in API (#672148)
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Michael Pasternak has posted comments on this change.
Change subject: core : API changes Multi-Tier fencing
..
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
please added mapping test for this use-
1 - 100 of 132 matches
Mail list logo
