Oved Ourfali has posted comments on this change. Change subject: cli: wrong response for suspend VM #886944 ......................................................................
Patch Set 1: (1 inline comment) .................................................... File src/ovirtcli/command/action.py Line 176: try: Line 177: result = self.execute_method(resource, args[2], opts) Line 178: except Exception, e: Line 179: self.error(str(e)) Line 180: if result.status.state == 'failed': So what will happen if the status isn't "complete" but it also isn't failed? Is that possible? Don't know enough about the cli to review this issue... Line 181: self.error(Messages.Info.ACTION_STATUS % result.status.state) Line 182: else: Line 183: self.error(Messages.Error.NO_SUCH_ACTION % args[2]) Line 184: self.context.formatter.format(self.context, result) -- To view, visit http://gerrit.ovirt.org/10365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I345b2bd1d62a06fef7671704eda70dc620755bcf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
