Yair Zaslavsky has posted comments on this change.
Change subject: api: Support libvirt version for Host in API (#672148)
..
Patch Set 1: I would prefer that you didn't submit this
For some reason api.xsd got polluted by white
Omer Frenkel has posted comments on this change.
Change subject: Adding host bios fields to vds_dynamic table
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10114
To un
Yair Zaslavsky has posted comments on this change.
Change subject: core : DB FK validation
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10248
To unsubscribe, visit http://gerrit.ovirt.org
Vered Volansky has posted comments on this change.
Change subject: core: fix javadoc and remove unused method
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10351
To un
Ayal Baron has posted comments on this change.
Change subject: core: fix javadoc and remove unused method
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10351
To unsubs
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 17: (2 inline comments)
File
backend/manager/modules/vd
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3058/
Build Number: 3058
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,716
-
Changes Since La
Daniel Erez has submitted this change and it was merged.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
core: adding GetAllDisksByStorageDomainIdQuery
Adding a new query for getting DiskImages by StorageDomai
Daniel Erez has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 5: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10321
To uns
Daniel Erez has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10321
To uns
Yair Zaslavsky has posted comments on this change.
Change subject: core : GWT changes for Multi-Tier fencing
..
Patch Set 4:
I agree with Gilad
--
To view, visit http://gerrit.ovirt.org/10261
To unsubscribe, visit http://gerri
Yair Zaslavsky has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10260
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: core : BE & DAO changes for Multi-Tier fencing
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10259
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: DB Changes for Multi-Tier fencing
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10258
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: core: RFE: Multi-Tier fencing support
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10257
To unsubscribe, visit http://ge
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Avoid duplicate server queries
..
Patch Set 5: (1 inline comment)
File
frontend/webadmin/modules
Yair Zaslavsky has posted comments on this change.
Change subject: Adding host bios fields to vds_dynamic table
..
Patch Set 7:
Indeed, you do need to set the config value per each version.
--
To view, visit http://gerrit.ovir
Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 17: (1 inline comment)
File
backend/manager/modules/vds
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3057/
Build Number: 3057
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,715
-
Changes Since
Alissa Bonas has posted comments on this change.
Change subject: core: fix javadoc and remove unused method
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10351
To unsubscribe, visit http://gerrit.ovirt.org/
Alissa Bonas has uploaded a new change for review.
Change subject: core: fix javadoc and remove unused method
..
core: fix javadoc and remove unused method
fix javadoc parameters and remove unused method in VmDeviceUtils
Change
Vered Volansky has uploaded a new change for review.
Change subject: core: BackendVmDisksResource cleanup
..
core: BackendVmDisksResource cleanup
Avoided if-else clause in attachDiskToVm().
Change-Id: Iea65c24b84d99654dea6bbfea
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: add comments to addDiskCommand
..
core: add comments to addDiskCommand
In case of async task execution, we need to set the found storage domain
id
Maor Lipchuk has posted comments on this change.
Change subject: core: add comments to addDiskCommand
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10344
To unsubscribe, visit ht
Liron Aravot has posted comments on this change.
Change subject: core: cleanup AttachDettachVmDiskParameters c'tor
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10349
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3055/
Build Number: 3055
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,711,
Started by upstream project "ovirt_engine" build numb
Liron Aravot has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 17: (2 inline comments)
File
backend/manager/modules/vdsb
Vered Volansky has uploaded a new change for review.
Change subject: core: cleanup AttachDettachVmDiskParameters c'tor
..
core: cleanup AttachDettachVmDiskParameters c'tor
AttachDettachVmDiskParameters has two c'tors. Implementa
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding host bios fields to vds_dynamic table
..
Patch Set 7: Verified
seems like i need field for each version.. wait for eli response.
--
To view, visit http:
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/10115
To unsubscribe, visit http://gerrit.ovirt.
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 17: Verified
You right, It gets updated afterwards and I don't need to perform this update
each time. I omit
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 16: (1 inline comment)
File
backend/manager/modules/vds
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding host bios fields to vds_dynamic table
..
Patch Set 6: Verified
(1 inline comment)
File backend/mana
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Added option to filter by running
..
engine: Added option to filter by running
The GetVmsAndNetworkInterfacesByNetworkIdQuery can now optionally f
Moti Asayag has posted comments on this change.
Change subject: engine: Added option to filter by running
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10348
To unsubscribe, visit http://g
Mike Kolesnik has posted comments on this change.
Change subject: engine: Added option to filter by running
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10348
To unsubscribe, visit http://gerrit.ovirt.org/
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine, webadmin: Add specific query parameters
..
engine, webadmin: Add specific query parameters
Added specific parameters for GetVmsAndNetworkInterfa
Mike Kolesnik has posted comments on this change.
Change subject: engine, webadmin: Add specific query parameters
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10347
To unsubscribe, visit http://gerrit.ovir
Mike Kolesnik has posted comments on this change.
Change subject: engine: Added option to filter by running
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/b
Moti Asayag has posted comments on this change.
Change subject: engine: Added option to filter by running
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll
Vinzenz Feenstra has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
Rebased
--
To view, visit http://g
Liron Aravot has posted comments on this change.
Change subject: webadmin: Disks sub-tab under Storage main-tab
..
Patch Set 2: (4 inline comments)
File
frontend/webadmin/mo
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3054/
Build Number: 3054
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,710
-
Changes Since
Vinzenz Feenstra has posted comments on this change.
Change subject: Let udev reset user rights on virtio-channel during package
removal
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10286
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: engine, webadmin: Add specific query parameters
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10347
To unsubscribe, visit ht
Liron Aravot has posted comments on this change.
Change subject: webadmin: Avoid duplicate server queries
..
Patch Set 5: (1 inline comment)
File
frontend/webadmin/modules/f
Mike Kolesnik has uploaded a new change for review.
Change subject: engine, webadmin: Add specific query parameters
..
engine, webadmin: Add specific query parameters
Added specific parameters for GetVmsAndNetworkInterfacesByNet
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Added option to filter by running
..
engine: Added option to filter by running
The GetVmsAndNetworkInterfacesByNetworkIdQuery can now optionally filter
Maor Lipchuk has posted comments on this change.
Change subject: webadmin: Disks sub-tab under Storage main-tab
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10322
To
Maor Lipchuk has posted comments on this change.
Change subject: core: remove unused permissions classes
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10284
To unsubscribe, visit http://ge
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/10115
To unsubscribe, visit http://gerrit.ovirt.
Maor Lipchuk has posted comments on this change.
Change subject: core: add comments to addDiskCommand
..
Patch Set 3: (3 inline comments)
File
backend/manager/modules/bll/sr
Maor Lipchuk has posted comments on this change.
Change subject: webadmin: Filter Non-Operational DCs when adding new domain
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Omer Frenkel has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 16: No score
(1 inline comment)
File
backend/manager/mod
Barak Azulay has submitted this change and it was merged.
Change subject: Fixed support for reporting devices with only ipv6.
..
Fixed support for reporting devices with only ipv6.
ethtool.get_active_devices does not consider a
Barak Azulay has posted comments on this change.
Change subject: Fixed support for reporting devices with only ipv6.
..
Patch Set 5: Verified; Looks good to me, approved
Verified by: Antoni
Approved by: Dan & Vinzenz
--
To vie
Barak Azulay has posted comments on this change.
Change subject: Fixed support for reporting devices with only ipv6.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10223
To unsubscribe, vis
Barak Azulay has posted comments on this change.
Change subject: Fix pep8 errors in the linux guest agent.
..
Patch Set 3: Verified; Looks good to me, approved
Verified by: Antoni
Approved by: Vinzenz
--
To view, visit http://
Barak Azulay has submitted this change and it was merged.
Change subject: Fix pep8 errors in the linux guest agent.
..
Fix pep8 errors in the linux guest agent.
Cleanup of the code to bring it up to standards of the rest of ovi
Omer Frenkel has posted comments on this change.
Change subject: Adding host bios fields to vds_dynamic table
..
Patch Set 6: (1 inline comment)
File backend/manager/dbscript
Barak Azulay has posted comments on this change.
Change subject: Fix pep8 errors in the linux guest agent.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10218
To unsubscribe, visit http://
Barak Azulay has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9463
To unsubscrib
Roy Golan has submitted this change and it was merged.
Change subject: core: cleanup RunVmCommand#statelessVmTreatment
..
core: cleanup RunVmCommand#statelessVmTreatment
- Remove unnecessary local field 'p'
- Rename 'tmpVar' fi
Roy Golan has posted comments on this change.
Change subject: core: cleanup RunVmCommand#statelessVmTreatment
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10331
To unsubscribe,
Roy Golan has submitted this change and it was merged.
Change subject: core: introduce InternalMigrateVmParameters
..
core: introduce InternalMigrateVmParameters
Introduce InternalMigrateVmParameters class that should be used w
Roy Golan has posted comments on this change.
Change subject: core: introduce InternalMigrateVmParameters
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10319
To unsubscribe, visit http://g
Arik Hadas has posted comments on this change.
Change subject: core: introduce InternalMigrateVmParameters
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10319
To unsubscribe, visit http://gerrit.ovirt.org/s
Gilad Chaplik has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10115
To unsubscribe, visit htt
Roy Golan has submitted this change and it was merged.
Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm
..
core: Refactor InternalMigrateVmCommand#canMigrateVm
Change InternalMigrateVmCommand#canMigrateVm me
Roy Golan has posted comments on this change.
Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10107
To unsubscr
Roy Golan has posted comments on this change.
Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10107
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: core: cleanup RunVmCommand#statelessVmTreatment
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10331
To unsubscribe, visit http://gerrit.ovirt.o
Muli Salem has uploaded a new change for review.
Change subject: restapi: Guest Agent Ifaces to VM
..
restapi: Guest Agent Ifaces to VM
This patch adds the Vm Guest Agent information to
a VM, according to the feature design in:
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Avoid duplicate server queries
..
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
.
Alexey Chub has uploaded a new change for review.
Change subject: api: Support libvirt version for Host in API (#672148)
..
api: Support libvirt version for Host in API (#672148)
Change-Id: I24b955e979be57c487e2c21fffee771d1ef74
Moti Asayag has abandoned this change.
Change subject: engine: Add VmDao.getAllForDataCenter
..
Patch Set 2: Abandoned
the queries don't match the requirements.for the network main tab.
--
To view, visit http://gerrit.ovirt.or
Moti Asayag has abandoned this change.
Change subject: engine: Add GetVmsByDataCenterIdQuery
..
Patch Set 2: Abandoned
the queries don't match the requirements.for the network main tab.
--
To view, visit http://gerrit.ovirt.or
Moti Asayag has abandoned this change.
Change subject: engine: Add VmDao.getAllWithoutNetwork
..
Patch Set 2: Abandoned
the queries don't match the requirements.for the network main tab.
--
To view, visit http://gerrit.ovirt.o
Moti Asayag has abandoned this change.
Change subject: engine: Add GetVmsWithoutNetworkQuery
..
Patch Set 3: Abandoned
the queries don't match the requirements.for the network main tab.
--
To view, visit http://gerrit.ovirt.or
Gal Hammer has posted comments on this change.
Change subject: guest-agent: Unification of line endings to unix
..
Patch Set 5: No score
--
To view, visit http://gerrit.ovirt.org/9463
To unsubscribe, visit http://gerrit.ovirt.o
Gal Hammer has abandoned this change.
Change subject: agent: apply virtual-guest tuning profile on installation.
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/9361
To unsubscribe, visit http://gerrit.ovirt
Gal Hammer has posted comments on this change.
Change subject: Let udev reset user rights on virtio-channel during package
removal
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Michael Pasternak has posted comments on this change.
Change subject: restapi: Add "All-Content" Header.
..
Patch Set 3: I would prefer that you didn't submit this
Ori,
good job, but the thing is this patch breaks backward com
Roy Golan has posted comments on this change.
Change subject: core: introduce InternalMigrateVmParameters
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10319
To unsubscribe, visit http://g
Roy Golan has posted comments on this change.
Change subject: core: cleanup RunVmCommand#statelessVmTreatment
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10331
To unsubscribe, visit http
Ori Liel has submitted this change and it was merged.
Change subject: restapi: #839205 Display Host Hooks
..
restapi: #839205 Display Host Hooks
https://bugzilla.redhat.com/839205
Change-Id: I38a3d38cc52d5ec77f55fe7db4d5e47b09
Ori Liel has posted comments on this change.
Change subject: restapi: #839205 Display Host Hooks
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9478
To unsubscribe, visit http://g
Ori Liel has posted comments on this change.
Change subject: restapi: #839205 Display Host Hooks
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9478
To unsubscribe, visit http://g
Mike Kolesnik has posted comments on this change.
Change subject: engine: Add GetVmsByDataCenterIdQuery
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10340
To unsubscribe, visit http://ger
Ori Liel has posted comments on this change.
Change subject: restapi: add /disks sub-collection to /storagedomain resource
..
Patch Set 2: (2 inline comments)
looks great, only some missing tests
..
Liron Aravot has posted comments on this change.
Change subject: core: add comments to addDiskCommand
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/10344
To unsubscribe, visit http://gerrit.ovirt.org/settin
Alon Bar-Lev has posted comments on this change.
Change subject: engine: remove Config dependency from frontend
..
Patch Set 2:
Someone should review this, no?
--
To view, visit http://gerrit.ovirt.org/10330
To unsubscribe, vi
ofri masad has posted comments on this change.
Change subject: userportal: Change VerticalPanel to FlowPanel
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10328
To unsubscribe, visit http://gerrit.ovirt.org
Gilad Chaplik has posted comments on this change.
Change subject: engine: remove Config dependency from frontend
..
Patch Set 2:
do you want me to merge it?
--
To view, visit http://gerrit.ovirt.org/10330
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: engine: remove Config dependency from frontend
..
Patch Set 2:
I don't understand any of this.. :)
But I do see that it fetch it from server now using some magic
Liron Aravot has uploaded a new change for review.
Change subject: core: add comments to addDiskCommand
..
core: add comments to addDiskCommand
In case of async task execution, we need to set the found storage domain
id in the p
Gilad Chaplik has posted comments on this change.
Change subject: engine: remove Config dependency from frontend
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10330
To unsubscribe, visit http://gerrit.ovirt
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: error when adding disks without specifying storage domain
..
core: error when adding disks without specifying storage domain
When adding a disk and
Maor Lipchuk has posted comments on this change.
Change subject: core: error when adding disks without specifying storage domain
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10289
To unsu
Liron Aravot has posted comments on this change.
Change subject: core: error when adding disks without specifying storage domain
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
+1 from Vered
--
To vie
1 - 100 of 172 matches
Mail list logo
