Michael Pasternak has posted comments on this change.

Change subject: restapi: Add "All-Content" Header.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

Ori,

good job, but the thing is this patch breaks backward compatibility with api =< 
3.2, it won't display populate() content that was available then, to fix that:

1. take old doPopulate() content out of doPopulate() in to the method x() that 
will be always called regardless of all-content header

2. deprecate x() till 4.1 (ask for documentation on this)

3. leave all new (3.2) content of doPopulate() in doPopulate()

--
To view, visit http://gerrit.ovirt.org/9815
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0faf2843ec368fafd5270dc23d711d0710bd48
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to