Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing UpdateSpmHostNameVDSCommand class
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9572
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing UpdateSpmHostNameVDSCommand class
..
Patch Set 1:
My bad, host_name does not exist at PermittedFields, so we are ok here.
--
To view, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing UpdateSpmHostNameVDSCommand class
..
Patch Set 1:
I agree with Kublin here.
Changing of this field will cause host installation not to work.
Ku
Michael Pasternak has posted comments on this change.
Change subject: core: Rename ad_groups class to AdGroups
..
Patch Set 3: Looks good to me, but someone else must approve
+1 for the api
--
To view, visit http://gerrit.ovir
Michael Pasternak has posted comments on this change.
Change subject: restapi: generate new JSESSIONID when Authorization header
specified
..
Patch Set 2: (1 inline comment)
Roy Golan has posted comments on this change.
Change subject: engine: Support diversified permission collections in MLA
..
Patch Set 2: (3 inline comments)
I think the API is very complex and confusing now and CommandBase just
Ravi Nori has posted comments on this change.
Change subject: core: Newly added domain is always before the old one
..
Patch Set 4: Verified
Verified with multiple domains
--
To view, visit http://gerrit.ovirt.org/9140
To unsu
Livnat Peer has posted comments on this change.
Change subject: engine: vmstatic and vmbase cleanup
..
Patch Set 2: Looks good to me, but someone else must approve
Hi Laszlo,
This is a great clean-up.
My only concern here is th
Oved Ourfali has posted comments on this change.
Change subject: restapi: generate new JSESSIONID when Authorization header
specified
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: core: Rename ad_groups class to AdGroups
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/c
Yair Zaslavsky has posted comments on this change.
Change subject: core: Rename ad_groups class to AdGroups
..
Patch Set 3:
Hi Sharad,
If you go for this change - I would recommend to change the name to one of the
following:
1
Allon Mureinik has posted comments on this change.
Change subject: engine: Cleanup network commands
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9546
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 4: (3 inline comments)
Suggested a different approach using each ListModel's getTitle() -
Michael Kublin has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
..
Patch Set 3:
Actually, the deadlock much more simple. Order of locks at
_updatingTimer_Elapsed is inc
Liron Aravot has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
..
Patch Set 3: I would prefer that you didn't submit this
possible deadlock now - correct me if i'm wrong.
Sharad Mishra has posted comments on this change.
Change subject: core: Rename ad_groups class to AdGroups
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9835
To unsubscribe, visit http://gerrit.ovirt.org/se
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add rhel specific packaging behaviour
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9984
To unsubscrib
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: add rhel specific packaging behaviour
..
packaging: add rhel specific packaging behaviour
Change-Id: I8e550409611fac2e2f16645fdc2370db011dd49b
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: update spec revision
..
packaging: update spec revision
Change-Id: I0ae951691360547e3f63f61d1b7834d885363ddc
Signed-off-by: Alon Bar-Lev
---
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: update spec revision
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9983
To unsubscribe, visit http://g
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add rhel specific packaging behaviour
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9982
To unsubscrib
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: add rhel specific packaging behaviour
..
packaging: add rhel specific packaging behaviour
Change-Id: I31c7311094f8d1cfdee5c80e468d9cda512b5990
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: add rhel specific packaging behaviour
..
packaging: add rhel specific packaging behaviour
Change-Id: I8e550409611fac2e2f16645fdc2370db011dd49b
Signed-
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: update spec revision
..
packaging: update spec revision
Change-Id: I0ae951691360547e3f63f61d1b7834d885363ddc
Signed-off-by: Alon Bar-Lev
---
M config
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: add rhel specific packaging behaviour
..
packaging: add rhel specific packaging behaviour
Change-Id: I31c7311094f8d1cfdee5c80e468d9cda512b5990
Signed-
Alexander Wels has abandoned this change.
Change subject: webadmin: updated descriptions
..
Patch Set 1: Abandoned
Accidentally uploaded as new commit instead of amend.
--
To view, visit http://gerrit.ovirt.org/9831
To unsubsc
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fix appearance of a "Test" button on host dialog
(#877814)
..
Patch Set 4: Looks good to me, approved
(1 inline comment)
..
Moti Asayag has posted comments on this change.
Change subject: engine: Extend NetworkDao
..
Patch Set 7:
Also added tests for the filtered queries.
--
To view, visit http://gerrit.ovirt.org/9543
To unsubscribe, visit http://g
Moti Asayag has posted comments on this change.
Change subject: engine: Improve permissions queries
..
Patch Set 1:
please note that permissions on network feature intends to add the following
patch;
http://gerrit.ovirt.org/#
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: JP date format uses mins instead of month
..
webadmin: JP date format uses mins instead of month
mm is minutes
MM is month
Change-Id: I94379680
Einav Cohen has posted comments on this change.
Change subject: webadmin: JP date format uses mins instead of month
..
Patch Set 2: Verified; Looks good to me, approved
- rebased
- verified in Japanese in both FF and Chrome
- f
Moti Asayag has posted comments on this change.
Change subject: engine: Extend NetworkDao
..
Patch Set 7: (1 inline comment)
File
backend/manager/modules/dal/src/test/java/o
Moti Asayag has posted comments on this change.
Change subject: engine: Modify Network Assign to Cluster Command permissions
..
Patch Set 7: (1 inline comment)
File
backend/
Moti Asayag has posted comments on this change.
Change subject: engine: vmstatic and vmbase cleanup
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/common/s
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: no localization for command buttons strings
..
webadmin: no localization for command buttons strings
As a result of Idd623481d0eb77bfbaa1e8b3eec
Einav Cohen has posted comments on this change.
Change subject: webadmin: no localization for command buttons strings
..
Patch Set 6: Verified; Looks good to me, approved
- rebased
- verified on Chrome and FF, for both English
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Fixing refresh issues in Cluster Services
..
webadmin: Fixing refresh issues in Cluster Services
Empty services tab will be shown if the selected cluste
Michael Kublin has posted comments on this change.
Change subject: perform connectStorageServer to hosts after during
reconstruct/recovery(#880180)
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: engine-manage-domains -addPermissions doesn't work on F18
..
tools: engine-manage-domains -addPermissions doesn't work on F18
The -addpermission
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-manage-domains -addPermissions doesn't work on F18
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9857
To unsubscribe, visit h
Ravi Nori has posted comments on this change.
Change subject: tools: engine-manage-domains -addPermissions doesn't work on F18
..
Patch Set 1: Verified
I installed F18 and installed the latest nightly build
ovirt-engine-3.2.0-
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-manage-domains -addPermissions doesn't work on F18
..
Patch Set 1: Looks good to me, approved
Please add the verified mark, and provide a few line
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-manage-domains -addPermissions doesn't work on F18
..
tools: engine-manage-domains -addPermissions doesn't work on F18
The -addpermissions doesn't wor
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: styling main view draggers
..
webadmin: styling main view draggers
Main view SplitLayoutPanel's draggers:
modified dimensions and color.
Change
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: styling tabs top bar border
..
webadmin: styling tabs top bar border
Modified MainTab/SubTab top bar border's height
Change-Id: Icac354fb9f6033
Einav Cohen has posted comments on this change.
Change subject: webadmin: styling main view draggers
..
Patch Set 6: Verified; Looks good to me, approved
- rebased
- verified on both FF and Chrome
--
To view, visit http://gerr
Einav Cohen has posted comments on this change.
Change subject: webadmin: styling tabs top bar border
..
Patch Set 5: Verified; Looks good to me, approved
- rebased
- verified on both FF and Chrome
--
To view, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Eli Mesika has posted comments on this change.
Change subject: core: Add function for adding action group to a role
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9832
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: packaging: Adding utility functions
..
Patch Set 1: (3 inline comments)
File packaging/fedora/setup/common_
Juan Hernandez has posted comments on this change.
Change subject: packaging: Adding utility functions
..
Patch Set 1: (3 inline comments)
File packaging/fedora/setup/common_
Alex Lourie has posted comments on this change.
Change subject: packaging: Adding utility functions
..
Patch Set 1: Verified
Verified by using created functions in few tests.
--
To view, visit http://gerrit.ovirt.org/9856
To u
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Adding utility functions
..
packaging: Adding utility functions
* Added a renameParam function that allows renaming a param in
a TextConfig file.
* Imp
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 1: (4 inline comments)
I understood the general approach, and I agree.
However, I would prefer if w
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: replacing hourglass icon (locked status)
..
webadmin: replacing hourglass icon (locked status)
Replacing hourglass icon.
Used for:
* Locked stat
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: footer splitter jumps down on catch
..
webadmin: footer splitter jumps down on catch
Fixed bottom footer splitter:
jumps down 26px when catching
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: clear search button resets search incorrectly
..
webadmin: clear search button resets search incorrectly
Clear search button sets 'searchString'
Einav Cohen has posted comments on this change.
Change subject: webadmin: replacing hourglass icon (locked status)
..
Patch Set 7: Verified; Looks good to me, approved
- rebased
- verified on both FF and Chrome
--
To view, vis
Einav Cohen has posted comments on this change.
Change subject: webadmin: clear search button resets search incorrectly
..
Patch Set 6: Verified; Looks good to me, approved
- rebased
- verified on both FF and Chrome
--
To view
Einav Cohen has posted comments on this change.
Change subject: webadmin: footer splitter jumps down on catch
..
Patch Set 6: Verified; Looks good to me, approved
- rebased
- verified on both FF and Chrome
--
To view, visit ht
Yaniv Dary has posted comments on this change.
Change subject: etl: updated working version to TOS 5.1.2
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9853
To unsubscribe, visit
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: updated working version to TOS 5.1.2
..
etl: updated working version to TOS 5.1.2
Change-Id: I5f573bc90f822c6fb995a74db1dd693fe7b86de7
Signed-off-by:
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: change etl version to 3.2
..
etl: change etl version to 3.2
Change-Id: I1eeb89816d47f698e97a0fe99af4b7e69142688e
Signed-off-by: Yaniv Dary
---
M Make
Yaniv Dary has posted comments on this change.
Change subject: etl: change etl version to 3.2
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9852
To unsubscribe, visit http://gerr
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: added aggregation of user usage data
..
etl: added aggregation of user usage data
Change-Id: I8bdb7c4f194ecbf60bd37dc970066875b27cef9b
Signed-off-by:
Yaniv Dary has posted comments on this change.
Change subject: etl: added aggregation of user usage data
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9851
To unsubscribe, visit
Yaniv Dary has posted comments on this change.
Change subject: history: added users statistics tables
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9850
To unsubscribe, visit htt
Yaniv Dary has submitted this change and it was merged.
Change subject: history: added users statistics tables
..
history: added users statistics tables
Change-Id: Ic5f3e2efe1e2043edbb75b02163afb0f7bfa62fb
Signed-off-by: Yaniv
Yaniv Dary has posted comments on this change.
Change subject: history: updated create db scripts
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9849
To unsubscribe, visit http://
Yaniv Dary has submitted this change and it was merged.
Change subject: history: updated create db scripts
..
history: updated create db scripts
Change-Id: Ie37e2cbaed39f426b43e309b4ec83a963afa6819
Signed-off-by: Yaniv Dary
--
Yaniv Dary has posted comments on this change.
Change subject: reports: removed tabs from files
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9848
To unsubscribe, visit http://ge
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: removed tabs from files
..
reports: removed tabs from files
Change-Id: Ib886c6ad1a30c88dbd3ec110e65191fa72a200bb
Signed-off-by: Yaniv Dary
---
M
Eli Mesika has posted comments on this change.
Change subject: history: added users statistics tables
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9850
To unsubscribe, visit http://gerrit
Juan Hernandez has posted comments on this change.
Change subject: core: Fixed invalid HTML in index and 404.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9773
To uns
Eli Mesika has posted comments on this change.
Change subject: history: updated create db scripts
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9849
To unsubscribe, visit http://gerrit.ovi
Eli Mesika has posted comments on this change.
Change subject: reports: removed tabs from files
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9848
To unsubscribe, visit http://gerrit.ovirt
Juan Hernandez has posted comments on this change.
Change subject: webadmin: UI Plugins PoC, revision 7 update 3
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9250
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools : engine-manage-domains confirm delete domain
..
tools : engine-manage-domains confirm delete domain
When user deletes a domain using engine-mana
Yair Zaslavsky has posted comments on this change.
Change subject: tools : engine-manage-domains confirm delete domain
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9585
To unsubscribe, vi
Mike Kolesnik has posted comments on this change.
Change subject: engine: Extend NetworkDao
..
Patch Set 7: (1 inline comment)
Please add tests for the filtered method also
Ravi Nori has posted comments on this change.
Change subject: tools : engine-manage-domains confirm delete domain
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9585
To unsubscribe, visit http://gerrit.ovirt
Juan Hernandez has posted comments on this change.
Change subject: webadmin: UI Plugins PoC, revision 6
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8120
To unsubscri
Sharad Mishra has posted comments on this change.
Change subject: core: VM.setStaticData cleanup
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Mike Kolesnik has posted comments on this change.
Change subject: engine: Add option to create network for public use
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9541
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: core: Newly added domain is always before the old one
..
Patch Set 3:
Looks good to me.
Ravi - please verify with add/set of multiple domains, feel free to use
Yair Zaslavsky has posted comments on this change.
Change subject: core: Newly added domain is always before the old one
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9140
To unsubscribe,
Libor Spevak has uploaded a new change for review.
Change subject: restapi: Do not return VM ticket if not needed
..
restapi: Do not return VM ticket if not needed
Do not return a generated ticket using REST API, if the user doe
Mike Kolesnik has posted comments on this change.
Change subject: engine: Modify Network Assign to Cluster Command permissions
..
Patch Set 7: (1 inline comment)
File
backen
Sharad Mishra has posted comments on this change.
Change subject: core: Newly added domain is always before the old one
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Improve permissions queries
..
Patch Set 1:
For example, entity_async_tasks work with fn_splitter as well, so if we follow
Eli's comment, we need to ha
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-upgrade - check for free space before upgrade
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Yaniv Dary has uploaded a new change for review.
Change subject: history: added users statistics tables
..
history: added users statistics tables
Change-Id: Ic5f3e2efe1e2043edbb75b02163afb0f7bfa62fb
Signed-off-by: Yaniv Dary
--
Yaniv Dary has uploaded a new change for review.
Change subject: history: updated create db scripts
..
history: updated create db scripts
Change-Id: Ie37e2cbaed39f426b43e309b4ec83a963afa6819
Signed-off-by: Yaniv Dary
---
M data
Yaniv Dary has uploaded a new change for review.
Change subject: reports: removed tabs from files
..
reports: removed tabs from files
Change-Id: Ib886c6ad1a30c88dbd3ec110e65191fa72a200bb
Signed-off-by: Yaniv Dary
---
M data-war
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Improve permissions queries
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
please Follow Eli's comment.
This might
Yaniv Dary has abandoned this change.
Change subject: history: updated create db scripts
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/9333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Yaniv Dary has abandoned this change.
Change subject: history: added user tables
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/9332
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageTyp
Yaniv Dary has abandoned this change.
Change subject: history: added users tables views
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/9334
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Yaniv Dary has abandoned this change.
Change subject: etl: added aggregation of user usage data
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/9335
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Yaniv Dary has abandoned this change.
Change subject: etl: change etl version to 3.2
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/9336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messag
1 - 100 of 174 matches
Mail list logo
