[Engine-patches] Change in ovirt-engine[master]: core: Adding LIO iSCSI target as ... (#879272)

2012-12-01 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Adding LIO iSCSI target as ... (#879272) .. Patch Set 2: Looks good to me, approved Small question: shouldn't the upgrade script be called 03_02_0010_exte

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: updated stranslated strings

2012-12-01 Thread masayag
Moti Asayag has posted comments on this change. Change subject: userportal,webadmin: updated stranslated strings .. Patch Set 1: If the message should end with a white space - i guess that's the way it should be. Having trail

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: updated stranslated strings

2012-12-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: updated stranslated strings .. Patch Set 1: - commit comment will be fixed - Note that: - all files in the patch are auto-generated from Z

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix focus traversal in make template

2012-12-01 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: fix focus traversal in make template .. Patch Set 2: (1 inline comment) Commit Message Line 12: - the

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: updated stranslated strings

2012-12-01 Thread masayag
Moti Asayag has posted comments on this change. Change subject: userportal,webadmin: updated stranslated strings .. Patch Set 1: (1 inline comment) In addition to the type in commit message, few of the files contain trailing w

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: updated stranslated strings

2012-12-01 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: updated stranslated strings .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9610 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in otopi[master]: core: check minimum python version

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: core: check minimum python version .. core: check minimum python version Change-Id: If63068befd1a28e2bbc187ab77b0835ab18db36d Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in otopi[master]: core: check minimum python version

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: check minimum python version .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9609 To unsubscribe, visit http:

[Engine-patches] Change in otopi[master]: core: check minimum python version

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: check minimum python version .. core: check minimum python version Change-Id: If63068befd1a28e2bbc187ab77b0835ab18db36d Signed-off-by: Alon Bar-Lev --- M

[Engine-patches] Change in ovirt-host-deploy[master]: tests: use python to untar as tar of rhel-5.5 does not detec...

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tests: use python to untar as tar of rhel-5.5 does not detect end-of-tar correctly .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://

[Engine-patches] Change in ovirt-host-deploy[master]: tests: use python to untar as tar of rhel-5.5 does not detec...

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: tests: use python to untar as tar of rhel-5.5 does not detect end-of-tar correctly .. tests: use python to untar as tar of rhel-5.5 does not detect end-o

[Engine-patches] Change in ovirt-host-deploy[master]: tests: use python to untar as tar of rhel-5.5 does not detec...

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: tests: use python to untar as tar of rhel-5.5 does not detect end-of-tar correctly .. tests: use python to untar as tar of rhel-5.5 does not detect end-of-tar c

[Engine-patches] Change in ovirt-host-deploy[master]: doc: update ChangeLog

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: update ChangeLog .. doc: update ChangeLog Change-Id: I176342cc2edaeffe28f95b2fa7ad4c66dab42a45 Signed-off-by: Alon Bar-Lev --- M ChangeLog 1 file c

[Engine-patches] Change in ovirt-host-deploy[master]: doc: update ChangeLog

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: update ChangeLog .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9607 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-host-deploy[master]: doc: update ChangeLog

2012-12-01 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: doc: update ChangeLog .. doc: update ChangeLog Change-Id: I176342cc2edaeffe28f95b2fa7ad4c66dab42a45 Signed-off-by: Alon Bar-Lev --- M ChangeLog 1 file changed,

[Engine-patches] Change in ovirt-engine[master]: core: Remove SQL Server engine dialect

2012-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Remove SQL Server engine dialect .. Patch Set 1: Also , saw this options in DB , so I think to complete that , should also be removed with all relevant code

[Engine-patches] Change in ovirt-engine[master]: Adding system information to getCapabilities from host

2012-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Adding system information to getCapabilities from host .. Patch Set 4: (3 inline comments) Also keep in mind that we already have a 03_01_1520 script , so , you wil

[Engine-patches] Change in ovirt-engine[master]: core: Move quota to Image_storage_domain_map

2012-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Move quota to Image_storage_domain_map .. Patch Set 3: Looks good to me, but someone else must approve +2 on DB stuff Please make sure to rename upgrade scri

[Engine-patches] Change in ovirt-engine[master]: core: Removing last host in status UP in pool

2012-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Removing last host in status UP in pool .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) ..

[Engine-patches] Change in ovirt-engine[master]: engine: Removed useless checks at ConnectHostToStoragePoolSe...

2012-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: Removed useless checks at ConnectHostToStoragePoolServersCommand .. Patch Set 1: (1 inline comment) Co

[Engine-patches] Change in ovirt-engine[master]: core: Remove PGHack

2012-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Remove PGHack .. Patch Set 1: AFAIK we don't need that anymore, please wait for Itamar confirmation since he is more familiar with that and IIRC wrote this f

[Engine-patches] Change in ovirt-engine[master]: engine: engine-config cleanup all 2.2 keys from db

2012-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: engine-config cleanup all 2.2 keys from db .. Patch Set 5: (1 inline comment) File backend/manager/dbsc

[Engine-patches] Change in ovirt-engine[master]: core: Remove SQL Server engine dialect

2012-12-01 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Remove SQL Server engine dialect .. Patch Set 1: this patch should remove SQLServerDataTypeFactory as well -- To view, visit http://gerrit.ovirt.org/9580 To