Eli Mesika has posted comments on this change. Change subject: engine: Removed useless checks at ConnectHostToStoragePoolServersCommand ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 6: Line 7: engine: Removed useless checks at ConnectHostToStoragePoolServersCommand Line 8: Line 9: The following checks at canDoaction are useless, the command is called only once form Line 10: InitVdsOnUp and the same checks are performed before a call to command I wonder why not removing this code from InitVdsOnUp and leave the canDo code for the chance that it will be called from another place in future ... Line 11: Line 12: Change-Id: I25c6f4db1108b513663b81fbc7956e66edd9c797 -- To view, visit http://gerrit.ovirt.org/9567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25c6f4db1108b513663b81fbc7956e66edd9c797 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
