Kiril Nesenko has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing (#BZ870070)
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view
Moti Asayag has submitted this change and it was merged.
Change subject: core: Integer reference comparison fix
..
core: Integer reference comparison fix
Changed the comparison from reference comparison(==) to equals on
Integer
Moti Asayag has posted comments on this change.
Change subject: core: Integer reference comparison fix
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9104
To unsubscribe, visit ht
Moti Asayag has posted comments on this change.
Change subject: core: Integer reference comparison fix
..
Patch Set 1: Looks good to me, approved
Allon,
brick_order is not defined as 'not null' but has a default on
gluster_v
Shireesh Anjal has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 1: No score
(1 inline comment)
Liron Aravot has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
Patch Set 1: (1 inline comment)
File
backen
Allon Mureinik has posted comments on this change.
Change subject: core: Integer reference comparison fix
..
Patch Set 1: Looks good to me, but someone else must approve
Laszlo - I understand the difference between reference co
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Gluster Volume Profile Info Query
..
Patch Set 5: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/8646
To unsubscribe, visit http://ge
Shireesh Anjal has posted comments on this change.
Change subject: core: Integer reference comparison fix
..
Patch Set 1: Looks good to me, but someone else must approve
Thanks for fixing my bug :)
--
To view, visit http://ger
Shireesh Anjal has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment
Shireesh Anjal has posted comments on this change.
Change subject: core: WIP: Adding compatibility version support for GlusterFS.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Shireesh Anjal has posted comments on this change.
Change subject: core: WIP: StorageHelper class for GlusterFS.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8834
To
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 2: I would prefer that you didn't submit this
Hi Ravi,
The change at AddVmCommand bothers me
Hunt Xu has uploaded a new change for review.
Change subject: packaging: fix usage & prompt messages of the mac-range option
..
packaging: fix usage & prompt messages of the mac-range option
The string "MAC range" should better
Hunt Xu has uploaded a new change for review.
Change subject: packaging: enable overriding default value of an option with
commandline
..
packaging: enable overriding default value of an option with commandline
For the value of
Michael Kublin has posted comments on this change.
Change subject: core: Disallow from remove of a DC when not all hosts are in
maintenance (#850286)
..
Patch Set 1: (1 inline comment)
.
Michael Kublin has posted comments on this change.
Change subject: core: Disallow from remove of a DC when not all hosts are in
maintenance (#850286)
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment
Michael Kublin has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
Patch Set 1: (2 inline comments)
File
bac
Sharad Mishra has uploaded a new change for review.
Change subject: webadmin: WIP: Add GlusterStorageView widget.
..
webadmin: WIP: Add GlusterStorageView widget.
Added xml that defines GlusterStorageView.
Change-Id: I6dd10a2d1
Eli Mesika has submitted this change and it was merged.
Change subject: core:PCI addresses are deleted when VM...(#873581)
..
core:PCI addresses are deleted when VM...(#873581)
PCI addresses are deleted when VM Template is impo
Eli Mesika has posted comments on this change.
Change subject: core:PCI addresses are deleted when VM...(#873581)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9087
To unsubscrib
Sharad Mishra has abandoned this change.
Change subject: api: WIP: Add Gluster FS to api StorageType.
..
Patch Set 1: Abandoned
Change already included in Change-Id: I611b233b3e69c390423123bd083dee3463a151b8
--
To view, visit
Moti Asayag has posted comments on this change.
Change subject: core:PCI addresses are deleted when VM...(#873581)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9087
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: core:PCI addresses are deleted when VM...(#873581)
..
Patch Set 3: (2 inline comments)
File
backend/manager/mo
Kiril Nesenko has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing
..
Patch Set 6: (1 inline comment)
Please improve a commit message
..
Tal Nisan has uploaded a new change for review.
Change subject: core: Disallow from remove of a DC when not all hosts are in
maintenance (#850286)
..
core: Disallow from remove of a DC when not all hosts are in maintenance
(#85
Sharad Mishra has posted comments on this change.
Change subject: core: Integer reference comparison fix
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/
Allon Mureinik has posted comments on this change.
Change subject: core: fix imports in MoveImageGroupVDSCommand
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9094
To
Barak Azulay has posted comments on this change.
Change subject: agent: added win8 and win2012 to reported os version.
..
Patch Set 1:
please verify and check the verify flag
--
To view, visit http://gerrit.ovirt.org/9010
To u
Allon Mureinik has posted comments on this change.
Change subject: webadmin: no compat version for exported vm
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9100
To un
Alon Bar-Lev has posted comments on this change.
Change subject: core: fix imports in MoveImageGroupVDSCommand
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9094
To un
Daniel Erez has submitted this change and it was merged.
Change subject: core: VmBase - diskList member - remove final
..
core: VmBase - diskList member - remove final
Removing 'final' keyword from diskList member in VmBase.
GW
Daniel Erez has posted comments on this change.
Change subject: core: VmBase - diskList member - remove final
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9107
To unsub
Daniel Erez has posted comments on this change.
Change subject: core: VmBase - diskList member - remove final
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9107
To unsubscribe, visit http:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Failed move disk should not set illegal disk.
..
core: Failed move disk should not set illegal disk.
When disk failed to be moved to another storag
Maor Lipchuk has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9103
To unsubsc
Maor Lipchuk has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9103
To unsubsc
Daniel Erez has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9103
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
I don't understand
Daniel Erez has posted comments on this change.
Change subject: webadmin: no compat version for exported vm
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9100
To unsubscribe, visit http://
Michael Kublin has posted comments on this change.
Change subject: core: VmBase - diskList member - remove final
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9107
To unsubscribe, visit ht
Liron Aravot has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9103
Daniel Erez has posted comments on this change.
Change subject: core: VmBase - diskList member - remove final
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9107
To unsubscribe, visit http://gerrit.ovirt.org
Omer Frenkel has submitted this change and it was merged.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
core: use String instead of StringBuilder in SysprepHandler (#873742)
SysprepHa
Omer Frenkel has posted comments on this change.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9102
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: VmBase - diskList member - remove final
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9107
To
Maor Lipchuk has posted comments on this change.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9102
T
Daniel Erez has uploaded a new change for review.
Change subject: core: VmBase - diskList member - remove final
..
core: VmBase - diskList member - remove final
Removing 'final' keyword from diskList member in VmBase.
GWT RPC do
Omer Frenkel has posted comments on this change.
Change subject: engine: Get Gluster Volume Profile Info Query
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8646
To unsubscribe, visit http
Omer Frenkel has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9103
Arik Hadas has posted comments on this change.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
Patch Set 1: (1 inline comment)
File
Arik Hadas has posted comments on this change.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Maor Lipchuk has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
..
Patch Set 2: Looks good to me, but someone else must approve
+1 from Ofrenkel.
Changes as Liron commented:
Liron Aravot has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
..
Patch Set 1: (4 inline comments)
File
backend/manager
Liron Aravot has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
Patch Set 1: (2 inline comments)
File
backe
Omer Frenkel has posted comments on this change.
Change subject: core: Failed move disk should not set illegal disk.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9103
Allon Mureinik has posted comments on this change.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
..
Juan Hernandez has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit htt
Allon Mureinik has posted comments on this change.
Change subject: core: removed getVmNetworkInterfaceDao
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9105
To unsubsc
Liron Aravot has uploaded a new change for review.
Change subject: core: NPEs in AddVmTemplate.endSuccesfully after engine crash
..
core: NPEs in AddVmTemplate.endSuccesfully after engine crash
AddVmTemplateCommand endSuccesfull
Allon Mureinik has posted comments on this change.
Change subject: core: Integer reference comparison fix
..
Patch Set 1:
what is the significance of using ObjectUtils.objectsEqual, as opposed to just
equals?
--
To view, visi
Moti Asayag has posted comments on this change.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
Patch Set 1: (1 inline comment)
File
Michal Skrivanek has posted comments on this change.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
Patch Set 1: (1 inline comment)
Moti Asayag has posted comments on this change.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Failed move disk should not set illegal disk.
..
core: Failed move disk should not set illegal disk.
When disk failed to be moved to another storage domain
Shahar Havivi has posted comments on this change.
Change subject: webadmin: reformat remove disk messages
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9101
To unsubscribe, visit http://gerrit.ovirt.org/set
Omer Frenkel has uploaded a new change for review.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
..
core: use String instead of StringBuilder in SysprepHandler (#873742)
SysprepHandler us
Shahar Havivi has uploaded a new change for review.
Change subject: webadmin: reformat remove disk messages
..
webadmin: reformat remove disk messages
Change-Id: I20172c8e70659a6fa5f77dec738d1c9025daac70
Bug-Id: https://bugzilla
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - parameters
..
Patch Set 11: (10 inline comments)
File
backend/manager/modules/bll/src/m
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: no compat version for exported vm
..
webadmin: no compat version for exported vm
Due to a change in the backend side, while fetching an exported vm,
t
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager
..
Patch Set 15: (27 inline comments)
File
backend/manager/modules/bll/src
Gal Hammer has posted comments on this change.
Change subject: agent: added win8 and win2012 to reported os version.
..
Patch Set 1:
I agree that a general solution is possible but I'll consider it when Windows 9
will be out ;
Moti Asayag has posted comments on this change.
Change subject: core:PCI addresses are deleted when VM...(#873581)
..
Patch Set 3: (2 inline comments)
minor comment about naming convention
.
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: fix fixtures.xml
..
core: fix fixtures.xml
Removed the hypervisor_type column from fixtures.xml to fix the DAO
tests.
Change-Id: I237ffd0eaebc6d
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix fixtures.xml
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9099
To unsubscribe, visit http://gerrit.o
Eli Mesika has posted comments on this change.
Change subject: core:PCI addresses are deleted when VM...(#873581)
..
Patch Set 2: (1 inline comment)
File
backend/manager/mod
Michael Kublin has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 1: (5 inline comments)
"some general notes: 1. You have the "ge
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Volume Brick - Advanced Details
..
webadmin: Gluster Volume Brick - Advanced Details
A new action 'Advanced Details' is added to the B
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Volume Brick - Advanced Details
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8898
To unsubscribe, visit
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Adding Gluster Services Sub Tab to Cluster
..
webadmin: Adding Gluster Services Sub Tab to Cluster
A new sub tab named 'Services' is added to
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Adding Gluster Services Sub Tab to Cluster
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8460
To unsubscribe, vi
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Gluster Volume Brick - Advanced Details
..
Patch Set 4: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/8898
To unsubscribe, vi
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Adding Gluster Services Sub Tab to Cluster
..
Patch Set 7: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/8460
To unsubscribe,
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2811/
Build Number: 2811
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,429
-
Changes Since
Vinzenz Feenstra has posted comments on this change.
Change subject: agent: added win8 and win2012 to reported os version.
..
Patch Set 1: Looks good to me, but someone else must approve
I think it is fine for now, however we s
Shireesh Anjal has posted comments on this change.
Change subject: engine: Removed unnecessary 'continue' statements
..
Patch Set 2: (1 inline comment)
File
backend/manager/
Allon Mureinik has posted comments on this change.
Change subject: core: compensate on wrong object lead to NPE
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9074
To u
Allon Mureinik has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 1: (7 inline comments)
some general notes:
1. You have the "get
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 1: (2 inline comments)
File backend/manager/modules/dal/src/main/r
ofri masad has posted comments on this change.
Change subject: core: Quota refactor - test and commands I
..
Patch Set 6: (6 inline comments)
File
backend/manager/modules/bl
Arik Hadas has posted comments on this change.
Change subject: engine: Removed unnecessary 'continue' statements
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Michael Kublin has submitted this change and it was merged.
Change subject: core: import cleanup in AlertDirector.java
..
core: import cleanup in AlertDirector.java
Use fully qualified imports.
Change-Id: If0c2a9f699b4b5e9227a
Michael Kublin has posted comments on this change.
Change subject: core: import cleanup in AlertDirector.java
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9093
To unsub
Michael Kublin has posted comments on this change.
Change subject: core: import cleanup in AlertDirector.java
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9093
To unsubscribe, v
Michael Kublin has posted comments on this change.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9097
To u
Michael Kublin has uploaded a new change for review.
Change subject: engine: Remove IsValidVDSCommand (Preporation for removing
global lock on SPM ops)
..
engine: Remove IsValidVDSCommand (Preporation for removing global lock on
Allon Mureinik has posted comments on this change.
Change subject: core: import cleanup in AlertDirector.java
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9093
To uns
97 matches
Mail list logo
