Alona Kaplan has posted comments on this change. Change subject: webadmin: Messages text fixes ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 358: NETWORK_CHECK_CONNECTIVITY=Cannot check connectivity on non management network. Line 359: NETWORK_BOND_PARAMETERS_INVALID=Invalid parameters.\n\ Line 360: -Please check that bond name is formatted as <bondYYY>.\n\ Line 361: -Bond consist of at least two network interfaces(NICs). Line 362: NETWORK_DEFAULT_UPDATE_NAME_INVALID=Network ovirtmgmt is mandatory, it cannot be modified. Maybe the management network name should be passed as parameter from the backend. It is not necessary ovirtmgmt. Line 363: NETWORK_INTERFACE_ALREADY_IN_BOND=Network Interface already belongs to the bond. Line 364: NETWORK_INVALID_BOND_NAME=Bond name must be formatted as <bondYYY>. Line 365: NETWORK_INTERFACE_NOT_EXISTS=Network name doesn't exist. Line 366: ERROR_CANNOT_ATTACH_MORE_THAN_ONE_ISO_DOMAIN=Cannot attach more than one ISO Storage Domain to the same Data Center. If you want to use a newly created Domain, detach the existing attached Domain and attach the new one. .................................................... Commit Message Line 12: - The management Network (engine) is mandatory and cannot be removed. Line 13: - The default gateway should be set only on engine network Line 14: Line 15: For the messages above (in which "engine" represents the Management Line 16: Network) "engine" was replaced with "ovirtmgmt" The managment network name is a config value. ConfigurationValues.ManagementNetwork should be used and not "ovirtmgmt" Line 17: Line 18: - Internal oVirt Engine Error Line 19: - oVirt Engine has stopped Line 20: - oVirt History Service Started -- To view, visit http://gerrit.ovirt.org/9095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6368f77f174ff17b4f78856d01236eb07bae8e2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
