Ohad Basan has posted comments on this change.
Change subject: packaging: Remove redundant DB user name
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8611
To unsubscri
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Stop Gluster Volume Profile command
..
Patch Set 6: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/8332
To unsubscribe, visit http://gerr
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Start Gluster Volume Profile command
..
Patch Set 10: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/8261
To unsubscribe, visit http://ge
Itamar Heim has posted comments on this change.
Change subject: core: adding engine Maintenance and Prepare mode.(#868639)
..
Patch Set 4:
i don't like black listing in general.
for the queries, since the default is all should
Eli Mesika has uploaded a new change for review.
Change subject: core:Add a script that displays async ...(#868672)
..
core:Add a script that displays async ...(#868672)
Adding a fn_db_get_async_tasks function to the database.
Michael Kublin has uploaded a new change for review.
Change subject: engine: Adding @DisableInMaintenanceMode to RegisterVdsQuery
..
engine: Adding @DisableInMaintenanceMode to RegisterVdsQuery
The following annotation is added
Michael Kublin has uploaded a new change for review.
Change subject: engine: Adding @DisableInPrepareMode to appropriate commands
..
engine: Adding @DisableInPrepareMode to appropriate commands
The following annotation is added
Moran Goldboim has posted comments on this change.
Change subject: packaging: Remove redundant DB user name
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8611
To unsub
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/3090/
Build Number: 3090
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,294
-
Ch
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/3089/
Build Number: 3089
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,293
-
Ayal Baron has posted comments on this change.
Change subject: core: [WIP] VDS Commands for Live Storage Migration
..
Patch Set 21: I would prefer that you didn't submit this
(1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: core: [WIP] Adding VDSM API for LiveStorageMigration
..
Patch Set 20: Looks good to me, but someone else must approve
I always hated the number of changes one has t
Ayal Baron has posted comments on this change.
Change subject: core: avoid having SD active on vdsm and not in engine
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
..
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin,userportal: Use single quote in localization files
..
webadmin,userportal: Use single quote in localization files
This patch replaces double quot
Einav Cohen has posted comments on this change.
Change subject: webadmin,userportal: Use single quote in localization files
..
Patch Set 2: Verified; Looks good to me, approved
- rebased
- removed some trailing white-spaces
- v
Greg Padgett has posted comments on this change.
Change subject: core: Encrypt CHAP credentials in the database
..
Patch Set 7: Verified
Added exit statement to end of upgrade script.
--
To view, visit http://gerrit.ovirt.org/
Itamar Heim has posted comments on this change.
Change subject: core: adding engine Maintenance mode.(#868639)
..
Patch Set 3:
was talking to ayal about this patch.
we may want to modes for it:
1. "prepare" - will block only co
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding timestamp to async tasks ...(#868636)
..
Patch Set 4:
Fix to startTime calculation in async_tasks
--
To view, visit http://gerrit.ovirt.org/8668
T
Yair Zaslavsky has abandoned this change.
Change subject: core: Adding startTime field to async_tasks entity
..
Patch Set 1: Abandoned
Squashed on Eli's patch
--
To view, visit http://gerrit.ovirt.org/8722
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding timestamp to async tasks ...(#868636)
..
Patch Set 3:
Another change from patchset2:
Following Itamar's comments and discussion with Kublin and Eli
Tal Nisan has posted comments on this change.
Change subject: userportal: Modified columns in Templates->Disk subtab
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8729
To unsubscribe, visi
Asaf Shakarchi has uploaded a new change for review.
Change subject: userportal: Modified columns in Templates->Disk subtab
..
userportal: Modified columns in Templates->Disk subtab
In PowerUser interface, changed the following
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal+core: Cannot change VM cluster in UP (#863139)
..
userportal+core: Cannot change VM cluster in UP (#863139)
https://bugzilla.redhat.com/863139
Oved Ourfali has posted comments on this change.
Change subject: userportal+core: Cannot change VM cluster in UP (#863139)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8724
To u
Oved Ourfali has posted comments on this change.
Change subject: userportal+core: Cannot change VM cluster in UP (#863139)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8724
To unsubscribe, visit http://ger
Daniel Erez has posted comments on this change.
Change subject: userportal+core: Cannot change VM cluster in UP (#863139)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8724
To unsubscribe,
Juan Hernandez has posted comments on this change.
Change subject: packaging: Added a functionality for interaction with user
..
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
I am really curi
Eli Mesika has posted comments on this change.
Change subject: core: adding engine Maintenance mode.(#868639)
..
Patch Set 3:
Kublin will add handling of RunQuery using @disableInMaintenanceMode
annotation on queries that sho
Ricky Hopper has uploaded a new change for review.
Change subject: core: Add scan domain query (revised)
..
core: Add scan domain query (revised)
Update of query in response to code review. Some comments:
1) The reason this ret
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add search for Networks
..
engine: Add search for Networks
The patch adds support for Networks entities in search engine.
The network entities cou
Moti Asayag has submitted this change and it was merged.
Change subject: core,engine: Add NetworkView entity
..
core,engine: Add NetworkView entity
The NetworkView entity represents a view over the network with partial
informat
Moti Asayag has posted comments on this change.
Change subject: core,engine: Add NetworkView entity
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8652
To unsubscribe, visit http:
Moti Asayag has posted comments on this change.
Change subject: engine: Add search for Networks
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8455
To unsubscribe, visit http://ge
Juan Hernandez has posted comments on this change.
Change subject: packaging: Do not allow using ' in passwords
..
Patch Set 1:
And what is the real reason to forbid ' in passwords?
--
To view, visit http://gerrit.ovirt.org/87
Alex Lourie has posted comments on this change.
Change subject: packaging: Do not allow using ' in passwords
..
Patch Set 1: (1 inline comment)
File packaging/fedora/setup/en
Moti Asayag has posted comments on this change.
Change subject: core: Query GetVdsGroupsByNetworkId
..
Patch Set 8: No score
Taking back the +1.
Please note that the returned list should contain all clusters, therefore the
re
Alex Lourie has posted comments on this change.
Change subject: packaging: Do not allow using ' in passwords
..
Patch Set 1:
Alon
First, there's no relation to root password, it is only for the engine
itself/the DB.
Second,
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Do not allow using ' in passwords
..
Patch Set 1: (1 inline comment)
File packaging/fedora/setup/
Yair Zaslavsky has posted comments on this change.
Change subject: userportal+core: Cannot change VM cluster in UP (#863139)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Oved Ourfali has uploaded a new change for review.
Change subject: userportal+core: Cannot change VM cluster in UP (#863139)
..
userportal+core: Cannot change VM cluster in UP (#863139)
https://bugzilla.redhat.com/863139
When t
Michael Kublin has posted comments on this change.
Change subject: core: Adding startTime field to async_tasks entity
..
Patch Set 1:
Please fix a "time" problem that we discussed
--
To view, visit http://gerrit.ovirt.org/8722
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: expose host subject also in VM properties #867513
..
restapi: expose host subject also in VM properties #867513
https://bugzilla.redhat.com
Michael Pasternak has posted comments on this change.
Change subject: restapi: expose host subject also in VM properties #867513
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/869
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding startTime field to async_tasks entity
..
Patch Set 1: Verified
Verified -
1. Saw startTime is written to DB
2. Saw that Zombie task time is calcula
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Do not allow using ' in passwords
..
Patch Set 1:
What if root password does contains '
Or what if dba set the ' char in remote psql?
--
To view, vis
Alex Lourie has posted comments on this change.
Change subject: packaging: Do not allow using ' in passwords
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8723
To unsubscribe, visit http://gerrit.ovirt.org/
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Do not allow using ' in passwords
..
packaging: Do not allow using ' in passwords
Added a check to password validator that denies using
a ' character i
Ori Liel has submitted this change and it was merged.
Change subject: restapi: #864991 - Vm Custom Properties Ignored
..
restapi: #864991 - Vm Custom Properties Ignored
Change-Id: I5d9c4ac782edf1779455aeee4121091199b76b3d
Signe
Ori Liel has posted comments on this change.
Change subject: restapi: #864991 - Vm Custom Properties Ignored
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8706
To unsubscribe, vi
Daniel Erez has submitted this change and it was merged.
Change subject: core: ISO domain permission error shouldn't tirgger SPM
selection.
..
core: ISO domain permission error shouldn't tirgger SPM selection.
Failure while ex
Daniel Erez has posted comments on this change.
Change subject: core: ISO domain permission error shouldn't tirgger SPM
selection.
..
Patch Set 6: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.o
Daniel Erez has posted comments on this change.
Change subject: core: ISO domain permission error shouldn't tirgger SPM
selection.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8690
To un
Michael Pasternak has posted comments on this change.
Change subject: restapi: #864991 - Vm Custom Properties Ignored
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8706
To unsubscribe, vis
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Adding startTime field to async_tasks entity
..
core: Adding startTime field to async_tasks entity
This patch adds startTime field to async_tasks entity
Moti Asayag has posted comments on this change.
Change subject: core: Query GetVdsGroupsByNetworkId
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8426
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: core: New AssertUtils Class
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/utils/src/test/j
Ori Liel has submitted this change and it was merged.
Change subject: restapi: #864840 - Connection Details Mandatory For ISCSI LUN
Disk
..
restapi: #864840 - Connection Details Mandatory For ISCSI LUN Disk
Change-Id: I0b7f4aa
Ori Liel has posted comments on this change.
Change subject: restapi: #864840 - Connection Details Mandatory For ISCSI LUN
Disk
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/872
Moti Asayag has posted comments on this change.
Change subject: core: Move Pair class to common.utils
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8697
To unsubscribe, visit http://gerrit
Omer Frenkel has posted comments on this change.
Change subject: engine: Get Gluster Volume Profile Info Query
..
Patch Set 1: Looks good to me, but someone else must approve
i would like someone from gluster to take a look as
Michael Pasternak has posted comments on this change.
Change subject: restapi: #864840 - Connection Details Mandatory For ISCSI LUN
Disk
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8721
Liron Aravot has posted comments on this change.
Change subject: core: ISO domain permission error shouldn't tirgger SPM
selection.
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/8690
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: core: ISO domain permission error shouldn't tirgger SPM
selection.
..
Patch Set 5:
edited the commit message
--
To view, visit http://gerrit.ovirt.org/8690
To u
Ori Liel has uploaded a new change for review.
Change subject: restapi: #864840 - Connection Details Mandatory For ISCSI LUN
Disk
..
restapi: #864840 - Connection Details Mandatory For ISCSI LUN Disk
Change-Id: I0b7f4aa7fdb5d16
Allon Mureinik has posted comments on this change.
Change subject: core: ISO domain permission error shouldn't tirgger SPM
selection.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://ger
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Increase AJP timeout to 1 hour
..
packaging: Increase AJP timeout to 1 hour
We need this longer timeout from some very long operations perfo
Juan Hernandez has posted comments on this change.
Change subject: packaging: Increase AJP timeout to 1 hour
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view, vis
Barak Azulay has posted comments on this change.
Change subject: packaging: Increase AJP timeout to 1 hour
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8716
To unsubscribe, visit http://g
Liron Aravot has posted comments on this change.
Change subject: core: ISO domain permission error shouldn't tirgger SPM
selection.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8690
To unsubscribe, visit
Itamar Heim has posted comments on this change.
Change subject: core: adding engine Maintenance mode.
..
Patch Set 2:
eli, since maybe compensation or async task handling require to run actions to
rollback/finish.
--
To view,
Omer Frenkel has posted comments on this change.
Change subject: engine: Stop Gluster Volume Profile command
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8332
To unsubscribe, visit http:/
Omer Frenkel has posted comments on this change.
Change subject: engine: Start Gluster Volume Profile command
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8261
To unsubscribe, visit http:
Michael Kublin has posted comments on this change.
Change subject: core: adding engine Maintenance mode.
..
Patch Set 2: I would prefer that you didn't submit this
I don't agree, maintenance mode - stop access operation from us
Oved Ourfali has submitted this change and it was merged.
Change subject: rest: User can't see its permissions (#868304)
..
rest: User can't see its permissions (#868304)
https://bugzilla.redhat.com/868304
When asking for obje
Oved Ourfali has posted comments on this change.
Change subject: rest: User can't see its permissions (#868304)
..
Patch Set 2: Verified; Looks good to me, approved
based on previous ACK
--
To view, visit http://gerrit.ovirt.o
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding timestamp to async tasks ...(#868636)
..
Patch Set 2:
Itamar, I will send a continuing patch to handle start time at async_tasks and
not VdcAction
Michael Pasternak has posted comments on this change.
Change subject: rest: User can't see its permissions (#868304)
..
Patch Set 1: Looks good to me, approved
+2 for api.
--
To view, visit http://gerrit.ovirt.org/8720
To unsu
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: fixed duplications in disks usage tables (#866492)
..
etl: fixed duplications in disks usage tables (#866492)
This is due to bug in code generation ad
Yaniv Dary has posted comments on this change.
Change subject: etl: fixed duplications in disks usage tables (#866492)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8702
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: core:Power Management: restart operatio..(#865385)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8620
To unsubscribe, vis
Oved Ourfali has posted comments on this change.
Change subject: rest: User can't see its permissions (#868304)
..
Patch Set 1: Verified
Tested VM use-case, with both filtered and non-filtered queries, and it worked
well.
Mich
Oved Ourfali has uploaded a new change for review.
Change subject: rest: User can't see its permissions (#868304)
..
rest: User can't see its permissions (#868304)
https://bugzilla.redhat.com/868304
When asking for object permi
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Improving VdsEventListener.vdsUpEvent
..
engine: Improving VdsEventListener.vdsUpEvent
The following patch will remove an unneeded query for re
Michael Kublin has posted comments on this change.
Change subject: engine: Improving VdsEventListener.vdsUpEvent
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8718
To un
Eli Mesika has posted comments on this change.
Change subject: core: adding engine Maintenance mode.
..
Patch Set 2:
Regarding Kublin comments:
1) Why should we care if it is an internal command, its a maintenance mode and
we
Ohad Basan has uploaded a new change for review.
Change subject: backend: install uuid-ossp extension on postgres 9.2
..
backend: install uuid-ossp extension on postgres 9.2
currently, installing the uuid-ossp extension is hardc
Doron Fediuck has posted comments on this change.
Change subject: core: Make connection timeout configurable
..
Patch Set 4:
Juan,
can you please add the new entries to an upgrade SQL script.
Note that the values should match c
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Improving VdsEventListener.vdsUpEvent
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8718
To unsubscribe, visit ht
Eli Mesika has posted comments on this change.
Change subject: engine: Add search for Networks
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8455
To unsubscribe, visit http://gerrit.ovirt.
Michael Kublin has posted comments on this change.
Change subject: engine: Improving VdsEventListener.vdsUpEvent
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8718
To unsubscribe, visit http://gerrit.ovirt.
Michael Kublin has uploaded a new change for review.
Change subject: engine: Improving VdsEventListener.vdsUpEvent
..
engine: Improving VdsEventListener.vdsUpEvent
The following patch will remove an unneeded query for retrieve s
Allon Mureinik has posted comments on this change.
Change subject: core: adding timestamp to async tasks ...(#868636)
..
Patch Set 2: No score
Yair - yes, indeed.
--
To view, visit http://gerrit.ovirt.org/8668
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding timestamp to async tasks ...(#868636)
..
Patch Set 2:
Allon,
And I hope we all agree that abusing the command parameters for task state
persistenc
Michael Pasternak has posted comments on this change.
Change subject: core: code format
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8714
To unsubscribe, visit http://gerrit.ovi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Increase AJP timeout to 1 hour
..
Patch Set 2: Looks good to me, but someone else must approve
I am not sure this is the only parameter that should be
Roy Golan has submitted this change and it was merged.
Change subject: core: revert the remove of a check in VdsSelector
..
core: revert the remove of a check in VdsSelector
Accidentally removed a check in VdsSelector due to re
Roy Golan has posted comments on this change.
Change subject: core: revert the remove of a check in VdsSelector
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8713
To unsubscribe,
Juan Hernandez has posted comments on this change.
Change subject: packaging: Increase AJP timeout to 1 hour
..
Patch Set 2: Verified
Verified that normal operations work correctly after the change.
--
To view, visit http://ge
Roy Golan has posted comments on this change.
Change subject: core: revert the remove of a check in VdsSelector
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8713
To unsubscribe, visit http://gerrit.ovirt.o
Michael Pasternak has posted comments on this change.
Change subject: packaging: Increase AJP timeout to 1 hour
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8716
To u
1 - 100 of 132 matches
Mail list logo
